[SirKnightly]

Here is the nightly for Windows on 28 Jul 2014 - Revision 10958

Group: Standard
fso_Standard_20140728_r10958.7z
MD5Sum

Group: NO-SSE
fso_NO-SSE_20140728_r10958.7z
MD5Sum

Group: SSE
fso_SSE_20140728_r10958.7z
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r10955 | niffiwan | 2014-07-27 05:15:06 -0500 (Sun, 27 Jul 2014) | 6 lines
Changed paths:
   M /trunk/fs2_open/code/hud/hudtarget.cpp

Fix gcc warnings in hud/hudtarget.cpp

declaration of ‘gauge_object’ shadows a member of 'this'
declaration of ‘esct’ shadows a global declaration [-Wshadow]
variable ‘srange’ set but not used [-Wunused-but-set-variable]
variable ‘ship_is_ballistic’ set but not used
------------------------------------------------------------------------
r10956 | niffiwan | 2014-07-27 05:59:20 -0500 (Sun, 27 Jul 2014) | 4 lines
Changed paths:
   M /trunk/fs2_open/code/weapon/beam.cpp

Fix Coverity 1093822 Uninitialized scalar variable

Set sensible looking defaults for the elems added to the beam_collision
struct since retail
------------------------------------------------------------------------
r10957 | niffiwan | 2014-07-27 06:08:27 -0500 (Sun, 27 Jul 2014) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

Fix Coverity ID 1093805 Uninitialized scalar variable

1st use of fbfire_info.bfi_flags so assign instead of |=
------------------------------------------------------------------------
r10958 | niffiwan | 2014-07-27 06:10:56 -0500 (Sun, 27 Jul 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

Doh! Assign, not equality!
------------------------------------------------------------------------



[Aardwolf]

A warning for when a local variable shadows a member of this? That's... odd. I guess the fact that it can be worked around by doing this->varname doesn't help readability?

[niffiwan]

Some of the GCC shadowing warnings are a bit iffy, after all you usually know when you want the local var vs the function! But it can pick up other issues so its worthwhile shutting them up to avoid other issues being lost in the noise a heaps of warnings.

Here's the change for reference, gauge_object is a function in the parent class.

Code: [Select]

-HudGaugeWeaponList::HudGaugeWeaponList(int gauge_object):
-HudGauge(gauge_object, HUD_WEAPONS_GAUGE, false, false, VM_EXTERNAL | VM_DEAD_VIEW | VM_WARP_CHASE | VM_PADLOCK_ANY, 255, 255, 255)
+HudGaugeWeaponList::HudGaugeWeaponList(int _gauge_object):
+HudGauge(_gauge_object, HUD_WEAPONS_GAUGE, false, false, VM_EXTERNAL | VM_DEAD_VIEW | VM_WARP_CHASE | VM_PADLOCK_ANY, 255, 255, 255)
 {
 
 }