Author Topic: GCC 4.2.1 fixup  (Read 2458 times)

0 Members and 1 Guest are viewing this topic.

Offline rsaxvc

  • 27
    • rsaxvc
Could someone review+apply the attached patch to tips? Basically, "goto done_secondary" was skipping the initialization of "bank_adjusted". This patch moves the initialization of "bank_adjusted" to just after we know the bank, but before we fire any gotos.

[attachment deleted by an evil time traveler]

 

Offline niffiwan

  • 211
  • Eluder Class
Thanks for the patch!  I think this has been committed along with a few other fixes:  http://svn.icculus.org/fs2open?limit_changes=0&view=rev&sortby=file&revision=10156
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...

 

Offline Echelon9

  • 210
Thanks rsaxvc for the bug report and the patch -- I'd seen LLVM/Clang report on this too, but hadn't had time to run it to ground yet.

 
 

Offline niffiwan

  • 211
  • Eluder Class
hmm.. ViewVC has had a few oddities creep in since the icculus.org SVN server died and they rebuilt it...
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Yeah, I've just been dealing with it until we can move to git.  I guess someone could contact them about it though.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays