Author Topic: Maximum filename limit increase  (Read 1576 times)

0 Members and 1 Guest are viewing this topic.

Offline Bryan See

  • Has anyone really been far as decided to use even go want to do look more like?
  • 210
  • Trying to redeem, but under Tiger Parents
    • Skype
    • Steam
    • Twitter
Maximum filename limit increase
Since the FS2 source code release, the maximum filename limit increase has been among the most neglected. Many modders having problems in specifying file names larger than 32 characters. When running either FRED or FS2, an error message usually appears, alerting that the 32-character has been exceeded.

As a result, I've decided to increase the filename limit to 256 in keeping with the modern operating systems such as the recently-released Windows 10. In addition to this, I've increased the callsign limit to 252.

I've made a pull request from my fork at GitHub. Here's my pull request: https://github.com/scp-fs2open/fs2open.github.com/pull/448.
Bryan See - My FreeSpace Wiki User Page (Talk, Contributions)

Full Projects:
Shattered Stars

Campaigns:
Lost in the Mist - Cyrene vs. Psamtik
FreeSpace: Reunited

Ships:
GTS Hygeia, GTT Argo, SC Raguel

Tools:
FSO TC/Game template

I've been under attack by Tiger Parents like Jennifer Pan...

 

Offline zookeeper

  • *knock knock* Who's there? Poe. Poe who?
  • 210
Re: Maximum filename limit increase
Assuming that the change itself is ok (I didn't try to find out), you really need to squash that into one commit.

 

Offline Bryan See

  • Has anyone really been far as decided to use even go want to do look more like?
  • 210
  • Trying to redeem, but under Tiger Parents
    • Skype
    • Steam
    • Twitter
Re: Maximum filename limit increase
I've reforked the FS2 SCP branch from scratch. Here's the link https://github.com/scp-fs2open/fs2open.github.com/pull/451, this time with no unwanted past commits.

EDIT: I've closed the pull request and reverted my fork's commit after reading The E's comments. I know it's not a critical issue nor a showstopper, but an annoyance, indeed. As The E pointed out, getting rid of MAX_PATH_LEN, which is at least tangentially related to MAX_FILENAME_LEN, are among the fixes upon the merger of Antipodes expected after getting through the 3.7.4 release candidate phase.

And, once the Antipodes was merged into the main branch, along with Swifty's PBR, I'm expecting that my branch will become the next one.
« Last Edit: November 19, 2015, 07:17:53 am by Bryan See »
Bryan See - My FreeSpace Wiki User Page (Talk, Contributions)

Full Projects:
Shattered Stars

Campaigns:
Lost in the Mist - Cyrene vs. Psamtik
FreeSpace: Reunited

Ships:
GTS Hygeia, GTT Argo, SC Raguel

Tools:
FSO TC/Game template

I've been under attack by Tiger Parents like Jennifer Pan...

 

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
Re: Maximum filename limit increase
Please take a look at the discussion for your previous PR. This is not, despite appearances, a quick and easy change. It needs to be done with care and proper testing, and as I mentioned there, this change will also necessitate changing the .vp file format to allow long filenames (Or, at the very least, checking whether vps can handle such things).
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns

 

Offline Bryan See

  • Has anyone really been far as decided to use even go want to do look more like?
  • 210
  • Trying to redeem, but under Tiger Parents
    • Skype
    • Steam
    • Twitter
Re: Maximum filename limit increase
Look at my edit above, The E. I agree with you.
Bryan See - My FreeSpace Wiki User Page (Talk, Contributions)

Full Projects:
Shattered Stars

Campaigns:
Lost in the Mist - Cyrene vs. Psamtik
FreeSpace: Reunited

Ships:
GTS Hygeia, GTT Argo, SC Raguel

Tools:
FSO TC/Game template

I've been under attack by Tiger Parents like Jennifer Pan...

 

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
Re: Maximum filename limit increase
And, once the Antipodes was merged into the main branch, along with Swifty's PBR, I'm expecting that my branch will become the next one.

Why would it be? What features do you have in your branches?
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns

 

Offline Bryan See

  • Has anyone really been far as decided to use even go want to do look more like?
  • 210
  • Trying to redeem, but under Tiger Parents
    • Skype
    • Steam
    • Twitter
Re: Maximum filename limit increase
I would like to help the SCP further, but I don't have any features in my branches. I was planning to have features such as model-instancing to increase performance, Vulkan API, OpenCollada support, no 32-character limits, and so on.
Bryan See - My FreeSpace Wiki User Page (Talk, Contributions)

Full Projects:
Shattered Stars

Campaigns:
Lost in the Mist - Cyrene vs. Psamtik
FreeSpace: Reunited

Ships:
GTS Hygeia, GTT Argo, SC Raguel

Tools:
FSO TC/Game template

I've been under attack by Tiger Parents like Jennifer Pan...

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Maximum filename limit increase
We have several high profile features that are already written to at least near-completion, although order completed is no guarantee of being merged into master in a certain order.  But there's 0 chance a branch would be considered for merging if it doesn't have any code yet :P
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline AdmiralRalwood

  • 211
  • The Cthulhu programmer himself!
    • Skype
    • Steam
    • Twitter
Re: Maximum filename limit increase
Also, if by "the next one" you mean "the next Antipodes", I think the general idea is not to have another Antipodes, but rather have regular PR-style branches that might just be maintained on the main repository (e.g. the current Antipodes might be named something like "feature/sdl-everywhere") so that everyone can contribute to them.
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.