Author Topic: Autogenerated shield icons look weird  (Read 353 times)

0 Members and 1 Guest are viewing this topic.

Online Spoon

  • 212
  • ♪ ♬ ヾ(´︶`♡)ノ ♬
Autogenerated shield icons look weird
Yo dawgs, whats up with this yo yo
from

to

From a build I received on 2017/02/12
These shield edges look like they could stab someone something fierce.
Urutorahappī!!

[02:42] <@Axem> spoon somethings wrong
[02:42] <@Axem> critically wrong
[02:42] <@Axem> im happy with these missions now
[02:44] <@Axem> well
[02:44] <@Axem> with 2 of them

 

Offline z64555

  • 210
  • Self-proclaimed controls expert
    • Minecraft
    • Steam
Re: Autogenerated shield icons look weird
Looks like it's drawing triangles instead of quads...

Do you have any more information about the build, like what commit it's based on?

EveningTea: Time to go Freeman on this cultist..
* EveningTea pulls crowbar off his shoulderstrap and charges screaming incoherently across the marsh *

z64555: bro. do you even salad

 

Online Spoon

  • 212
  • ♪ ♬ ヾ(´︶`♡)ノ ♬
Re: Autogenerated shield icons look weird
Dahblount told me:
[19:38] <DahBlount[mobile]> It was based off the orientation changes, commit 02ae98c
Urutorahappī!!

[02:42] <@Axem> spoon somethings wrong
[02:42] <@Axem> critically wrong
[02:42] <@Axem> im happy with these missions now
[02:44] <@Axem> well
[02:44] <@Axem> with 2 of them

 

Offline niffiwan

  • 211
  • Eluder Class
Re: Autogenerated shield icons look weird
I can't find that commit in master  :confused: 

DahBlount, can you shed some more light?
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Linux OBS Packages: FSO 3.7.0 | FSO BP Build | wxLauncher (?) | PCS2 (?) | wxVPView (?)
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...

 

Online AdmiralRalwood

  • 211
  • Mister Subspace Strikes
    • Skype
    • Steam
    • Twitter
Re: Autogenerated shield icons look weird
I can't find that commit in master  :confused: 
You couldn't find this commit?
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.

 

Offline niffiwan

  • 211
  • Eluder Class
Re: Autogenerated shield icons look weird
Dahblount told me:
[19:38] <DahBlount[mobile]> It was based off the orientation changes, commit 02ae98c

I can't find that commit in master  :confused: 
You couldn't find this commit?

02ae98c
028ae98

Given the originally quoted hash was wrong and I only had 30 secs at the time, no I couldn't :p

edit: finally had time to reproduce & bisect; github issue has been logged
« Last Edit: February 25, 2017, 06:10:33 am by niffiwan »
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Linux OBS Packages: FSO 3.7.0 | FSO BP Build | wxLauncher (?) | PCS2 (?) | wxVPView (?)
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...

 

Offline m!m

  • 210
Re: Autogenerated shield icons look weird
I found the issue and submitted a fix for review: https://github.com/scp-fs2open/fs2open.github.com/pull/1262

The error occurred because the render code only rendered 4 of the 6 vertices that are required for the shield icon.

 

Online Spoon

  • 212
  • ♪ ♬ ヾ(´︶`♡)ノ ♬
Re: Autogenerated shield icons look weird
 :yes:
Urutorahappī!!

[02:42] <@Axem> spoon somethings wrong
[02:42] <@Axem> critically wrong
[02:42] <@Axem> im happy with these missions now
[02:44] <@Axem> well
[02:44] <@Axem> with 2 of them