Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Nightly Builds => Topic started by: SirKnightly on January 30, 2017, 02:35:47 am

Title: Nightly: 30 January 2017 - Revision 2a574ef
Post by: SirKnightly on January 30, 2017, 02:35:47 am
Here is the nightly for 30 January 2017 - Revision 2a574ef



Group: Linux
nightly_20170130_2a574ef-builds-Linux.tar.gz (https://dl.bintray.com/scp-fs2open/FSO/nightly_20170130_2a574ef-builds-Linux.tar.gz)
SHA1: c24738aaddb9b856ba4715ff2ca3028c1b2d9e4e


Group: MacOSX
nightly_20170130_2a574ef-builds-MacOSX.tar.gz (https://dl.bintray.com/scp-fs2open/FSO/nightly_20170130_2a574ef-builds-MacOSX.tar.gz)
SHA1: 09273d1f2ed05a31ee8d71c90364bd305a23858d


Group: Win32
nightly_20170130_2a574ef-builds-Win32.zip (https://dl.bintray.com/scp-fs2open/FSO/nightly_20170130_2a574ef-builds-Win32.zip)
SHA1: c989414d2104689fbe72e4f5b9f5280841571422


Group: Win64
nightly_20170130_2a574ef-builds-Win64.zip (https://dl.bintray.com/scp-fs2open/FSO/nightly_20170130_2a574ef-builds-Win64.zip)
SHA1: 4708a9e4decf159746b1d4e9e9c3c21d2e499685


Code: [Select]
------------------------------------------------------------------------
commit 2a574ef
Author: Goober5000 <Mon Jan 30 00:58:15 2017 -0500>
Commit: MageKing17 <Sun Jan 29 21:58:15 2017 -0800>

    some riffs on PR #806 (#1163)
 code/ship/ship.cpp | 2 ++
 1 file changed, 2 insertions(+)

------------------------------------------------------------------------
commit db3e2ae
Author: z64555 <Sun Jan 29 15:35:02 2017 -0600>
Commit: z64555 <Sun Jan 29 15:35:02 2017 -0600>

    Doxy vm_vector_2_matrix functions. *Enforce if-else block style within vecmat.cpp.
 code/math/vecmat.cpp | 19 +++++++++++--------
 code/math/vecmat.h   | 38 +++++++++++++++++++++++++++++++-------
 2 files changed, 42 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit b13ee73
Author: asarium <Wed Jan 25 19:57:07 2017 +0100>
Commit: asarium <Wed Jan 25 19:57:07 2017 +0100>

    Fix null vector normalization in ship select screen
 code/math/vecmat.cpp | 80 ++++++++++++++++++++++++++--------------------------
 1 file changed, 40 insertions(+), 40 deletions(-)
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: Nightstorm on January 30, 2017, 09:27:36 pm
Something happened to the secondary weapons in this build.  With the 29 Jan build there is no issue.  With this one once the first four missiles are launched off of a MKVII Viper in Diaspora you cannot launch any of the second four, that's with a loadout of eight anti-fighter missiles.

There is no error, it just won't launch them.  You still get a missile lock and tone, and the first missile of the second bank is selected it just won't fire.

I've found if you cycle to the second set of missile it won't launch them, however if you cycle back to the first set then they all seem to work correctly.

So, to summarize, If you don't cycle your secondary stores the second set of four will not launch.  As long as you do cycle them from second group back to first group they seem to work normally again.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: z64555 on January 31, 2017, 12:49:16 pm
I haven't been able to repro this behavior in free flight, which mission did the error occur on?
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: Nightstorm on January 31, 2017, 02:16:24 pm
It's a custom one I wrote, Aerilon is Burning, it can be downloaded under Diaspora 3rd party missions.

It's not a critical issue as cycling the secondary banks allows them to work normally, however it did crop up with this build.  I was able to reproduce it and eliminate it by using the 29th or 30th nightly builds.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: z64555 on January 31, 2017, 02:55:32 pm
Ok, I tried downloading it, but it appears dropbox is having none of it. Would you please provide another copy of it?
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: Nightstorm on January 31, 2017, 04:22:07 pm
It seems to be working for me;  https://dl.dropboxusercontent.com/u/40373136/Aerilon_is_Burning.7z

But here's a Mega link too:  https://mega.nz/#!EYBzzZyC!hlkXN-X1ih4CdVlZ4Kaftpz0Q_YMR1lJIxDVOyLdvoA

The file is a 20MB 7z with a vp inside.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: z64555 on January 31, 2017, 08:31:00 pm
Huh. the link seems to be working again. I guess dropbox was down for awhile?

Anyway, I'll give this a look over and hopefully will find what's causing the error.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: z64555 on January 31, 2017, 11:48:07 pm
Ok, I'm still having trouble repro'ing the issue, even with the nighthly.

Hm. Are you using the 32bit or the 64bit executable? What does it say in wxLauncher's box?

Also which mission specifically does the error occur? I'm already flown the raptor, a MKVII, and the MKVIIe and have yet to come across the issue.

You could try running a debug build, but last time I did that with diaspora I got flooded with a bunch of warnings complaining about the model radius of every ship.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: JSRNerdo on February 01, 2017, 12:00:44 am
for some reason this one completely utterly breaks my mission http://www.hard-light.net/forums/index.php?topic=93097.msg1840569#new while 6bc1e1c works fine

The railguns just pass right through the enemy cruisers at the speed of light. Sometimes they hit, but they hit instantly. But only when I use auto-aim, it works normally otherwise. When auto-aimed, they go the speed of light.

Enemy ships warp in at ridiculous ranges. My player even reports that using the railguns also makes enemy cruisers just bounce around like a mega morning star like it's JAD 4.44.

When Alpha 3 dies, I am sent to hell. There's nothing, just a black void. All distance indicators go away. Everything goes away. There is only darkness.

I am terrified.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: JSRNerdo on February 01, 2017, 12:17:47 am
https://www.youtube.com/watch?v=Gqxk6_xoVlU&feature=youtu.be
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: z64555 on February 01, 2017, 12:59:40 am
Alright, I've found that NightStorm's issue only happens on 64-bit builds, the 32-bit builds work just fine. It's quite likely that JSRNerdo's problems are also due to the 64-bit build.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: m!m on February 01, 2017, 02:44:43 am
These issues were probably all used by a mistake I made while fixing some of the vector math code. I found the issue and a fix has already been submitted: https://github.com/scp-fs2open/fs2open.github.com/pull/1167

It's probably safe to say that this bug causes a lot of issues so it's likely that all the bugs reported by JSRNerdo are caused by this mistake.
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: AdmiralRalwood on February 01, 2017, 04:55:40 am
And I've fixed the second-secondary-bank-not-firing-until-cycled-through bug: https://github.com/scp-fs2open/fs2open.github.com/pull/1168
Title: Re: Nightly: 30 January 2017 - Revision 2a574ef
Post by: Nightstorm on February 01, 2017, 06:12:10 am
Awesome!  Thank you guys!