Author Topic: Mother ****in personas  (Read 1923 times)

0 Members and 1 Guest are viewing this topic.

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Mother ****in personas
Yo I want to tell you about a behavior which is Not Good, It's Bad:

If a persona does not have a message specified for a specific condition (say, rearm) it randomly grabs a line from another persona and uses it.

This is weird and strange. Maybe I don't want Shivan Fighter Bob to ever talk about calling for support. Could we get a flag to disable it?

 

Offline AdmiralRalwood

  • 211
  • The Cthulhu programmer himself!
    • Skype
    • Steam
    • Twitter
Re: Mother ****in personas
It looks like it should be fairly easy to add relevant code to the message_send_builtin_to_player() function in missionmessage.cpp to initialize best_match to a higher value based on some property of the Persona; this would cause it to not consider lower-quality matches (e.g. "same species") to be valid choices. We'd also need to make the function abort gracefully if there are no valid matches (it currently hits an Int3() if that's the case).
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Re: Mother ****in personas
Yo I want to tell you about a behavior which is Not Good, It's Bad:

Speaking of which, there's no need to tarnish perfectly reasonable questions with gratuitous vulgar language.  It's not going to get your request handled any faster.  Warning issued.
« Last Edit: October 25, 2015, 06:11:22 pm by Goober5000 »

 

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Re: Mother ****in personas
Correction: I am a stupid person
« Last Edit: November 13, 2015, 07:29:40 pm by General Battuta »

 

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns

 

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Re: Mother ****in personas
Request handled! Thank you scp bamfs. I'll let you know if it does anything strange.