Author Topic: Release: 3.7.0 RC1  (Read 12706 times)

0 Members and 1 Guest are viewing this topic.

Always Like it when i don't feel like an idiot ;)

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️À➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
I wonder if it's the actual version bump to 3.7.0 that is causing the problem with the code then.  We need to audit anything that actually checks the build version in the code for potential issues it seems.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Yarn

  • 210
I wonder if it's the actual version bump to 3.7.0 that is causing the problem with the code then.  We need to audit anything that actually checks the build version in the code for potential issues it seems.
The problem is that FSO expects all three numbers in the version tag to be less than or equal to the respective numbers in the build version. For example, a line beginning with ;;FSO 3.6.13;; should load in 3.7.0, but it doesn't because 13 is greater than 0. The bug most likely existed ever since version tags were implemented but has not become apparent until now.

I've attached a patch that corrects this behavior.

[attachment deleted by ninja]
"Your fighter is running out of oil.  Please check under the hood and add more if necessary"
--strings.tbl, entry 177

"Freespace is very tired.  It is shutting down to get some rest."
--strings.tbl, entry 178

 

Offline Goober5000

  • HLP Loremaster
  • Administrator
  • 214
    • Goober5000 Productions
Heh, whoops.  I've reviewed and applied Yarn's patch.  It won't be in the next nightly build, since those are based on trunk instead of the RC branch, but it'll be in the next RC.

 

Offline Yarn

  • 210
I think that Mantis 2753 needs to be addressed before 3.7 goes final.
"Your fighter is running out of oil.  Please check under the hood and add more if necessary"
--strings.tbl, entry 177

"Freespace is very tired.  It is shutting down to get some rest."
--strings.tbl, entry 178

 

Offline mjn.mixael

  • Cutscene Master
  • 212
  • Anims: 418, Cutscenes: 8, Mainhalls: 7, Logos: 52
    • Steam
    • Twitter
    • Mix-Hai Productions
I've set it's target version to 3.7.
Cutscene Upgrade Project - Mainhall Remakes - MixaelANITools - Between the Ashes - MjnMixael's Render Boutique - Mix-Hai Productions
Youtube Channel - P3D Model Box - Photobucket Albums - Model Releases - Downloads
Between the Ashes is looking for committed testers, PM me for details.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!

 
Hi!
What about Mantis 2801? Or do just very few people get this?

 

Offline Yarn

  • 210
Hi!
What about Mantis 2801? Or do just very few people get this?
That appears to happen only with the German version. Since most of us have only the English version, not many people encounter that bug.

Try this: Using a new, fresh pilot, play through the campaign without the MediaVPs. If you don't get the crash this time, then the bug is most likely related to the data in the MediaVPs.
"Your fighter is running out of oil.  Please check under the hood and add more if necessary"
--strings.tbl, entry 177

"Freespace is very tired.  It is shutting down to get some rest."
--strings.tbl, entry 178

 

Offline Solatar

  • Supreme Admiral
  • 211
I wonder if it's the actual version bump to 3.7.0 that is causing the problem with the code then.  We need to audit anything that actually checks the build version in the code for potential issues it seems.

I've been playing the new FSPort with Dan Wentz's music, and it reverts to the original music when I switch from 3.6.19 (r9638) to 3.7 RC 1.  The .tbm file in the port uses the ;; 3.6.0 tag for most of the soundtracks, although the file names are the same.

e: actually, it's not a problem with the new music, since it reverts to original Freespace 2 music.  It must be discarding the version tagged FS1 soundtracks added by the Port.
« Last Edit: April 21, 2013, 06:15:25 pm by Solatar »

 
Yes, we definitely can and will.
*Dusts off 4-months-old patch files*
Yayfication + 1

*Grabs RC*
Hammertime's up. It's testing time!

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️À➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
I wonder if it's the actual version bump to 3.7.0 that is causing the problem with the code then.  We need to audit anything that actually checks the build version in the code for potential issues it seems.

I've been playing the new FSPort with Dan Wentz's music, and it reverts to the original music when I switch from 3.6.19 (r9638) to 3.7 RC 1.  The .tbm file in the port uses the ;; 3.6.0 tag for most of the soundtracks, although the file names are the same.

e: actually, it's not a problem with the new music, since it reverts to original Freespace 2 music.  It must be discarding the version tagged FS1 soundtracks added by the Port.

Well, we think it's sorted out in trunk now.  The next RC will be able to tell for sure.  You can test the latest nightly though to make sure it's at least working there.  There will be a new windows one within the next couple of hours.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Echelon9

  • 210
Proposing that the fix for Mantis 2853: AddressSanitizer: heap-buffer-overflow in change_ship_type() be ported to the next available RC.

This bug may lead to a range of subtle and hard to track down bugs any time a user changes ship pre-mission.

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️À➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Plan is still to sync all trunk commits to the 3.7.0 branch.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Yarn

  • 210
Mantis 2849 should be fixed too; a fix is attached a fix to that ticket. At least two others have noticed its effect. (And I probably should have set its severity to major; oh well.)
"Your fighter is running out of oil.  Please check under the hood and add more if necessary"
--strings.tbl, entry 177

"Freespace is very tired.  It is shutting down to get some rest."
--strings.tbl, entry 178

 

Offline FUBAR-BDHR

  • Self-Propelled Trouble Magnet
  • 212
  • Master Drunk
    • 165th Beer Drinking Hell Raisers
Mantis 2849 should be fixed too; a fix is attached a fix to that ticket. At least two others have noticed its effect. (And I probably should have set its severity to major; oh well.)

Committed r9650. 
No-one ever listens to Zathras. Quite mad, they say. It is good that Zathras does not mind. He's even grown to like it. Oh yes. -Zathras

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Minecraft
    • Steam
    • Twitter
    • ModDB Feature
Code Review for 2753 should be tested as well, has been tested and needs to be in the next RC.

Commit 9655 needs examination, it is breaking current play-through. Correction, the reference for the look-up on the filename needs to be reviewed. I think it would be a lot easier to not try and look for -normal/-shine/-glow files for ANI or EFF files, I think that it what is tripping it up.
« Last Edit: April 29, 2013, 01:00:28 am by Zacam »
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the FSU on #SCP-FSU Talk with the SCP on #SCP
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️À➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
How about only look for them if the combined filename is short enough, and if it's not, log that they couldn't even be scanned for because the filename was too long?  Unless we're certain that we'll never want to have EFF normals/shines/glows.  I don't know if we can make that assumption though.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline mjn.mixael

  • Cutscene Master
  • 212
  • Anims: 418, Cutscenes: 8, Mainhalls: 7, Logos: 52
    • Steam
    • Twitter
    • Mix-Hai Productions
Yeah... We do have animated textures to consider, right?
Cutscene Upgrade Project - Mainhall Remakes - MixaelANITools - Between the Ashes - MjnMixael's Render Boutique - Mix-Hai Productions
Youtube Channel - P3D Model Box - Photobucket Albums - Model Releases - Downloads
Between the Ashes is looking for committed testers, PM me for details.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!

 

Offline z64555

  • 210
  • Self-proclaimed controls expert
    • Minecraft
    • Steam
Quick question. Does anybody know if the Joystick axes are saved?
I'm on Facebook! sort of. Zeesixtyfour Fivefiftyfive

-=wxFRED2=-
R.I.P. Oliver
------------
EveningTea: Time to go Freeman on this cultist..
* EveningTea pulls crowbar off his shoulderstrap and charges screaming incoherently across the marsh *
------------
z64555: bro. do you even salad
------------
z64555: suprise double quaternion!

 

Offline The E

  • He's Ebeneezer Goode
  • Global Moderator
  • 213
  • Nothing personal, just tech support.
    • Skype
    • Steam
    • Twitter
We've had animated glows for a long time. There's no reason to disable them now, or declare animated normals and shines off-limits. There may be better ways to achieve these effects, but until those are implemented, removing this feature strikes me as distinctly unwise.
**** every cause that ends in murder and children crying. ― Iain Banks
Join the fun at the HLP IRC channel. Get the latest spam and gossip as long as it's fresh!