[m!m]

I added a OriginClass variable to the Debris handle to have access to the origin shipclass and a isValid() function as it didn't exist before.
Can a coder please review my changes?

[attachment deleted by ninja]

[The E]

Comitted to trunk in rev 7270

[m!m]

Thank you very much

[m!m]

I have another patch which adds access to the radius of a debris object.
Nothing big but can someone review it?

[attachment deleted by ninja]

[The E]

Committed as 7354.

[m!m]

And I have another patch for some scripting functions:
I added access to the collision information of a weapon by saving the mc_info struct inside the weapon. The critical thing I did was that I needed to allocate the collision information which would be added to the scripting system using new as I can't use a pointer to the struct inside the weapon as the weapon will not be in memory forever. The memory should be freed correctly as I delete the pointer inside the lua __gc function.
I'd like to ask for feedback from a coder whether I broke something or not

[attachment deleted by ninja]

[Dragon]

Anybody looked into it?
If that patch gets adopted, some interesting things will become scriptable.

[The E]

Patch is in as of revision 7418.

[m!m]

I noticed that I missed to add the collision info to the object:checkRayCollision() function where is is very helpful to get additional informations.
Can a coder review it please, it shouldn't break anything and I have tested it

[attachment deleted by ninja]

[The E]

In as of rev 7512

[m!m]

I needed to add another two functions which allow me to manipulate the afterburner data of a ships physics (adding a AfterburnerActive filed to the Physics handle) and an unhackish way to know if a subsystem is a turret or not (added isTurret() to subsystem handle).

The second patch deals with possibly unwanted behavior in the "On Mission Start" hook. There the Player Hookvariable wasn't set although it would be very helpful to have it available. The second thing is that at the time that hook is called the mission is technically not in Mission (the GM_IN_MISSION flag is missing) which causes that most mn.* functions don't work. Currently I need to know the mission filename in that hook but without that flag being set mn.getMissionFilename() always returns an empty string. I "solved" it by temporarily adding the flag when executing the hook and removing it again afterwards but I'm not sure what side effects it has

[attachment deleted by ninja]

[pecenipicek]

I would like to request a feature to be able to fire a primary or secondary gunbank on a ship. not the currently selected one as the <ship handle>.firePrimary(<ship handles>) works, but an absolute gb.

basically something like: <ship handle>.firePrimary[<ship handle>,<gunbank index>, ...] and the ability to fire more than one gunbank at once.



or, if thats possible already, can someone just quickly walk me through how to do it?

[m!m]

So did someone take a look at the patches yet?

[The E]

I have them, will take a look later and commit as needed.

[m!m]

I have a new patch which adds access to the Viewer_mode as I need to know if the view is currently in the cockpit or not.
I'd be grateful if a coder could take a look at it.

[attachment deleted by ninja]

[Echelon9]

I have a new patch which adds access to the Viewer_mode as I need to know if the view is currently in the cockpit or not.
I'd be grateful if a coder could take a look at it.

Reviewed, and committed to trunk.

[m!m]

Here is a new patch
While working on a script for Diaspora I noticed that the scripting API does contain some sound functions but these function were lacking information which I needed. I also noticed that there were some handle definitions for a soundentry handle and a sound handle which weren't implemented completely. So I just completed those parts and added some new function to the Audio library to use the new handles.
I completed the soundentry handle which represents an entry in sounds.tbl or more precisely an index into the Snds Vector.
This handle can be used to play a sound either normally, looping or in 3D where the 3D function also returns a specialized handle which also gives access to the special 3D functions (currently only one).

Can a coder take a look at it?
Thankyou

[attachment deleted by ninja]

[m!m]

 
 
Is there anything wrong with it? I really need it for a script for Diaspora...

[zookeeper]

This thread looks like a good place to post this little patch, which adds a kill() function to asteroids. With this, scripts can actually kill asteroids, whereas previously you'd have needed to spawn a fake weapon to hit and destroy them.

Code: [Select]

Index: lua.cpp
===================================================================
--- lua.cpp (revision 7927)
+++ lua.cpp (working copy)
@@ -4627,6 +4627,30 @@
 
 }
 
+ADE_FUNC(kill, l_Asteroid, "[ship killer=nil, wvector hitpos=nil]", "Kills the asteroid. Set \"killer\" to designate a specific ship as having been the killer, and \"hitpos\" to specify the world position of the hit location; if nil, the asteroid center is used.", "boolean", "True if successful, false or nil otherwise")
+{
+ object_h *victim,*killer=NULL;
+ vec3d *hitpos=NULL;
+ if(!ade_get_args(L, "o|oo", l_Asteroid.GetPtr(&victim), l_Ship.GetPtr(&killer), l_Vector.GetPtr(&hitpos)))
+ return ADE_RETURN_NIL;
+
+ if(!victim->IsValid())
+ return ADE_RETURN_NIL;
+
+ if(killer != NULL && !killer->IsValid())
+ return ADE_RETURN_NIL;
+
+ if (!hitpos)
+ hitpos = &victim->objp->pos;
+
+ if (killer)
+ asteroid_hit(victim->objp, killer->objp, hitpos, victim->objp->hull_strength + 1);
+ else
+ asteroid_hit(victim->objp, NULL,         hitpos, victim->objp->hull_strength + 1);
+
+ return ADE_RETURN_TRUE;
+}
+
 //**********HANDLE: Shipclass
 ade_obj<int> l_Shipclass("shipclass", "Ship class handle");
 extern int ships_inited;


[Aardwolf]

Ooo, nice one. And you got the optional arguments too!