Author Topic: Bloooooommm  (Read 8060 times)

0 Members and 1 Guest are viewing this topic.

Offline Axem

  • 211
Hey so in the mediavps open beta thread, there was a heated discussion about proper bloom settings and stuff. The mediavps can't really do much about it, because the code defaults to 75 no matter what the mediavps would try to do anyway. Only the user can change it with a command line flag that's not really documented within the launcher.

Is it possible to have some sort of post_processing.tbl option that allows the changing of the bloom flag so mods can, at their own discretion, change their bloom field to match their settings? Of course, that setting would be superseded by the -bloom_intensity flag, should someone want to be blinded by nebulas and stuff.

(Also making the default like 20 or something would be rad as well)

 
I agree with this.
Default 20 would be very helpful.

Bh

 

Offline Fury

  • The Curmudgeon
  • 213
I believe more appropriate place for this would be the mod.tbl (or whatever its name is) that karajorma was/is working on. It should hold the default values for any command line options.

 
Yeah, that kind of mod-wide setting should be in game_settings.tbl

 

Offline niffiwan

  • 211
  • Eluder Class
Well, bloom only works when post processing is enabled, so I'd have thought that post_processing.tbl was the best place for the mod defined default.  I thought that game_settings.tbl was supposed to be for settings that didn't really fit anywhere else.
Creating a fs2_open.log | Red Alert Bug = Hex Edit | MediaVPs 2014: Bigger HUD gauges | 32bit libs for 64bit Ubuntu
----
Debian Packages (testing/unstable): Freespace2 | wxLauncher
----
m|m: I think I'm suffering from Stockholm syndrome. Bmpman is starting to make sense and it's actually written reasonably well...

 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
I tend to agree with post_processing.tbl is the place for this.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]

 

Offline Macfie

  • 210
  • If somebody made a campaign I've probably got it
There are all kinds of defaults for lighting which most people don't use.  We have a section in the FreeSpace Wiki that deals with that and an option in the launcher to use different sample lighting schemes.  Maybe it should have a section for Bloom.  I don't much care if we change the default as long as there is an easy way to adjust the settings.  The command line works fine for me.  I don't want to be locked into a particular setting by it being in a table that has to be modified.  Lighting settings including bloom would depend on a person's preferences, the campaign's mission backgrounds or the monitor being used.  I find I often change the lighting setting based on the campaign I'm playing or the computer I'm playing on.
Normal people believe that if it isn't broke, don't fix it. Engineers believe that if it isn't broke, it doesn't have enough features yet.
The difference between Mechanical Engineers and Civil Engineers is:
Mechanical Engineers build weapons.  Civil Engineers build targets
An optimist sees the glass half full; the pessimist sees it half empty. An engineer sees that the glass is twice as big as it needs to be.

 

Offline mjn.mixael

  • Cutscene Master
  • 212
  • Chopped liver
    • Steam
    • Twitter
Since this is starting to head down the road of 'modder's choice vs player's choice', I will say that I think wxL found the compromise for lighting settings that we've long been hoping for. They have (or are working on) a way for mods to have 'recommended lighting settions' as a radio button. It's perfect. Users can input whatever commandline they want, but mods have a way to say 'we recommend this'.

The defaults, don't really matter much to me either. But it seems to me that a system where Table is overwritten by Commandline while mods have a tool to offer a Recommended Setting, hits all the necessary points. Just wonder if wxL's radio buttons work with Bloom.
Cutscene Upgrade Project - Mainhall Remakes - Between the Ashes
Youtube Channel - P3D Model Box
Between the Ashes is looking for committed testers, PM me for details.
Freespace Upgrade Project See what's happening.

 

Offline headdie

  • i don't use punctuation lol
  • 212
  • Lawful Neutral with a Chaotic outook
    • Skype
    • Twitter
    • Headdie on Deviant Art
Since this is starting to head down the road of 'modder's choice vs player's choice', I will say that I think wxL found the compromise for lighting settings that we've long been hoping for. They have (or are working on) a way for mods to have 'recommended lighting settions' as a radio button. It's perfect. Users can input whatever commandline they want, but mods have a way to say 'we recommend this'.

The defaults, don't really matter much to me either. But it seems to me that a system where Table is overwritten by Commandline while mods have a tool to offer a Recommended Setting, hits all the necessary points. Just wonder if wxL's radio buttons work with Bloom.

this would be my preference, while a mod has the right to say this is how we think it should be played ultimately its the player who should decide how its played and they shouldn't need *any* modding skills to do it no matter how rudimentary they might be.  so yes wxLauncher recommendations overridden by player preference all the way.  personally for example i hate bloom
Minister of Interstellar Affairs Sol Union - Retired
quote General Battuta - "FRED is canon!"
Contact me at [email protected]
My Release Thread, Old Release Thread, Celestial Objects Thread, My rubbish attempts at art

 

Offline AdmiralRalwood

  • 211
  • The Cthulhu programmer himself!
    • Skype
    • Steam
    • Twitter
I don't want to be locked into a particular setting by it being in a table that has to be modified.
The suggestion was that post_processing.tbl would change the default Bloom value, not override the commandline setting.
Ph'nglui mglw'nafh Codethulhu GitHub wgah'nagl fhtagn.

schrödinbug (noun) - a bug that manifests itself in running software after a programmer notices that the code should never have worked in the first place.

When you gaze long into BMPMAN, BMPMAN also gazes into you.

"I am one of the best FREDders on Earth" -General Battuta

<Aesaar> literary criticism is vladimir putin

<MageKing17> "There's probably a reason the code is the way it is" is a very dangerous line of thought. :P
<MageKing17> Because the "reason" often turns out to be "nobody noticed it was wrong".
(the very next day)
<MageKing17> this ****ing code did it to me again
<MageKing17> "That doesn't really make sense to me, but I'll assume it was being done for a reason."
<MageKing17> **** ME
<MageKing17> THE REASON IS PEOPLE ARE STUPID
<MageKing17> ESPECIALLY ME

<MageKing17> God damn, I do not understand how this is breaking.
<MageKing17> Everything points to "this should work fine", and yet it's clearly not working.
<MjnMixael> 2 hours later... "God damn, how did this ever work at all?!"
(...)
<MageKing17> so
<MageKing17> more than two hours
<MageKing17> but once again we have reached the inevitable conclusion
<MageKing17> How did this code ever work in the first place!?

<@The_E> Welcome to OpenGL, where standards compliance is optional, and error reporting inconsistent

<MageKing17> It was all working perfectly until I actually tried it on an actual mission.

<IronWorks> I am useful for FSO stuff again. This is a red-letter day!
* z64555 erases "Thursday" and rewrites it in red ink

<MageKing17> TIL the entire homing code is held up by shoestrings and duct tape, basically.

 

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
Indeed. User preference should always take priority, it's only in cases where the user hasn't changed this option that the default should be used.
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns

 
A comparison with the suggested intensity value of 20.

MediaVP_3612 with Bloom_intensity 75


MediaVP_2014_beta with Bloom_intensity 20


So as you can see, MediaVP_2014 nebulas are still bloomier with an intensity of 20 than MediaVP_3612 are with a default intensity of 75. MediaVP_2014 nebulas produce white burnt spots even at intensity of 15, whileas MediaVP_3612 nebulas have very little white spots even at bloom intensity of 75.

If you want to recalibrate the default value of bloom intensity in SCP engine, it probably needs to be even lower than 20. OR, someone with more experience in post-processing should probably look at the bloom code in an attempt to prevent the birth of these white burnt spots when a higher resolution is used in nebula graphics (that seems to be a correlation here).

 

Offline MatthTheGeek

  • Captain Obvious
  • 212
  • Frenchie McFrenchface
Problem ain't bloom.

Code: [Select]
$Name: saturation
$Uniform: saturation
$Define: FLAG_SATURATION
$AlwaysOn: true
$Default: 1.28
$Div: 50
$Add: 0

$Name: brightness
$Uniform: brightness
$Define: FLAG_BRIGHTNESS
$AlwaysOn: true
$Default: 1.48
$Div: 50
$Add: 0
Learn to blame the right things.
People are stupid, therefore anything popular is at best suspicious.

Mod management tools     -     Wiki stuff!     -     Help us help you

666maslo666: Releasing a finished product is not a good thing! It is a modern fad.

SpardaSon21: it seems like you exist in a permanent state of half-joking misanthropy

Axem: when you put it like that, i sound like an insane person

bigchunk1: it's not retarded it's american!
bigchunk1: ...

batwota: steele's maneuvering for the coup de gras
MatthTheGeek: you mispelled grâce
Awaesaar: grace
batwota: oh right :P
Darius: ah!
Darius: yes, i like that
MatthTheGeek: the way you just spelled it it means fat
Awaesaar: +accent I forgot how to keyboard
MatthTheGeek: or grease
Darius: the killing fat!
Axem: jabba does the coup de gras
MatthTheGeek: XD
Axem: bring me solo and a cookie

 
Right. There appears to be a great overflow of saturation and brightness when higher resolution nebulas are being post-processed. But on the technical side, I admit I have no idea what would cause this correlation between higher resolutions and overflows.

 

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
The correlation is that, at some point between the 3.6.12 MVPs and the 2014 MVPs, the post process table was altered to increase the brightness and saturation values. In concert with bloom, this causes the artefacts you're seeing.
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns

 

Offline MatthTheGeek

  • Captain Obvious
  • 212
  • Frenchie McFrenchface
Right. There appears to be a great overflow of saturation and brightness when higher resolution nebulas are being post-processed. But on the technical side, I admit I have no idea what would cause this correlation between higher resolutions and overflows.
I don't know why you keep going back to the irrelevant higher resolutions that aren't even remotely related to the subject at hand.

If you applied that post-proc table and those bloom values on retail assets you'd have similar output. Assets are not in cause here.
People are stupid, therefore anything popular is at best suspicious.

Mod management tools     -     Wiki stuff!     -     Help us help you

666maslo666: Releasing a finished product is not a good thing! It is a modern fad.

SpardaSon21: it seems like you exist in a permanent state of half-joking misanthropy

Axem: when you put it like that, i sound like an insane person

bigchunk1: it's not retarded it's american!
bigchunk1: ...

batwota: steele's maneuvering for the coup de gras
MatthTheGeek: you mispelled grâce
Awaesaar: grace
batwota: oh right :P
Darius: ah!
Darius: yes, i like that
MatthTheGeek: the way you just spelled it it means fat
Awaesaar: +accent I forgot how to keyboard
MatthTheGeek: or grease
Darius: the killing fat!
Axem: jabba does the coup de gras
MatthTheGeek: XD
Axem: bring me solo and a cookie

 
I don't know why you keep going back to the irrelevant higher resolutions that aren't even remotely related to the subject at hand.

Because I didn't know the truth and I was desperate to find even some reasons for this apparently unintuitive change in overall visuality. That was before I learned this:

Quote
at some point between the 3.6.12 MVPs and the 2014 MVPs, the post process table was altered to increase the brightness and saturation values.

If someone would have said this in the first place, I wouldn't have had to speculate about it at all :D

EDIT: spelling
« Last Edit: December 20, 2013, 02:18:40 pm by Lykurgos88 »

 

Offline Kolgena

  • 211
Problem ain't bloom.

Code: [Select]
$Name: saturation
$Uniform: saturation
$Define: FLAG_SATURATION
$AlwaysOn: true
$Default: 1.28
$Div: 50
$Add: 0

$Name: brightness
$Uniform: brightness
$Define: FLAG_BRIGHTNESS
$AlwaysOn: true
$Default: 1.48
$Div: 50
$Add: 0
Learn to blame the right things.

Bam. What a find. Btw, who the hell decided to push saturation and brightness that high as defaults? You'd have blown colors even without bloom on.

As an aside, compressed vs uncompressed textures basically comes down to blocking and/or ringing as artefacts. It's not even necessarily true that compressed textures are lower resolution compared to originals. Sometimes, if compression is fairly heavy, you get very slight loss of saturation or color accuracy.

The point is, to the casual eye or on a cruddy monitor, uncompressed and compressed textures should look virtually identical in almost all situations. (The only exception I've come across is using the new, smooth nebula poofs that aren't in the beta. While they're great as uncompressed textures, they become a blocky mess if you used compressed versions).
« Last Edit: December 20, 2013, 01:13:46 pm by Kolgena »

  

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
Here's the post_processing.tbl that shipped with the 3.6.12 MVPs:

Code: [Select]
#Effects

$Name: distort noise
$Uniform: noise_amount
$Define: FLAG_DISTORT_NOISE
$AlwaysOn: false
$Default: 0.0
$Div: 20000
$Add: 0

$Name: saturation
$Uniform: saturation
$Define: FLAG_SATURATION
$AlwaysOn: false
$Default: 1.0
$Div: 100
$Add: 0

$Name: contrast
$Uniform: contrast
$Define: FLAG_CONTRAST
$AlwaysOn: false
$Default: 1.0
$Div: 500
$Add: 1

$Name: film grain
$Uniform: film_grain
$Define: FLAG_GRAIN
$AlwaysOn: false
$Default: 0.0
$Div: 100
$Add: 0

$Name: stripes
$Uniform: tv_stripes
$Define: FLAG_STRIPES
$AlwaysOn: false
$Default: 0.0
$Div: 100
$Add: 0

$Name: dithering
$Uniform: dither
$Define: FLAG_DITH
$AlwaysOn: false
$Default: 0.0
$Div: 100
$Add: 0

#End
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns

 

Offline MatthTheGeek

  • Captain Obvious
  • 212
  • Frenchie McFrenchface
I wasn't even aware there was one in mvps12, but everything's set to false anyway so that's just like no table.
People are stupid, therefore anything popular is at best suspicious.

Mod management tools     -     Wiki stuff!     -     Help us help you

666maslo666: Releasing a finished product is not a good thing! It is a modern fad.

SpardaSon21: it seems like you exist in a permanent state of half-joking misanthropy

Axem: when you put it like that, i sound like an insane person

bigchunk1: it's not retarded it's american!
bigchunk1: ...

batwota: steele's maneuvering for the coup de gras
MatthTheGeek: you mispelled grâce
Awaesaar: grace
batwota: oh right :P
Darius: ah!
Darius: yes, i like that
MatthTheGeek: the way you just spelled it it means fat
Awaesaar: +accent I forgot how to keyboard
MatthTheGeek: or grease
Darius: the killing fat!
Axem: jabba does the coup de gras
MatthTheGeek: XD
Axem: bring me solo and a cookie