[SirKnightly]

Here is the nightly for OS X on 11 Aug 2011 - Revision 7458

Group: Inferno
fso-OSX-Inferno-20110811_r7458.tgz
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r7436 | IssMneur | 2011-08-08 23:37:59 -0500 (Mon, 08 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/cmdline/cmdline.cpp

From jg18: various polish details and a description clarification, based from descriptions within sandmanjack's launcher
------------------------------------------------------------------------
r7439 | Echelon9 | 2011-08-10 08:40:53 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp

PVS-Studio fix: Correct duplicate attempt to set the docker_aip->support_ship_signature in ai_do_objects_undocked_stuff()
------------------------------------------------------------------------
r7440 | Echelon9 | 2011-08-10 08:43:18 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp

PVS-Studio fix: Remove duplicate if...then conditional within ai_process()
------------------------------------------------------------------------
r7441 | Echelon9 | 2011-08-10 08:45:14 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/fs2netd/fs2netd_client.cpp

PVS-Studio fix: Remove duplicate if...then conditional within fs2netd_get_pilot_info()
------------------------------------------------------------------------
r7442 | Echelon9 | 2011-08-10 08:47:06 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hudlock.cpp

PVS-studio fix: Ensure that both x and y of Player->current_target are reset correctly in hud_lock_determine_lock_point()
------------------------------------------------------------------------
r7443 | Echelon9 | 2011-08-10 08:49:42 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/missionui/missiondebrief.cpp

PVS-Studio fix: No need to set Current_stage variable again immediately after first assignment to a different hard coded value
------------------------------------------------------------------------
r7444 | Echelon9 | 2011-08-10 08:51:31 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multimsgs.cpp

PVS-Studio fix: No need to set sinfo variable again immediately after first assignment to a different value in send_secondary_fired_packet()
------------------------------------------------------------------------
r7445 | Echelon9 | 2011-08-10 08:55:33 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multiui.cpp

PVS-Studio fix: Incorrect logic within ping time colour indicator in multi_join_display_games() was overrepresenting yellow at the expense of red. Also replaced magic number with a definition.
------------------------------------------------------------------------
r7446 | Echelon9 | 2011-08-10 08:58:25 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/menuui/playermenu.cpp

PVS-Studio fix: This if...then...else block was redundant in player_select_init(), as each 'then' block did the same thing
------------------------------------------------------------------------
r7447 | Echelon9 | 2011-08-10 09:01:15 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hud.cpp

PVS-Studio fix: This if...then...else block was redundant in HudGaugeSupport::render(), as each 'then' block did the same thing
------------------------------------------------------------------------
r7450 | Zacam | 2011-08-10 09:23:51 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/freespace2/freespace.cpp

Logging update: Major/Minor/Build update so that "Build" will always be available/log correctly even when "0" (ex: 3.7.0) without also needing "Revision" present.
------------------------------------------------------------------------
r7451 | Echelon9 | 2011-08-10 11:11:29 -0500 (Wed, 10 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

PVS-Studio fix: XYZ co-ordinated were not correctly copied and pasted in parse_ship_values()
------------------------------------------------------------------------
r7452 | Echelon9 | 2011-08-11 09:15:05 -0500 (Thu, 11 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/camera/camera.cpp

PVS-Studio fix: Expression 'idx < 0' is always false. Unsigned type value is never < 0.
------------------------------------------------------------------------
r7453 | Echelon9 | 2011-08-11 09:18:26 -0500 (Thu, 11 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/lua.cpp

PVS-Studio fix: Expression 'i >= 0' is always true. Unsigned type value is always >= 0.
------------------------------------------------------------------------
r7454 | Echelon9 | 2011-08-11 09:35:03 -0500 (Thu, 11 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missionmessage.cpp

PVS-Studio fix: Fix r5260 - A call of the 'memset' function will lead to underflow of the buffer 'Valid_builtin_message_types'.
------------------------------------------------------------------------
r7455 | Echelon9 | 2011-08-11 09:53:11 -0500 (Thu, 11 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multi_options.cpp
   M /trunk/fs2_open/code/network/multi_pxo.cpp

PVS-Studio: A call of the 'memset' function will lead to underflow of various buffers in multi code.
------------------------------------------------------------------------
r7456 | Echelon9 | 2011-08-11 09:56:43 -0500 (Thu, 11 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multimsgs.cpp

PVS-Studio: The '&' operator is applied to bool type value. You've probably forgotten to include parentheses or intended to use the '&&' operator. In process_event_update_packet()
------------------------------------------------------------------------
r7457 | Echelon9 | 2011-08-11 09:59:16 -0500 (Thu, 11 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ui/slider2.cpp

PVS-Studio fix: The '&' operator is applied to bool type value. You've probably forgotten to include parentheses or intended to use the '&&' operator. In UI_SLIDER2::draw()
------------------------------------------------------------------------
r7458 | Echelon9 | 2011-08-11 10:31:44 -0500 (Thu, 11 Aug 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hud.cpp

PVS-Studio fix: A call of the 'memset' function will lead to underflow of the buffer 'txt'. In HudGaugeMultiMsg::render()
------------------------------------------------------------------------