[SirKnightly]

Here is the nightly for OS X on 07 Sep 2011 - Revision 7674

Group: Inferno
fso-OSX-Inferno-20110907_r7674.tgz
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r7612 | Valathil | 2011-09-01 11:16:03 -0500 (Thu, 01 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/graphics/gropengl.cpp
   M /trunk/fs2_open/code/graphics/gropengltexture.cpp
   M /trunk/fs2_open/code/parse/lua.cpp

Enable alpha channel on render to texture targets and provide scripting functions with alpha capabilities
------------------------------------------------------------------------
r7613 | Valathil | 2011-09-01 14:35:17 -0500 (Thu, 01 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/freespace2/freespace.cpp
   M /trunk/fs2_open/code/starfield/starfield.cpp

Changed Sun glow and lens flare rendering to not be obscured by objects
------------------------------------------------------------------------
r7614 | Goober5000 | 2011-09-02 20:05:00 -0500 (Fri, 02 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/cfile/cfilesystem.cpp
   M /trunk/fs2_open/code/mission/missionparse.cpp

PVS-Studio fix: V805 Decreased performance. It is inefficient to identify an empty string by using 'strlen(str) != 0' construct. A more efficient way is to check: str[0] != '\0'.
(and sorry Kazan, you don't get to call your for statement a work of art if you use strlen inefficiently)
------------------------------------------------------------------------
r7615 | Goober5000 | 2011-09-02 20:15:20 -0500 (Fri, 02 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/cfile/cfilesystem.cpp

PVS-Studio fix: V804 Decreased performance. The 'strlen' function is called twice in the specified expression to calculate length of the same string.
------------------------------------------------------------------------
r7616 | Goober5000 | 2011-09-02 20:32:07 -0500 (Fri, 02 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/cmdline/cmdline.cpp
   M /trunk/fs2_open/code/mission/missioncampaign.cpp
   M /trunk/fs2_open/code/network/multi_pxo.cpp
   M /trunk/fs2_open/code/weapon/weapons.cpp

PVS-Studio fix: V804 Decreased performance. The 'strlen' function is called twice in the specified expression to calculate length of the same string.
------------------------------------------------------------------------
r7617 | Goober5000 | 2011-09-02 20:45:56 -0500 (Fri, 02 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/asteroid/asteroid.cpp

PVS-Studio fix: V506 Pointer to local variable 'terminus' is stored outside the scope of this variable. Such a pointer will become invalid.
------------------------------------------------------------------------
r7618 | Goober5000 | 2011-09-02 20:48:06 -0500 (Fri, 02 Sep 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/mission/missioncampaign.cpp

PVS-Studio fix: V507 Pointer to local array 'name' is stored outside the scope of this array. Such a pointer will become invalid. code missioncampaign.cpp

(This is a Volition bug!  In all other locations, Campaign_file_names and Campaign_names are set using strdup.)
------------------------------------------------------------------------
r7619 | Goober5000 | 2011-09-02 21:21:20 -0500 (Fri, 02 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/missionui/missionweaponchoice.cpp

wl_fury_missile_offset_hack was only applicable for FS1
------------------------------------------------------------------------
r7620 | Goober5000 | 2011-09-02 21:25:39 -0500 (Fri, 02 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp
   M /trunk/fs2_open/code/globalincs/pstypes.h
   M /trunk/fs2_open/code/graphics/gropengl.cpp
   M /trunk/fs2_open/code/hud/hudtarget.cpp
   M /trunk/fs2_open/code/model/modelinterp.cpp
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/weapon/beam.cpp

a bunch of small PVS-Studio fixes (mostly duplicate assignments)
------------------------------------------------------------------------
r7621 | Goober5000 | 2011-09-02 21:34:14 -0500 (Fri, 02 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/fred2/missionsave.cpp

The_E made the wrong fix; this is the right one
------------------------------------------------------------------------
r7622 | Goober5000 | 2011-09-02 23:30:23 -0500 (Fri, 02 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

whoops
------------------------------------------------------------------------
r7623 | Echelon9 | 2011-09-03 00:20:27 -0500 (Sat, 03 Sep 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp

PVS-Studio fix: V592 The expression was enclosed by parentheses twice: '((cur_sep > 0.9f * desired_sep))'. One pair of parentheses is unnecessary or misprint is present (aicode.cpp).

I think this is the right fix. In addition the code comments did not reflect what was happening, so I've updated these to reflect the if() comparison.
------------------------------------------------------------------------
r7624 | Echelon9 | 2011-09-03 00:31:12 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/starfield/starfield.cpp

PVS-Studio fix: V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present (starfield.cpp).
------------------------------------------------------------------------
r7625 | Echelon9 | 2011-09-03 00:34:08 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/gamesnd/eventmusic.cpp

Suppress a PVS-Studio false positive
------------------------------------------------------------------------
r7626 | Echelon9 | 2011-09-03 00:38:28 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/menuui/optionsmenu.cpp

PVS-Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 1281, 1312.
------------------------------------------------------------------------
r7627 | Echelon9 | 2011-09-03 03:25:53 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missionbriefcommon.cpp
   M /trunk/fs2_open/code/parse/sexp.cpp

Documentation: A few documentation fixes so that Doxygen 1.7.5.1 outputs a clean log
------------------------------------------------------------------------
r7628 | Echelon9 | 2011-09-03 04:06:00 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/freespace2/freespace.cpp
   M /trunk/fs2_open/code/hud/hudconfig.cpp
   M /trunk/fs2_open/code/hud/hudshield.cpp
   M /trunk/fs2_open/code/hud/hudshield.h
   M /trunk/fs2_open/code/menuui/readyroom.cpp
   M /trunk/fs2_open/code/missionui/missionpause.cpp
   M /trunk/fs2_open/code/missionui/redalert.cpp
   M /trunk/fs2_open/code/model/model.h
   M /trunk/fs2_open/code/model/modelinterp.cpp
   M /trunk/fs2_open/code/model/modelread.cpp
   M /trunk/fs2_open/code/network/multi_respawn.cpp
   M /trunk/fs2_open/code/network/multimsgs.cpp
   M /trunk/fs2_open/code/network/multiteamselect.cpp
   M /trunk/fs2_open/code/network/multiui.cpp
   M /trunk/fs2_open/code/stats/medals.cpp

Documentation: A few documentation fixes
------------------------------------------------------------------------
r7629 | Valathil | 2011-09-03 11:17:19 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/graphics/gropengldraw.cpp

Fix tcache_set() OpenGL Errors by not using vertex attributes when drawing distortion Thrusters
------------------------------------------------------------------------
r7630 | Goober5000 | 2011-09-03 16:46:49 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

d'oh... in most cases, atoi(CTEXT(n)) should be eval_num(n)
------------------------------------------------------------------------
r7631 | Goober5000 | 2011-09-03 19:41:05 -0500 (Sat, 03 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp

fix a bug from the waypoint conversion
------------------------------------------------------------------------
r7632 | Goober5000 | 2011-09-04 00:43:42 -0500 (Sun, 04 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/weapon/beam.cpp

remove unneeded Assert
------------------------------------------------------------------------
r7633 | Swifty | 2011-09-04 01:54:09 -0500 (Sun, 04 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelinterp.cpp

Thrusters render in the proper position when drawing an auto centered model.
------------------------------------------------------------------------
r7634 | The_E | 2011-09-04 03:19:21 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/graphics/grbatch.cpp

Change batch_render_* to use iterators

------------------------------------------------------------------------
r7635 | The_E | 2011-09-04 04:31:30 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/hud/hudtargetbox.cpp

PVS Studio fix: V510, class type argument passed to sprintf

------------------------------------------------------------------------
r7636 | The_E | 2011-09-04 04:35:08 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/network/multi_obj.cpp

PVS Studio related: Mark false alarms as such

------------------------------------------------------------------------
r7637 | The_E | 2011-09-04 05:14:17 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fs2netd/fs2netd_client.cpp

PVS Studio related: Mark false alarms as such

------------------------------------------------------------------------
r7638 | The_E | 2011-09-04 07:13:31 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/hud/hudconfig.cpp

More false alarms from PVS Studio

------------------------------------------------------------------------
r7639 | The_E | 2011-09-04 07:14:35 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/sexp_tree.cpp
   M /trunk/fs2_open/code/freespace2/freespace.cpp

PVS Studio fix: V803 Decreased performance. In case 'obji' is iterator it's more effective to use prefix form of increment. Replace iterator++ with ++iterator.

------------------------------------------------------------------------
r7640 | The_E | 2011-09-04 07:31:33 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/cfile/cfilesystem.cpp
   M /trunk/fs2_open/code/fred2/addvariabledlg.cpp
   M /trunk/fs2_open/code/fred2/bgbitmapdlg.cpp
   M /trunk/fs2_open/code/fred2/dumpstats.cpp
   M /trunk/fs2_open/code/fred2/folderdlg.cpp
   M /trunk/fs2_open/code/fred2/fredview.cpp
   M /trunk/fs2_open/code/fred2/initialships.cpp
   M /trunk/fs2_open/code/fred2/initialstatus.cpp
   M /trunk/fs2_open/code/fred2/management.cpp
   M /trunk/fs2_open/code/fred2/missionnotesdlg.cpp
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/freespace2/freespace.cpp
   M /trunk/fs2_open/code/mission/missioncampaign.cpp
   M /trunk/fs2_open/code/missionui/redalert.cpp
   M /trunk/fs2_open/code/parse/parselo.cpp
   M /trunk/fs2_open/code/sound/ds.cpp

Marking a bunch of PVS Studio warnings as false alarms. While the warnings are technically correct, none of these are in places where performance matters.

------------------------------------------------------------------------
r7641 | The_E | 2011-09-04 07:33:00 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/network/multi_obj.cpp

Another false alarm from PVS Studio

------------------------------------------------------------------------
r7642 | The_E | 2011-09-04 07:35:14 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/fred2/sexp_tree.cpp

PVS Studio fix: Variable "item_index" was assigned values twice in succession

------------------------------------------------------------------------
r7643 | The_E | 2011-09-04 07:36:33 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/controlconfig/controlsconfig.cpp

PVS Studio fix: V535 The variable 'j' is being used for this loop and for the outer loop.

------------------------------------------------------------------------
r7644 | Echelon9 | 2011-09-04 10:30:34 -0500 (Sun, 04 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/controlconfig/controlsconfig.cpp

PVS-Studio fix: Mark a false positive reported by niffiwan
------------------------------------------------------------------------
r7645 | Valathil | 2011-09-04 10:48:05 -0500 (Sun, 04 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/freespace2/freespace.cpp
   M /trunk/fs2_open/code/ship/shipfx.cpp

Implemented Sun occlusion for Cockpit models and shown Ship models
------------------------------------------------------------------------
r7646 | The_E | 2011-09-04 14:33:09 -0500 (Sun, 04 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp
   M /trunk/fs2_open/code/ship/shiphit.cpp

A bit of cleanup here. Removed unnecessary "if (true)" and changed the sexp code to use the already written armor_type_get_idx function

------------------------------------------------------------------------
r7647 | Valathil | 2011-09-04 15:01:34 -0500 (Sun, 04 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/shipfx.cpp

Fixed a little misunderstanding of the collision query framework in the sun occlusion test
------------------------------------------------------------------------
r7648 | karajorma | 2011-09-04 19:05:20 -0500 (Sun, 04 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/mission/missionparse.cpp
   M /trunk/fs2_open/code/mission/missionparse.h

Fix the cloaked ship flag not saving.
------------------------------------------------------------------------
r7649 | Echelon9 | 2011-09-05 07:47:12 -0500 (Mon, 05 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

PVS-Studio fix (courtesy of niffiwan): This is a false positive, BUT IT REALLY SHOULD be rewritten with an STL container
------------------------------------------------------------------------
r7650 | Echelon9 | 2011-09-05 07:49:37 -0500 (Mon, 05 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/multimsgs.cpp

PVS-Studio fix (courtesy of niffiwan): V568It's odd that the argument of sizeof() operator is the '(short) method' expression.
------------------------------------------------------------------------
r7651 | Echelon9 | 2011-09-05 09:30:34 -0500 (Mon, 05 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

Documentation: Major code cleanup of ship.cpp
------------------------------------------------------------------------
r7652 | Goober5000 | 2011-09-05 14:50:26 -0500 (Mon, 05 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

remove unreferenced variable
------------------------------------------------------------------------
r7653 | karajorma | 2011-09-05 21:29:47 -0500 (Mon, 05 Sep 2011) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

Fix Mantis 2492 (Confusing help messages for the get-x-ammo SEXPs)

------------------------------------------------------------------------
r7654 | Goober5000 | 2011-09-06 03:59:29 -0500 (Tue, 06 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/hud/hudbrackets.cpp
   M /trunk/fs2_open/code/hud/hudtargetbox.cpp

end string at hash symbol for jump nodes too
------------------------------------------------------------------------
r7655 | Echelon9 | 2011-09-06 07:29:56 -0500 (Tue, 06 Sep 2011) | 3 lines
Changed paths:
   M /trunk/fs2_open/code/network/multi_xfer.cpp
   M /trunk/fs2_open/code/network/multi_xfer.h

PVS-Studio fix: V524 It is odd that the body of 'multi_xfer_reset' function is fully equivalent to the body of 'multi_xfer_close' function (multi_xfer.cpp, line 185).

Remove duplicate, unused function
------------------------------------------------------------------------
r7656 | Echelon9 | 2011-09-06 09:39:53 -0500 (Tue, 06 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/shield.cpp

Documentation: Major code clean up of shield.cpp
------------------------------------------------------------------------
r7657 | Valathil | 2011-09-06 12:17:58 -0500 (Tue, 06 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/model.h
   M /trunk/fs2_open/code/model/modelinterp.cpp

Delay transparent texture rendering to fix z-buffer ordering issues
------------------------------------------------------------------------
r7660 | karajorma | 2011-09-06 21:50:05 -0500 (Tue, 06 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/fred2/fred.rc

Fix Mantis 2497 (SEXP help text not available in the ships editor)
------------------------------------------------------------------------
r7664 | Zacam | 2011-09-07 04:57:37 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/graphics/gropengldraw.cpp

MSVC Analysis: Local declaration of <variable> hides previous declaration at <line> of <file>: 'Scene_texture_width'/'Scene_texture_height' in gropengldraw lines 56 & 57.
------------------------------------------------------------------------
r7665 | Zacam | 2011-09-07 05:00:03 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/psnet2.cpp

PVS-Studio fix (courtesy of niffiwan): V512 - A call of the 'memcpy' function will lead to overflow of the buffer '& ip_addr.sin_addr'.
------------------------------------------------------------------------
r7667 | Echelon9 | 2011-09-07 06:58:47 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/psnet2.cpp

PVS-Studio fix (courtesy of niffiwan): V512 A call of the 'memcpy' function will lead to underflow of the buffer (psnet2.cpp)
------------------------------------------------------------------------
r7668 | Echelon9 | 2011-09-07 07:00:21 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/anim/packunpack.cpp

PVS-Studio fix (courtesy of niffiwan): V512 A call of the 'memcpy' function will lead to underflow of the buffer '& bit_24'.
------------------------------------------------------------------------
r7669 | Echelon9 | 2011-09-07 07:28:18 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/network/psnet2.cpp

Documentation: Code clean up of psnet2.cpp
------------------------------------------------------------------------
r7670 | Echelon9 | 2011-09-07 07:46:35 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/inetfile/cftp.cpp

PVS-Studio fix: V512 A call of the 'memcpy' function will lead to underflow of the buffer 'szcode'.
------------------------------------------------------------------------
r7671 | Echelon9 | 2011-09-07 09:10:41 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/graphics/2d.cpp
   M /trunk/fs2_open/code/graphics/2d.h
   M /trunk/fs2_open/code/render/3d.h

Documentation: Code cleanup to 2d.cpp, 2d.h and 3d.h
------------------------------------------------------------------------
r7672 | Echelon9 | 2011-09-07 09:22:03 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/render/3ddraw.cpp

Documentation: Code cleanup of 3ddraw.cpp
------------------------------------------------------------------------
r7673 | Echelon9 | 2011-09-07 09:26:25 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/render/3dlaser.cpp

Documentation: Code clean up in 3dlaser.cpp
------------------------------------------------------------------------
r7674 | Echelon9 | 2011-09-07 09:33:26 -0500 (Wed, 07 Sep 2011) | 1 line
Changed paths:
   M /trunk/fs2_open/code/render/3dmath.cpp
   M /trunk/fs2_open/code/render/3dsetup.cpp

Documentation: Complete code clean up of the 3d/2d code
------------------------------------------------------------------------