[Kopachris]

Just wanted to flag the fact that the sidebar is still misplaced (Chrome, Windows 7).

Yep. I honestly have no clue why. I can't quite figure out the odd CSS that MediaWiki uses. At this point, I'd say we should upgrade to the latest release and see what that does.

Dunno how it'll affect other browsers, but removing

Code: [Select]

#column-content{ margin-left:0; }
from KHTMLFixes.css seems to fix the sidebar on Chrome.  Sounds like that's there to fix a layout issue with Konquerer, though.  The .css file is imported in http://www.hard-light.net/wiki/skins/common/wikibits.js at

Code: [Select]

var is_khtml=navigator.vendor=='KDE'||(document.childNodes&&!document.all&&!navigator.taintEnabled);
and

Code: [Select]

else if(is_khtml){importStylesheetURI(stylepath+'/'+skin+'/KHTMLFixes.css');}

So I guess the javascript thinks Chrome is Konqueror because it doesn't support document.all (IE only) or navigator.taintEnabled (IE and Opera only) and doesn't match any other browser.  It's quite possible a later release of MediaWiki will fix this.




EDIT: Upon further research, looks like I'm right.  Updating to at least MediaWiki 1.16 should solve the issue:

According to http://www.mediawiki.org/wiki/Release_notes/1.16#Bug_fixes_in_1.16

Remove five-year-old KHTMLFixes.css, which is unlikely to be relevant anymore and was causing problems.

And https://code.google.com/p/chromium/issues/detail?id=19586

This was fixed in MediaWiki 1.16, which has not yet been released and has no planned release date right now [as of Nov 18, 2009]. 
However, basically every MediaWiki installation on the web will suffer from the bug.  Specifically, any using a
version of MediaWiki released since 2004, if they use the default skin.  And MW is very hard to skin, so the large
majority of sites use the default skin, or only slightly modified.  That's countless thousands of small sites, and
some relatively high-profile ones like <http://wikileaks.org>.  Trying to convince all of them to blank
KHTMLFixes.css isn't going to work.

[Sandwich]

Ooh, good catch, thanks! I missed that line when I was debugging the problem. I *think* I've fixed the problem, but it seems like there's server caching going on that I don't know how to override or force to refresh from disk. So whenever that happens, the problem should be fixed.

[Kopachris]

Ooh, good catch, thanks! I missed that line when I was debugging the problem. I *think* I've fixed the problem, but it seems like there's server caching going on that I don't know how to override or force to refresh from disk. So whenever that happens, the problem should be fixed.

Cool, thanks!  I'll keep an eye on it.

[niffiwan]

I'm sure upgrading to a newer version of mediawiki (1.22.x) would still be a good idea, get the latest security fixes and all that

[Sandwich]

I completely concur.

[Kopachris]

Confirmed div#column-content no longer using margin: 0; with a fresh install of Chrome on Windows 8.1 or Android 4.4 (actually CM 11).  However, opening the stylesheet alone indicates no change, so maybe it's just this version of Chrome and the chached file is still being used (I didn't have Chrome on my desktop at home before now, and previous report was from Chrome on desktop at work, unknown version).  Did you make the change in KHTMLFixes.css or another stylesheet?

[Sandwich]

I commented out the "#column-content{ margin-left:0; }" line in KHTMLFixes.css entirely. I suspect CloudFlare's caching stuff is delaying the fix.

[Kopachris]

I commented out the "#column-content{ margin-left:0; }" line in KHTMLFixes.css entirely. I suspect CloudFlare's caching stuff is delaying the fix.

Yup.  Back on my work computer.  Still cached, so sidebar still misplaced.  If you have access to HLP's cloudflare settings, you can purge an individual file from the cache: https://support.cloudflare.com/hc/en-us/articles/200169386-How-do-I-purge-a-single-file-from-cache-

If not, don't worry about it.  A misplaced sidebar isn't really a big deal.

[niffiwan]

I'm sure upgrading to a newer version of mediawiki (1.22.x) would still be a good idea, get the latest security fixes and all that

I completely concur.

I'm happy to do this for HLP, starting around the 14th April as I'll be away next week.

And based on these links it would seem that there could be approximately 46 vulnerabilities¹ of various impacts in the currently running version (assuming that the reported version of 1.15 is correct)

http://en.wikipedia.org/wiki/MediaWiki_version_history
http://www.cvedetails.com/vendor/2360/Mediawiki.html

¹ of course, not all those 46 may be relevant to the current setup, but I don't have time for a detailed analysis of all the issues right now

[rev_posix]

And based on these links it would seem that there could be approximately 46 vulnerabilities¹ of various impacts in the currently running version (assuming that the reported version of 1.15 is correct)

http://en.wikipedia.org/wiki/MediaWiki_version_history
http://www.cvedetails.com/vendor/2360/Mediawiki.html

¹ of course, not all those 46 may be relevant to the current setup, but I don't have time for a detailed analysis of all the issues right now

Yep.  Ubuntu and Debian do backport security fixes into earlier supported versions of their packages, so one can't rely solely on the bug list from the upstream software.

That's not to say that what is installed now shouldn't be updated, but there are other, 'issues', that have to be considered beyond a simple "It's out of date?  Ok, apt-get update away!"...

[Fury]

Huh? Unless it's been changed since my time as an admin, MediaWiki (or any of the other web applications) was never installed from distro repositories.

[rev_posix]

Huh? Unless it's been changed since my time as an admin, MediaWiki (or any of the other web applications) was never installed from distro repositories.

You are correct on that, I just checked.

I was under the impression that mediawiki was a package installed via apt-get, but I stand corrected.  This does make the update path a bit easier, but would require changing any custom templates that might be in use, if any (I'm running into this at work).

Will have to look at finding time to set up a test bed and see if the current data can be updated without problem.

[Sandwich]

So is it just me, or did this fix finally take?

Also, if it's not just me, and you know that the sidebar was still misplaced as recently as the last few days or weeks, please let me know.

[Shivan Hunter]

Works for me now on firefox and chrome (it wasn't working on my end before).

[Lepanto]

It works! Woohoo. 

[mjn.mixael]

well, would you look at that. I had assumed it would be broken indefinitely.

[headdie]

looking good on chrome