Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Cross-Platform Development => Topic started by: Armchair Commander on March 03, 2010, 03:30:33 pm

Title: had trouble compiling svn on arch linux - using workaround
Post by: Armchair Commander on March 03, 2010, 03:30:33 pm
I was having some trouble compiling from source after switching to Arch Linux (recently fetched from svn) and thought I'd post the solution for anyone else who might have trouble with it.

Currently using Arch Linux x86-64 with Kernel 2.6.32-ARCH  (2.6.32-9 I think), sdl 1.2.14-1, openal 1.10.622-1, libvorbis 1.2.3-1, libtheora 1.1.1-1, readline 6.1.001-1, gcc 4.4.3-1, automake 1.11.1-1, autoconf 2.65-1.

Compiling kept giving me “pngutils/pngutils.cpp:194: error: ‘png_infopp_NULL’ was not declared in this scope.”  After some investigating, I found some helpful notes from a fellow Arch user in our AUR directory for an outdated fs_open package.  Following his/her instructions, I edited the file /src/fs2_open/code/pngutils/pngutils.cpp, replacing all instances of 'png_voidp_NULL' and 'png_infopp_NULL' with 'NULL.' 

After making the changes, compiling went fine for standard and inferno binaries and I could play the game without issues.  I'm not sure of the exact build but I updated svn and compiled on March 1st, 2010.  The line at the bottom of the in-game screen says “Freespace 2 Open v3.6.13 Inferno OpenGL.”

Dunno if this helps or not but thought I'd post it.  Thanks for all your hard work.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on March 03, 2010, 03:43:48 pm
FYI, you can get the build version with 'svnversion <checkout_directory>', or if in the directory, just run svnversion.

Also, can you list your version of libpng?  It seems to be the only one you missed, oddly enough.

To clarify, we've only tested this against libpng 1.2.x but ArchLinux seems to have 1.4.0 in its stable already, so we can't guarantee that it will work.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Armchair Commander on March 03, 2010, 04:08:01 pm
libpng 1.4.0-2 and build version 5968.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on March 03, 2010, 05:08:51 pm
Figured as much, thanks.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Zacam on March 05, 2010, 12:57:09 am
And the PNG test package from Antipodes 5 works in this build?
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: marvn on March 14, 2010, 10:20:53 am
And the PNG test package from Antipodes 5 works in this build?
hi, im also on arch with libpng 1.4, but with old kernel (2.6.31.13) - this imo doesn't make any difference here anyway
i've just tried the patch from antipodes (5825-PNG-Full.patch) with sources from svn (6005)
i'm not exactly clear about how patch works, so i just used '  patch -Np0 -i 5825-PNG-Full.patch' and some patches faild
log>
Code: [Select]
patching file configure.ac
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file configure.ac.rej
patching file code/Makefile.am
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file code/Makefile.am.rej
patching file code/bmpman/bm_internal.h
Reversed (or previously applied) patch detected!  Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file code/bmpman/bm_internal.h.rej
patching file code/bmpman/bmpman.cpp
Reversed (or previously applied) patch detected!  Skipping patch.
5 out of 5 hunks ignored -- saving rejects to file code/bmpman/bmpman.cpp.rej
patching file code/cfile/cfile.cpp
Reversed (or previously applied) patch detected!  Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file code/cfile/cfile.cpp.rej
patching file code/graphics/gropenglbmpman.cpp
Reversed (or previously applied) patch detected!  Skipping patch.
5 out of 5 hunks ignored -- saving rejects to file code/graphics/gropenglbmpman.cpp.rej
patching file code/graphics/grstub.cpp
Reversed (or previously applied) patch detected!  Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file code/graphics/grstub.cpp.rej
patching file code/nebula/neb.cpp
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file code/nebula/neb.cpp.rej
patching file code/pngutils/pngutils.cpp
patching file code/pngutils/pngutils.h
patching file libpng/png.c
patching file libpng/png.h
patching file libpng/pngconf.h
patching file libpng/pngerror.c
patching file libpng/pnggccrd.c
patching file libpng/pngget.c
patching file libpng/pngmem.c
patching file libpng/pngpread.c
patching file libpng/pngread.c
patching file libpng/pngrio.c
patching file libpng/pngrtran.c
patching file libpng/pngrutil.c
patching file libpng/pngset.c
patching file libpng/pngtest.c
patching file libpng/pngtrans.c
patching file libpng/pngvcrd.c
patching file libpng/pngwio.c
patching file libpng/pngwrite.c
patching file libpng/pngwtran.c
patching file libpng/pngwutil.c
patching file libpng/scripts/pngw32.rc
can't find file to patch at input line 28859
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: projects/MSVC_6_Release/code.dsp
|===================================================================
|--- projects/MSVC_6_Release/code.dsp   (revision 5825)
|+++ projects/MSVC_6_Release/code.dsp   (working copy)
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
5 out of 5 hunks ignored
can't find file to patch at input line 28921
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: projects/MSVC_6_Release/Fred2.dsp
|===================================================================
|--- projects/MSVC_6_Release/Fred2.dsp  (revision 5825)
|+++ projects/MSVC_6_Release/Fred2.dsp  (working copy)
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
4 out of 4 hunks ignored
can't find file to patch at input line 28967
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: projects/MSVC_6_Release/Freespace2.dsp
|===================================================================
|--- projects/MSVC_6_Release/Freespace2.dsp     (revision 5825)
|+++ projects/MSVC_6_Release/Freespace2.dsp     (working copy)
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
4 out of 4 hunks ignored
patching file projects/MSVC_2008/code.vcproj
Hunk #1 FAILED at 41.
Hunk #2 FAILED at 123.
Hunk #3 FAILED at 205.
Hunk #4 FAILED at 289.
Hunk #5 FAILED at 373.
Hunk #6 FAILED at 457.
Hunk #7 FAILED at 548.
Hunk #8 FAILED at 634.
Hunk #9 FAILED at 720.
Hunk #10 FAILED at 807.
Hunk #11 FAILED at 894.
Hunk #12 FAILED at 981.
Hunk #13 FAILED at 3504.
13 out of 13 hunks FAILED -- saving rejects to file projects/MSVC_2008/code.vcproj.rej
patching file projects/MSVC_2008/Fred2.vcproj
Hunk #1 FAILED at 52.
Hunk #2 FAILED at 158.
Hunk #3 FAILED at 264.
Hunk #4 FAILED at 372.
Hunk #5 FAILED at 480.
Hunk #6 FAILED at 588.
Hunk #7 FAILED at 703.
Hunk #8 FAILED at 816.
Hunk #9 FAILED at 929.
Hunk #10 FAILED at 1043.
Hunk #11 FAILED at 1157.
Hunk #12 FAILED at 1271.
12 out of 12 hunks FAILED -- saving rejects to file projects/MSVC_2008/Fred2.vcproj.rej
patching file projects/MSVC_2008/Freespace2.sln
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 18.
Hunk #3 FAILED at 161.
3 out of 3 hunks FAILED -- saving rejects to file projects/MSVC_2008/Freespace2.sln.rej
patching file projects/MSVC_2008/Freespace2.vcproj
Hunk #1 FAILED at 51.
Hunk #2 FAILED at 163.
Hunk #3 FAILED at 274.
Hunk #4 FAILED at 387.
Hunk #5 FAILED at 500.
Hunk #6 FAILED at 613.
Hunk #7 FAILED at 732.
Hunk #8 FAILED at 848.
Hunk #9 FAILED at 964.
Hunk #10 FAILED at 1081.
Hunk #11 FAILED at 1198.
Hunk #12 FAILED at 1314.
12 out of 12 hunks FAILED -- saving rejects to file projects/MSVC_2008/Freespace2.vcproj.rej
patching file projects/MSVC_2008/libpng.vcproj
patching file projects/MSVC_2008/zlib.vcproj
patching file projects/Xcode/FS2_Open.xcodeproj/project.pbxproj
Hunk #1 FAILED at 677.
Hunk #2 succeeded at 823 (offset 79 lines).
Hunk #3 succeeded at 893 with fuzz 2 (offset 93 lines).
Hunk #4 succeeded at 1720 (offset 142 lines).
Hunk #5 FAILED at 1653.
Hunk #6 succeeded at 1867 (offset 158 lines).
Hunk #7 FAILED at 1766.
Hunk #8 FAILED at 1787.
Hunk #9 FAILED at 1942.
Hunk #10 succeeded at 3427 with fuzz 1 (offset 249 lines).
Hunk #11 FAILED at 3562.
Hunk #12 succeeded at 3863 (offset 277 lines).
Hunk #13 FAILED at 3653.
Hunk #14 succeeded at 4079 with fuzz 2 (offset 317 lines).
Hunk #15 FAILED at 3816.
Hunk #16 FAILED at 4160.
Hunk #17 succeeded at 4613 (offset 364 lines).
Hunk #18 succeeded at 4687 with fuzz 2 (offset 374 lines).
Hunk #19 succeeded at 5979 (offset 532 lines).
Hunk #20 succeeded at 6255 (offset 554 lines).
9 out of 20 hunks FAILED -- saving rejects to file projects/Xcode/FS2_Open.xcodeproj/project.pbxproj.rej
patching file zlib/adler32.c
patching file zlib/compress.c
patching file zlib/crc32.c
patching file zlib/crc32.h
patching file zlib/deflate.c
patching file zlib/deflate.h
patching file zlib/example.c
patching file zlib/gzio.c
patching file zlib/infback.c
patching file zlib/inffast.c
patching file zlib/inffast.h
patching file zlib/inffixed.h
patching file zlib/inflate.c
patching file zlib/inflate.h
patching file zlib/inftrees.c
patching file zlib/inftrees.h
patching file zlib/minigzip.c
patching file zlib/trees.c
patching file zlib/trees.h
patching file zlib/uncompr.c
patching file zlib/win32/zlib1.rc
patching file zlib/zconf.h
patching file zlib/zconf.in.h
patching file zlib/zlib.h
patching file zlib/zutil.c
patching file zlib/zutil.h

but sadly, the make failed in the same place

Code: [Select]
pngutils/pngutils.cpp: In function ‘int png_read_header(char*, CFILE*, int*, int*, int*, ubyte*)’:
pngutils/pngutils.cpp:68: warning: deprecated conversion from string constant to ‘char*’
pngutils/pngutils.cpp:103: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:111: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:121: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:121: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:122: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:122: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:124: warning: ‘png_info_struct::pixel_depth’ is deprecated (declared at /usr/include/libpng14/png.h:660)
pngutils/pngutils.cpp:124: warning: ‘png_info_struct::pixel_depth’ is deprecated (declared at /usr/include/libpng14/png.h:660)
pngutils/pngutils.cpp:131: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp: In function ‘int png_read_bitmap(char*, ubyte*, ubyte*, int, int)’:
pngutils/pngutils.cpp:163: warning: deprecated conversion from string constant to ‘char*’
pngutils/pngutils.cpp:189: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:197: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:205: error: ‘png_voidp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:211: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:211: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:214: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:214: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:218: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp: At global scope:
pngutils/pngutils.cpp:235: error: redefinition of ‘CFILE* png_file’
pngutils/pngutils.cpp:13: error: ‘CFILE* png_file’ previously defined here
pngutils/pngutils.cpp: In function ‘void png_scp_read_data(png_struct*, png_byte*, png_size_t)’:
pngutils/pngutils.cpp:238: error: redefinition of ‘void png_scp_read_data(png_struct*, png_byte*, png_size_t)’
pngutils/pngutils.cpp:16: error: ‘void png_scp_read_data(png_struct*, png_byte*, png_size_t)’ previously defined here
pngutils/pngutils.cpp: In function ‘int png_read_header(char*, CFILE*, int*, int*, int*, ubyte*)’:
pngutils/pngutils.cpp:270: error: redefinition of ‘int png_read_header(char*, CFILE*, int*, int*, int*, ubyte*)’
pngutils/pngutils.cpp:48: error: ‘int png_read_header(char*, CFILE*, int*, int*, int*, ubyte*)’ previously defined here
pngutils/pngutils.cpp:290: warning: deprecated conversion from string constant to ‘char*’
pngutils/pngutils.cpp:325: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:333: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:343: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:343: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:344: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:344: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:346: warning: ‘png_info_struct::pixel_depth’ is deprecated (declared at /usr/include/libpng14/png.h:660)
pngutils/pngutils.cpp:346: warning: ‘png_info_struct::pixel_depth’ is deprecated (declared at /usr/include/libpng14/png.h:660)
pngutils/pngutils.cpp:353: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp: In function ‘int png_read_bitmap(char*, ubyte*, ubyte*, int, int)’:
pngutils/pngutils.cpp:365: error: redefinition of ‘int png_read_bitmap(char*, ubyte*, ubyte*, int, int)’
pngutils/pngutils.cpp:146: error: ‘int png_read_bitmap(char*, ubyte*, ubyte*, int, int)’ previously defined here
pngutils/pngutils.cpp:382: warning: deprecated conversion from string constant to ‘char*’
pngutils/pngutils.cpp:408: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:416: error: ‘png_infopp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:424: error: ‘png_voidp_NULL’ was not declared in this scope
pngutils/pngutils.cpp:430: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:430: warning: ‘png_info_struct::width’ is deprecated (declared at /usr/include/libpng14/png.h:633)
pngutils/pngutils.cpp:433: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:433: warning: ‘png_info_struct::height’ is deprecated (declared at /usr/include/libpng14/png.h:634)
pngutils/pngutils.cpp:437: error: ‘png_infopp_NULL’ was not declared in this scope
make[1]: *** [pngutils.o] Error 1
make[1]: *** Waiting for unfinished jobs....
parse/lua.cpp: At global scope:
parse/lua.cpp:1278: warning: ‘Lua_file_handle_instances’ defined but not used
parse/lua.cpp:1279: warning: ‘Lua_max_file_handle_instances’ defined but not used
mv -f .deps/lua.Tpo .deps/lua.Po
mv -f .deps/sexp.Tpo .deps/sexp.Po
make[1]: Leaving directory `/home/m/abs/fs2open-svn/src/fs2_open-build/code'
make: *** [all-recursive] Error 1
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Zacam on March 14, 2010, 12:54:08 pm
Not that. PNG Support as provided by that PATCH are already in Trunk. Hence why trying to patch it failed.

I meant what happens when using the above "fix" to compile a build, does it load and use the PNG files from the PNG Test package, direct link HERE: PNG-Test.7z (http://www.mediafire.com/file/lodmnorlwy2/PNG-Test.7z)
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: marvn on March 15, 2010, 08:34:11 pm
ok, i see
i tested it and the png test pkg works with the fixed build. although in barracks, there is a transparancy issue when cursor is above any button (it should highlight the button only, but it highlights the whole square around the button)

btw. i found discussion on arch-dev about libpng issue with wesnoth (it's similar to this one) and from there>
Code: [Select]
snip from changelog of 1.4 libpng
   b. We removed the typecasted NULL definitions such as

          #define png_voidp_NULL    (png_voidp)NULL

      If you used these in your application, just use NULL instead.

so maybe these replace is ok after all

btw2. here is the patch for png 1.4 compatibility

Code: [Select]
--- code/pngutils/pngutils.cpp~ 2010-03-15 20:23:46.000000000 +0100
+++ code/pngutils/pngutils.cpp  2010-03-16 00:42:26.000000000 +0100
@@ -100,7 +100,7 @@
  {
   mprintf(("png_read_header: error creating info struct\n"));
   cfclose(png_file);
-  png_destroy_read_struct(&png_ptr, png_infopp_NULL, png_infopp_NULL);
+  png_destroy_read_struct(&png_ptr, NULL, NULL);
   return PNG_ERROR_READING;
  }
 
@@ -108,7 +108,7 @@
  {
   mprintf(("png_read_header: something went wrong\n"));
   /* Free all of the memory associated with the png_ptr and info_ptr */
-  png_destroy_read_struct(&png_ptr, &info_ptr, png_infopp_NULL);
+  png_destroy_read_struct(&png_ptr, &info_ptr, NULL);
   cfclose(png_file);
   /* If we get here, we had a problem reading the file */
   return PNG_ERROR_READING;
@@ -128,7 +128,7 @@
   png_file = NULL;
  }
 
- png_destroy_read_struct(&png_ptr, &info_ptr, png_infopp_NULL);
+ png_destroy_read_struct(&png_ptr, &info_ptr, NULL);
 
  return PNG_ERROR_NONE;
 }
@@ -183,7 +183,7 @@
  {
   mprintf(("png_read_bitmap: info_ptr went wrong\n"));
   cfclose(png_file);
-  png_destroy_read_struct(&png_ptr, png_infopp_NULL, png_infopp_NULL);
+  png_destroy_read_struct(&png_ptr, NULL, NULL);
   return PNG_ERROR_READING;
  }
 
@@ -191,7 +191,7 @@
  {
   mprintf(("png_read_bitmap: something went wrong\n"));
   /* Free all of the memory associated with the png_ptr and info_ptr */
-  png_destroy_read_struct(&png_ptr, &info_ptr, png_infopp_NULL);
+  png_destroy_read_struct(&png_ptr, &info_ptr, NULL);
   cfclose(png_file);
   /* If we get here, we had a problem reading the file */
   return PNG_ERROR_READING;
@@ -199,7 +199,7 @@
 
  png_set_read_fn(png_ptr, &png_file, png_scp_read_data);
 
- png_read_png(png_ptr, info_ptr, PNG_TRANSFORM_BGR | PNG_TRANSFORM_EXPAND, png_voidp_NULL);
+ png_read_png(png_ptr, info_ptr, PNG_TRANSFORM_BGR | PNG_TRANSFORM_EXPAND, NULL);
  len = png_get_rowbytes(png_ptr, info_ptr);
 
  row_pointers = png_get_rows(png_ptr, info_ptr);
@@ -212,7 +212,7 @@
   memcpy(&image_data[i * len], row_pointers[i], len);
  }
 
- png_destroy_read_struct(&png_ptr, &info_ptr, png_infopp_NULL);
+ png_destroy_read_struct(&png_ptr, &info_ptr, NULL);
  cfclose(png_file);
 
  return PNG_ERROR_NONE;
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Don-DiZzLe on May 13, 2010, 01:28:17 pm
So will this issue be fixed anytime soon without the workaround?
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on May 13, 2010, 01:39:10 pm
Yes, we're going to put that change in trunk I think, and likely also into 3.6.12 Final.  However, the possibility that 1.4 doesn't actually work perfectly yet (as he reported it does not in the barracks) will exist until someone can fix it.  png 1.2.x is still your best bet if you have an option.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Don-DiZzLe on May 13, 2010, 04:33:14 pm
Ok cool, anyways the workaround works just fine for me atm, dunno wut u mean about the barracks tho, im experiencing no transparancy issue whatsoever.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on May 13, 2010, 04:41:39 pm
Are you using the png test pack?  Please try to use that if not and let me know if you're experiencing any issues with it.  The PCX files still work just fine.  Testing instructions should have been posted previously, or linked, in this thread.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Don-DiZzLe on May 13, 2010, 04:51:00 pm
Well just tried that png test pack and wit the pack whenever i select a button the whole square around the button is highlighted aswell, witout the testpack all works fine.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on May 13, 2010, 09:52:15 pm
Yup.  So there's definitely an issue with lib png 1.4.x.  This allows it to compile, but we probably need to file a bug to investigate other issues with it.  I'll still be committing this fix though after I test compile it.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Flaming_Sword on June 19, 2010, 09:03:30 pm
Had a look - what you're seeing is due to dodgy interface images in the linked test pack.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on June 20, 2010, 02:49:11 pm
So with all the testing that happened in antipodes with the test pack then, how was this never noticed with 1.2.x?
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: The E on June 20, 2010, 03:00:09 pm
Because IIRC, everyone who did the testing had their own test packages to test with. I certainly had mine....
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on June 20, 2010, 05:31:52 pm
I seem to remember quite a few people at least being told to use the provided test pack.  I don't know how many did, I'm just surprised it seems to have not been used at all during that time.  What's the point of providing it then :P

Did the pack's creator not even test with it?...
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Echelon9 on June 21, 2010, 09:26:29 am
Are we talking about the highlight that popped up around the button still? Cos, yup I noticed that and reported it, but the dev (sorry forgot which one) said that was the sign that it was working right?!?
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on June 21, 2010, 09:45:32 am
Wait so, the test pack intentionally had a red background to highlight that the png stuff was working?  Ok I guess that does make sense, but maybe that should be noted to eliminate confusion about that in the future.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Echelon9 on June 21, 2010, 04:27:56 pm
Ahh, not red. I just saw a highlight (brighter).
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: The E on June 21, 2010, 04:49:12 pm
Can we haz screenshot?
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: taylor on June 22, 2010, 02:24:22 pm
I tried the test pack and the highlighted buttons were brighter with libpng 1.4, but they were with libpng 1.2 as well so I just thought it was a problem with the graphics themselves and not the code or lib version.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: chief1983 on June 22, 2010, 02:47:15 pm
Well then, from the sound of it, it seems that either everyone gets the test pack's intentional results no matter what libpng version they use, or they possibly get broken results no matter what libpng version they use.  Either way sounds like libpng 1.4.x works as well as 1.2.x.
Title: Re: had trouble compiling svn on arch linux - using workaround
Post by: Zacam on July 03, 2010, 06:39:07 pm
The PNG'ified buttons had some smoothing affected to them, to help define them from the original interface artwork.

When highlighting on the original interface, the images show a marked difference because of the way they are box-shaped. This difference in "contrast" over the original interface (which was by design) shows that it has indeed loaded the PNG element for that interface portion. The main-hall EFF for the starmap shows a "throbbing" Gamma Draconis.

The PNG images are not defective save for the original Nameplates where the Transparent PNG's were made in photoshop.

As for the creator of the linked Test-Package, that would be me.