Author Topic: Trunk 20080525 Rev 4627 (some bug fixes mostly)  (Read 4095 times)

0 Members and 1 Guest are viewing this topic.

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Trunk 20080525 Rev 4627 (some bug fixes mostly)
Not a lot changed since the most recent build before this one, but I did want to show off my first addition to the code.  After helping to debug an issue with additive weapon velocities, I added a new Lua scripting function, isPXOEnabled, with WMC's help.  It can retrieve the status of PXO in the registry/config.  It's mostly because it was needed for SWC.

fso-20080525_CHIEF_4627_PXOFlag
MD5Sum
My first patch

Log:
Code: [Select]
Revision: 4627
Author: WMCoolmon
Date: 1:29:59 AM, Sunday, May 25, 2008
Message:
Fix a null vec_normalize bug from additive weapons
----
Modified : /trunk/fs2_open/code/hud/hudtarget.cpp


Revision: 4626
Author: Backslash
Date: 9:55:56 PM, Saturday, May 24, 2008
Message:
More end_string_at_first_hash_symbol stuff -- targetbox orders, docked ships, message senders
----
Modified : /trunk/fs2_open/code/hud/hudtargetbox.cpp
Modified : /trunk/fs2_open/code/mission/missionmessage.cpp
Modified : /trunk/fs2_open/code/ship/ship.cpp


Revision: 4625
Author: Backslash
Date: 1:55:19 AM, Saturday, May 24, 2008
Message:
Whoops, wrong repository.  Quick correction.
----
Modified : /trunk/fs2_open/code/mission/missionparse.h


Revision: 4624
Author: Backslash
Date: 1:44:29 AM, Saturday, May 24, 2008
Message:
bump MAX_ALT_TYPE_NAMES
----
Modified : /trunk/fs2_open/code/mission/missionparse.h


Revision: 4623
Author: karajorma
Date: 3:24:47 PM, Friday, May 23, 2008
Message:
Fix bug where wings with only one ship would ignore orders
----
Modified : /trunk/fs2_open/code/hud/hudsquadmsg.cpp


Revision: 4622
Author: phreak
Date: 12:35:55 PM, Saturday, May 17, 2008
Message:
remove references to cloaking code.
----
Modified : /trunk/fs2_open/code/ai/aiturret.cpp
Modified : /trunk/fs2_open/code/ship/ship.cpp


Revision: 4621
Author: phreak
Date: 8:29:19 PM, Thursday, May 15, 2008
Message:
Mantis #1462

non-local SSMs home in on objects instead of points to they can track moving targets.

ship_apply_tag and ssm_create take "team" arguments now to indicate which team fired the ssm strike.

ship-tag sexp also has an optional team argument added.  Team 0 is used if the team is not defined.

missiles that are fired without a parent and are locked will travel at their max velocity and not 1/4 of their max.

bugfixes where sometimes an animation may sometimes have a duration of zero and cause an infinite loop.
----
Modified : /trunk/fs2_open/code/hud/hudartillery.cpp
Modified : /trunk/fs2_open/code/hud/hudartillery.h
Modified : /trunk/fs2_open/code/parse/sexp.cpp
Modified : /trunk/fs2_open/code/ship/ship.cpp
Modified : /trunk/fs2_open/code/ship/shiphit.cpp
Modified : /trunk/fs2_open/code/ship/shiphit.h
Modified : /trunk/fs2_open/code/weapon/weapons.cpp


Revision: 4620
Author: karajorma
Date: 5:42:38 PM, Thursday, May 15, 2008
Message:
Fix a crash when using <argument> with a numeric variable (Mantis 1656)
----
Modified : /trunk/fs2_open/code/fred2/sexp_tree.cpp
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline ARSPR

  • Preys On Mantis
  • 29
Re: Trunk 20080525 Rev 4627 (some bug fixes mostly)
Chief, your builds seem defective somehow.

I only get Mantis 1679 (game always running at 1024 x 768) with your builds. Any other people's builds don't suffer it. So it seems a defective compiling or something like that.
IF YOU HAVE TROUBLES WITH FS2:
  • Please, please, please, READ and UNDERSTAND the sticky threads in FreeSpace & FreeSpace Open Support board.
    A lot of people are willing to help you, but, as anyone can understand, seeing the very same "issues" repeated again and again can become quite depressing. Please, spend a bit of time trying to solve the issue by yourself.
    (Lobo deserves a monument).
  • Then, if you aren't still able to solve your issue, feel free to ask for help in that same board.
    FYI, most of the troubles are caused by wrong mod installations which lead to either missing data or undesired cross-effects between them. Always follow the mod installation instructions and keep a clean FS2 installation as explained in the sticky threads. Two additional links about how the game handles game data:
  • If you think that you've discovered a bug, mantis it.
    Provide as much info as you can, and try to narrow it down. A lonely "FS2 doesn't work" is not a good report.

Whoever Hanlon was: Never attribute to malice that which can be adequately explained by stupidity.
Albert Einstein: Two things are infinite: the universe and human stupidity; and I'm not sure about the the universe.

Dell Dimension 9200 - Vista 32-bit Ultimate
Core 2 Quad Q6600 @2.4GHz - RAM 2 GB DDR2
nvidia 8800 GTX - Integrated Sigmatel Audio

 

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Trunk 20080525 Rev 4627 (some bug fixes mostly)
That's news to me, I haven't seen that behavior on my computer.  If anyone else is getting this please post your specs so we can hunt this down.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline SeanP

  • 24
Re: Trunk 20080525 Rev 4627 (some bug fixes mostly)
For the sake of posterity, though my results are more or less on mantis:

(Toshiba Satellite X205-S9810)
Intel Core2Duo T5750 @ 2.00GHz
3GB RAM
nVidia 8700M GT
Windows Vista Home Premium
Toshiba Forceware 156.64

Testing procedure and results:
Code: [Select]
Did a non-standard installation to expedite testing and save bandwidth - copied
my freespace folder from my Linux drive to my Vista drive, then ran Turey's
installer to grab the 3.6.9 and 3.6.10 executables, and more importantly, the
launcher.  Vista popped up with a warning when I closed Turey's installer
stating the installation had not successfully completed.  (I later realized
the installer had not successfully created the appropriate registry values.)

In the first batch of tests, I selected the non-debug version of the build
here, set resolution to 1440x900x32 in the launcher, hit apply and run.  Game
ran at 640x480, and presumably at 16-bit color depth.  Selected various other
resolutions with the same results.

I then ran chief's build from the command line with -res 1440x900, and
successfully ran the game at 1440x900.

Following this success, I retried my first batch of tests, with results
identical to the first run.

Following that, I attempted the first batch of tests with the standard 3.6.9
and 3.6.10 builds available from Turey's installer.  These tests were
successful - the game ran at the resolution specified in the launcher.

I related these tests to chief, and he asked me to attempt to enter a
multiplayer lobby.  I first attempted to do this having not set the options in
the launcher with chief's build.  I was properly rebuffed by the game for
failing to do so, exited the game, and set the options in the launcher, and
clicked apply.  I started chief's build again, attempted to enter the
multiplayer lobby, and was again rebuffed.  I selected the 3.6.10 build from
the installer and was able to enter the multiplayer lobby.

At this point I entered regedit and located the FreeSpace2 folder
(HKEY_LOCAL_MACHINE/Software/Volition/FreeSpace2).  There were only two keys
present.

I closed the launcher and reopened it.  The settings displayed on the various
tabs were the same as they were prior to closing the launcher.  I again
attempted the first set of tests on chief's exe as well as attempting to join
the multiplayer lobby, and failed every time.  I repeated this with 3.6.10, and
was successful on all attempts.

I closed the launcher and reopened it as an admin via RMB->Run as
Administrator.  I noticed some of the settings had reset---I'm unsure if all
had reset.  I put the settings back to how they were (namely, resolution @
1440x900x32, network on LAN), and clicked apply.  Refreshing my view in regedit
showed the proper fields had been created and filled appropriately.

I now ran the first batch of tests and the nultiplayer test on chief's build.
All tests were successful.  All tests were also successful with 3.6.10.

I closed the launcher and reopened it as a normal user (i.e., double-click) and
reran the tests.  The multiplayer test was successful with chief's build.
However, the resolution was always 1440x900x32 and did not follow what had been
selected in the drop-down.  The builds from Turey's installer completed the
tests successfully.

Conclusions: The launcher doesn't seem to have permission to modify the registry in Vista by default.  A workaround would be to run the launcher as an Administrator, set the options that are set in the registry, then run the launcher and game as normal.  That said, that the FSO executables ran without a hitch while chief's build suffered from the lack of registry values makes absolutely no sense to me.

(Edit: added conclusions)
« Last Edit: May 30, 2008, 01:30:26 am by SeanP »