[Nuke]

its just a unique identifier, like the names the rts uses. you need to come up with a means to tell if the object is still useful. isValid does that fine. periodically loop through the objects if they are valid but arent in the metasystem, add them, if they are in the metasystem but not valid, clear them. luais a memory whore so its absolutely neccisary to clear dead meta entries from the system.

[Nuke]

heres a couple of "why the **** weren't they in lua to begin with" function i wrote for ship

Code: [Select]

ADE_VIRTVAR(WeaponEnergy, l_Ship, "number", "Current weapon energy reserves", "number", "Ship current weapon energy reserve level, or -1 if invalid")
{
object_h *objh;
float neweng = -1;
if(!ade_get_args(L, "o|f", l_Ship.GetPtr(&objh), &neweng))
return ade_set_error(L, "f", -1.0f);

if(!objh->IsValid())
return ade_set_error(L, "f", -1.0f);

ship *shipp = &Ships[objh->objp->instance];

if(ADE_SETTING_VAR && neweng > -1)
shipp->weapon_energy = neweng;

return ade_set_args(L, "f", shipp->weapon_energy);
}

ADE_VIRTVAR(WeaponEnergyMax, l_Ship, "number", "Maximum weapon energy", "number", "Ship maximum weapon energy reserve level, or -1 if invalid")
{
object_h *objh;
float neweng = -1;
if(!ade_get_args(L, "o|f", l_Ship.GetPtr(&objh), &neweng))
return ade_set_error(L, "f", -1.0f);

if(!objh->IsValid())
return ade_set_error(L, "f", -1.0f);

ship_info *sip = &Ship_info[Ships[objh->objp->instance].ship_info_index];

if(ADE_SETTING_VAR && neweng > -1)
sip->max_weapon_reserve = neweng;

return ade_set_args(L, "f", sip->max_weapon_reserve);
}

ive tested them and they work fine

[Aardwolf]

It'd still be nice to get a general-use sexp interpreter for Lua (or something similar)...

That is, being able to execute sexp-format code from Lua, just like we can execute Lua code from the sexp side.

[Nuke]

that might actually make sexps useful

[Nuke]

i fixed a bug with setFOV(), some of the type flags were set wrong in the ade_get_args call

Code: [Select]

ADE_FUNC(setFOV, l_Camera, "[number FOV, number Zoom Time, number Zoom Acceleration Time, number Zoom deceleration Time]",
"Sets camera FOV"
"<br>FOV is the final field of view, in radians, of the camera."
"<br>Zoom Time is the total time to take zooming in or out."
"<br>Acceleration Time is the total time it should take the camera to get up to full zoom speed."
"<br>Deceleration Time is the total time it should take the camera to slow down from full zoom speed.",
"boolean", "true if successful, false or nil otherwise")
{
camid cid;
float n_fov = VIEWER_ZOOM_DEFAULT;
float time=0.0f;
float acc_time=0.0f;
float dec_time=0.0f;
if(!ade_get_args(L, "o|ffff", l_Camera.Get(&cid), &n_fov, &time, &acc_time, &dec_time))
return ADE_RETURN_NIL;

if(!cid.isValid())
return ADE_RETURN_NIL;

cid.getCamera()->set_fov(n_fov, time, acc_time, dec_time);

return ADE_RETURN_TRUE;
}


[The E]

Okay, here are some naive changes I made to several functions to make a few additional scripting functions work. I'm quite certain this could have been done in a prettier way, but I'm not experienced enough to see it....

[attachment deleted by Tolwyn]

[chief1983]

You don't really need to leave commented out code in the files.  The beauty of SVN is we can just revert back and the patch itself shows what was there before anyway.

[The E]

<Jayne>Well, now I know that</Jayne>