Author Topic: armor table upgrades and fixes  (Read 9589 times)

0 Members and 1 Guest are viewing this topic.

Offline Echelon9

  • Moderator
  • 210
Re: armor table upgrades and fixes
Tested compile on Mac, it at least builds against latest trunk (r8627). Haven't given it any more fulsome testing.

Patch that will apply cleanly against that revision attached -- no operative changes.

[attachment deleted by a ninja]

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Minecraft
    • Steam
    • Twitter
    • ModDB Feature
Re: armor table upgrades and fixes
Using the last posted patch, I was able to get confirmation of compile on OS X, and confirmed compile on Windows. Still need to test compiling under Linux.

Nothing jumps out at me as needing correction, and my tests with the MediaVPs and Blue Planet did not produce any odd behaviours.

Assuming that Linux has no issues, I'll have this committed by Tuesday afternoon (It's now Monday for me right now) unless anybody else can come up with anything that needs correction.

I attached a mildly altered version that I'll be committing, baring any issues.


[attachment deleted by a ninja]
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline Zacam

  • Magnificent Bastard
  • Administrator
  • 211
  • I go Sledge-O-Matic on Spammers
    • Minecraft
    • Steam
    • Twitter
    • ModDB Feature
Re: armor table upgrades and fixes
Committed r8629

Would still like more feedback regarding this, but honestly it's been long enough that anything potentially still outstanding on it is probably minor enough or fringe enough that it can be dealt with while live.
Report MediaVP issues, now on the MediaVP Mantis! Read all about it Here!
Talk with the community on Discord
"If you can keep a level head in all this confusion, you just don't understand the situation"

¤[D+¬>

[08/01 16:53:11] <sigtau> EveningTea: I have decided that I am a 32-bit registerkin.  Pronouns are eax, ebx, ecx, edx.
[08/01 16:53:31] <EveningTea> dhauidahh
[08/01 16:53:32] <EveningTea> sak
[08/01 16:53:40] * EveningTea froths at the mouth
[08/01 16:53:40] <sigtau> i broke him, boys

 

Offline Nuke

  • Ka-Boom!
  • 212
  • Mutants Worship Me
Re: armor table upgrades and fixes
it did make me get an understanding for how ridiculously complicated the engines damage computations are. it gave me headaches. so glad its finally in.
I can no longer sit back and allow communist infiltration, communist indoctrination, communist subversion, and the international communist conspiracy to sap and impurify all of our precious bodily fluids.

Nuke's Scripting SVN

 

Offline Droid803

  • Trusted poster of legit stuff
  • 213
  • /人 ◕ ‿‿ ◕ 人\ Do you want to be a Magical Girl?
    • Skype
    • Steam
Re: armor table upgrades and fixes
YES. YES. YES.
/M. Bison.
(´・ω・`)
=============================================================

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Re: armor table upgrades and fixes
hurr durr

How many people tested this patch with this in mind? :p

make sure i didnt break the game's damage mechanics

This revision is apparently the cause of the recently discovered difficulty bug.

 

Offline Nuke

  • Ka-Boom!
  • 212
  • Mutants Worship Me
Re: armor table upgrades and fixes
i figured with the big red letters it would have been at the top of everyone's list.

the main feature/bugfix of the patch was the ability to tell the game when to do the damage calculations for difficulty scaling. the difficulty scaling was done before the armor-damage calculations originally. so i added +Difficulty Scale Type:, which can be set to one of 3 things "first" (default), "last" or "manual". if set to manual, then no difficulty scaling would be done (new features gave you access to the scaling factor and you could use explicitly it in your calculations). if this mode was somehow defaulting to manual it would explain why this is happening. but thats just a theory. il take a look at this tomorrow when my brain isnt tired and the contents of my freespace2 folder is brought up to date.
I can no longer sit back and allow communist infiltration, communist indoctrination, communist subversion, and the international communist conspiracy to sap and impurify all of our precious bodily fluids.

Nuke's Scripting SVN

 

Offline Macfie

  • 210
  • If somebody made a campaign I've probably got it
Re: armor table upgrades and fixes
hurr durr

How many people tested this patch with this in mind? :p

make sure i didnt break the game's damage mechanics

This revision is apparently the cause of the recently discovered difficulty bug.

Actually, I believe this problem was commented on several times but was commented on as a change in the AI response.  Which was generally blown off with the comment that there had been no change to the AI and no further investigation was performed.
Normal people believe that if it isn't broke, don't fix it. Engineers believe that if it isn't broke, it doesn't have enough features yet.
The difference between Mechanical Engineers and Civil Engineers is:
Mechanical Engineers build weapons.  Civil Engineers build targets
An optimist sees the glass half full; the pessimist sees it half empty. An engineer sees that the glass is twice as big as it needs to be.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
Re: armor table upgrades and fixes
Sounds like groupthink.  Can you point to specific posts or quotes so that we can learn to avoid falling into those traps in the future?

 

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Re: armor table upgrades and fixes
hurr durr

How many people tested this patch with this in mind? :p

make sure i didnt break the game's damage mechanics

This revision is apparently the cause of the recently discovered difficulty bug.

Actually, I believe this problem was commented on several times but was commented on as a change in the AI response.  Which was generally blown off with the comment that there had been no change to the AI and no further investigation was performed.

Sounds like groupthink.  Can you point to specific posts or quotes so that we can learn to avoid falling into those traps in the future?

No, actually, last time Macfie brought this up, I told him the AI shouldn't have been changed and if he was observing change it was a serious issue that needed to be investigated.

Let me go get the specific quotes.

e: actually apparently i just trailed off like a slackjawed moron http://www.hard-light.net/forums/index.php?topic=83485.msg1669976#msg1669976

 

Offline Mongoose

  • Rikki-Tikki-Tavi
  • Global Moderator
  • 212
  • This brain for rent.
    • Minecraft
    • Steam
    • Something
Re: armor table upgrades and fixes
Hey, if I had a nickel for every time I did that, I'd...

So when this bug gets sorted out, would it be grounds for a re-release of 3.6.16 final?  Because I feel like the last thing we want to be doing is pointing newbies at an official version that's liable to slaughter them on a regular basis.

(Meanwhile, like a masochistic idiot, Mongoose keeps using this build...)

  

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: armor table upgrades and fixes
Higher difficulty levels probably aren't having as big a difference, so our veteran players probably didn't notice anything with it.  But we'll be version bumping, not trying to release a second 3.6.16.  Probably expect a 3.6.16.1 as soon as this is fixed.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays