Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Nightly Builds => Topic started by: SirKnightly on May 02, 2022, 01:51:37 am

Title: Nightly: 02 May 2022 - Revision 670665d0a
Post by: SirKnightly on May 02, 2022, 01:51:37 am
Here is the nightly for 02 May 2022 - Revision 670665d0a



Group: Win32-SSE2
nightly_20220502_670665d0a-builds-Win32-SSE2.zip (http://scp.indiegames.us/builds/nightly/20220502_670665d0a/nightly_20220502_670665d0a-builds-Win32-SSE2.zip) (Mirror (https://porphyrion.feralhosting.com/datacorder/builds/nightly/20220502_670665d0a/nightly_20220502_670665d0a-builds-Win32-SSE2.zip))


Group: Linux
nightly_20220502_670665d0a-builds-Linux.tar.gz (http://scp.indiegames.us/builds/nightly/20220502_670665d0a/nightly_20220502_670665d0a-builds-Linux.tar.gz) (Mirror (https://porphyrion.feralhosting.com/datacorder/builds/nightly/20220502_670665d0a/nightly_20220502_670665d0a-builds-Linux.tar.gz))


Group: Win64-SSE2
nightly_20220502_670665d0a-builds-x64-SSE2.zip (http://scp.indiegames.us/builds/nightly/20220502_670665d0a/nightly_20220502_670665d0a-builds-x64-SSE2.zip) (Mirror (https://porphyrion.feralhosting.com/datacorder/builds/nightly/20220502_670665d0a/nightly_20220502_670665d0a-builds-x64-SSE2.zip))

Code: [Select]
------------------------------------------------------------------------
commit 670665d0a
Author: Joshua Glatt
Commit: GitHub

    SEXP containers, Part 6: FRED/qtFRED SEXP trees (#3852)
 code/mission/missioncampaign.h             |    2 +-
 code/missionui/missiondebrief.cpp          |    1 +
 code/parse/sexp.cpp                        |  234 ++++++-
 code/parse/sexp_container.cpp              |   58 +-
 code/parse/sexp_container.h                |   12 +-
 fred2/addmodifycontainerdlg.cpp            |  118 ++--
 fred2/addmodifycontainerdlg.h              |   16 +-
 fred2/fred.rc                              |   12 +
 fred2/res/container_data.bmp               |  Bin 0 -> 246 bytes
 fred2/res/container_name.bmp               |  Bin 0 -> 246 bytes
 fred2/resource.h                           |    3 +-
 fred2/sexp_tree.cpp                        | 1017 +++++++++++++++++++++++++---
 fred2/sexp_tree.h                          |   42 +-
 freespace2/freespace.cpp                   |    3 +-
 qtfred/resources/images/container_data.png |  Bin 0 -> 202 bytes
 qtfred/resources/images/container_name.png |  Bin 0 -> 183 bytes
 qtfred/resources/resources.qrc             |    2 +
 qtfred/src/ui/widgets/sexp_tree.cpp        |  951 ++++++++++++++++++++++++--
 qtfred/src/ui/widgets/sexp_tree.h          |   37 +-
 19 files changed, 2234 insertions(+), 274 deletions(-)

------------------------------------------------------------------------
commit 65d4423b4
Author: MageKing17
Commit: GitHub

    Make the "$Player Weapon Precedence:" list actually give precedence. (#4225)
 code/missionui/missionweaponchoice.cpp | 30 +++++++++---------------------
 1 file changed, 9 insertions(+), 21 deletions(-)

------------------------------------------------------------------------
commit fff19927e
Author: wookieejedi
Commit: GitHub

    Add Subsystem Flag to Hide Turrets from Ship Loadout Stats (#4235)
 code/missionui/missionshipchoice.cpp | 2 +-
 code/model/model_flags.h             | 1 +
 code/ship/ship.cpp                   | 3 ++-
 3 files changed, 4 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 316ef398e
Author: BMagnu
Commit: GitHub

    Encapsulate testing for LoS in a function and expose to Lua (#4234)
 code/ai/ai.h                        |   3 +
 code/ai/aicode.cpp                  | 198 +++++++++++++++++++-----------------
 code/scripting/api/libs/mission.cpp |  64 ++++++++++++
 code/scripting/lua/LuaValue.h       |  15 +++
 4 files changed, 189 insertions(+), 91 deletions(-)

------------------------------------------------------------------------
commit ca6a9017c
Author: Goober5000
Commit: Goober5000

    patch the freeing of SEXP nodes
 code/mission/missionparse.cpp |  6 ++++++
 code/parse/sexp.cpp           | 24 ++++++++++++++++--------
 code/parse/sexp.h             |  2 +-
 fred2/campaigntreeview.cpp    |  2 +-
 4 files changed, 24 insertions(+), 10 deletions(-)
Title: Re: Nightly: 02 May 2022 - Revision 670665d0a
Post by: Antares on May 04, 2022, 07:04:18 pm
Recent nightly builds (over the last week or so) appear to be applying wonky logic to the "target nearest hostile" function. I don't know exactly what's going on, but pressing H frequently targets ships that are not, in fact, the nearest hostile. At first I thought it was giving priority to enemy ships due to their designation within a wing (i.e., targeting Virgo 1 when Virgo 4 is nearer), but that doesn't seem to always be the case, either.  :confused:

For testing, I've been playing "The Tablet of Destinies" in Scroll of Atankharzim. It's a busy mission with a lot of enemy fighters, bombers, and capital ships, and also uses an escort list.
Title: Re: Nightly: 02 May 2022 - Revision 670665d0a
Post by: Goober5000 on May 07, 2022, 06:29:10 pm
This could be related to PR 4121:
https://github.com/scp-fs2open/fs2open.github.com/pull/4121

However, this should only affect edge cases.  It should not have a significant difference - e.g. it should not target a ship that's far away when there's a hostile ship that's close.  Can you make a video or something to illustrate what happens?
Title: Re: Nightly: 02 May 2022 - Revision 670665d0a
Post by: Antares on May 07, 2022, 10:54:15 pm
Here's a clip. (https://i.imgur.com/hhMn8Mc.mp4) (Apologies for the lousy framerate; actual gameplay is smoother than that.) This was recorded using the latest nightly.

The Tribune explodes 21 seconds in, then the Irkalla deploys its Gorgons. Irkalla itself is already targeted. Cancer 1 deploys from the docking bay on the Irkalla's left, on the opposite side of the ship, while Cancer 2, 3 and 4 emerge from the docking bay on the right side, nearer to the player. The H key is pressed several times, targeting the following units in order:

- Cancer 1 (~2800 units away)
- Cancer 4 (2400 units)
- Irkalla (3100 units)
- Cancer 1 (3000 units)
- Cancer 4 (2200 units)
- Cancer 2 (approximately the same distance)

The system appears to be prioritizing Cancer 1 and the Irkalla, even though they are at all times more distant from the player; Cancer 2, 3 and 4 are clearly closer.
Title: Re: Nightly: 02 May 2022 - Revision 670665d0a
Post by: Goober5000 on May 10, 2022, 12:16:49 am
It's impossible to tell what's going on in that video so I made a test mission.  The targeting behavior does seem different between earlier builds and current builds.

https://www.dropbox.com/s/raabnb7xygkl4sb/0targeting.fs2?dl=0
Title: Re: Nightly: 02 May 2022 - Revision 670665d0a
Post by: Goober5000 on May 10, 2022, 09:52:23 pm
I figured it out.  A new PR is up: https://github.com/scp-fs2open/fs2open.github.com/pull/4256