[Zacam]

OP Updated with Trunk Sync r7537.

No changelog as this is just a maintenance/sync update.

[Rvn]

What happend? I can't download anything.

[chief1983]

DNS expired, it should be getting paid for again today, but I don't know if there's any delay for it to actually activate and propagate again.

[Echelon9]

I ran PVS-Studio against r7698 of Antipodes, which following Zacam's syncs should just contain the delta for the new pilot code. I've pulled out those reports which are unique to the new pilot code.

Manner of reading the reports can be found here.

Potential issues picked up, along with file and line references are:

Code: [Select]

False 2 14578 V506 Pointer to local variable 't_plr' is stored outside the scope of this variable. Such a pointer will become invalid. code plr.cpp 997 False
False 1 9412 V568 It's odd that the argument of sizeof() operator is the '(ushort) sc->m_okKills [idx]' expression. code multimsgs.cpp 6478 False
False 1 9415 V568 It's odd that the argument of sizeof() operator is the '(ushort) sc->kills [idx]' expression. code multimsgs.cpp 6486 False
False 2 14579 V802 On 32-bit platform, structure size can be reduced from 28 to 24 bytes by rearranging the fields according to their sizes in decreasing order. code plr_convert.cpp 16 False

[chief1983]

Crashing pilot file

The converter is asserting in debug when converting this pilot, I can't figure out why but maybe someone else can, if it crashes for them too.

[niffiwan]

I've just logged a mantis issue for a hard to reproduce bug, possibly in the red alert code. 

Could someone please take a look at this patch & advise if this is a good idea or not?  It doesn't fix the issue, but I'm hoping it will help us track down what is causing the issue because so far, it's got me stumped.

Thanks

Code: [Select]

Index: code/missionui/redalert.cpp
===================================================================
--- code/missionui/redalert.cpp (revision 7733)
+++ code/missionui/redalert.cpp (working copy)
@@ -618,6 +618,8 @@
  red_alert_store_subsys_status(&ras, shipp);
 
  Red_alert_wingman_status.push_back( ras );
+ // niffiwan: trying to track down red alert bug creating HUGE pilot files
+ Assert( (Red_alert_wingman_status.size() <= MAX_SHIPS) );
  }
 
  // store exited ships that did not die
@@ -640,6 +642,8 @@
  red_alert_store_subsys_status(&ras, NULL);
 
  Red_alert_wingman_status.push_back( ras );
+ // niffiwan: trying to track down red alert bug creating HUGE pilot files
+ Assert( (Red_alert_wingman_status.size() <= MAX_SHIPS) );
  }
  }

[attachment deleted by ninja]

[Echelon9]

Could someone please take a look at this patch & advise if this is a good idea or not?  It doesn't fix the issue, but I'm hoping it will help us track down what is causing the issue because so far, it's got me stumped.

Patch looks fine as a means to tracking down what's going on, and catching a nonsensical value. I've committed it to Antipodes branch.

[Echelon9]

A proposed fix for a PVS-Studio report in the Antipodes branch. As it's within the core Windows debugging section I'm putting here for review by the more experienced Windows-based SCP'ers

Issue

Code: [Select]

V512 A call of the 'memset' function will lead to underflow of the buffer '&stackFrame'.  code  mspdb_callstack.cpp  189
Proposed Fix

Code: [Select]

Index: code/globalincs/mspdb_callstack.cpp
===================================================================
--- code/globalincs/mspdb_callstack.cpp (revision 7759)
+++ code/globalincs/mspdb_callstack.cpp (working copy)
@@ -186,7 +186,7 @@
 
  /* Initialise the stackframe */
  STACKFRAME64 stackFrame;
- memset( &stackFrame, 0, sizeof( STACKFRAME ) );
+ memset( &stackFrame, 0, sizeof( STACKFRAME64 ) );
  stackFrame.AddrPC.Mode = AddrModeFlat;
  stackFrame.AddrFrame.Mode = AddrModeFlat;
  stackFrame.AddrStack.Mode = AddrModeFlat;

[attachment deleted by ninja]

[mjn.mixael]

Got another pilot file corrupted. Debug build dies parsing the red alert section of the campaign file. I've included the base player and campaign file here.

Code: [Select]

FreeSpace 2 Open version: 3.6.13
Passed cmdline options:
  -spec_exp 5.5
  -ogl_spec 30
  -spec_static 0.4
  -spec_point 0.3
  -spec_tube 0.2
  -ambient_factor 47.5
  -env
  -mipmap
  -missile_lighting
  -glow
  -spec
  -no_emissive_light
  -normal
  -3dshockwave
  -soft_particles
  -post_process
  -bloom_intensity 42
  -fxaa_preset 2
  -fb_explosions
  -dualscanlines
  -rearm_timer
  -targetinfo
  -3dwarp
  -ship_choice_3d
  -weapon_choice_3d
  -warp_flash
  -snd_preload
  -mod fsport-mediavps,FSPort-STR,fsport,mediavps
  -disable_di_mouse
Building file index...
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_bastion1.vp' with a checksum of 0xd3ec4ed9
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_bastion2.vp' with a checksum of 0x49cb5471
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_core.vp' with a checksum of 0x811c2584
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_galatea.vp' with a checksum of 0x7263ae91
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_krios.vp' with a checksum of 0xc46dc806
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_soyakaze.vp' with a checksum of 0x888eb475
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_select_shp.vp' with a checksum of 0xae6032fe
Found root pack 'E:\FreeSpace2\fsport-mediavps\fs1_select_wep.vp' with a checksum of 0xd0be01f9
Found root pack 'E:\FreeSpace2\fsport-mediavps\mv_fsport.vp' with a checksum of 0x34c30edf
Found root pack 'E:\FreeSpace2\FSPort-STR\fsport-str-voice.vp' with a checksum of 0xe72dc0dc
Found root pack 'E:\FreeSpace2\FSPort-STR\fsport-str.vp' with a checksum of 0xb50870b8
Found root pack 'E:\FreeSpace2\fsport\a_logo_fix.vp' with a checksum of 0x287e1d7a
Found root pack 'E:\FreeSpace2\fsport\fsport-missions.vp' with a checksum of 0x73018100
Found root pack 'E:\FreeSpace2\fsport\fsport3_3.vp' with a checksum of 0x4d97be5e
Found root pack 'E:\FreeSpace2\fsport\odeon_fs1.vp' with a checksum of 0x6b0eb146
Found root pack 'E:\FreeSpace2\fsport\sparky_hi_fs1.vp' with a checksum of 0x09e704a7
Found root pack 'E:\FreeSpace2\fsport\stu_fs1.vp' with a checksum of 0xa75a86ce
Found root pack 'E:\FreeSpace2\fsport\tango_fs1.vp' with a checksum of 0x82c24ecf
Found root pack 'E:\FreeSpace2\fsport\tango_hi1_fs1.vp' with a checksum of 0xb35366d1
Found root pack 'E:\FreeSpace2\fsport\tango_hi2_fs1.vp' with a checksum of 0x646bbc00
Found root pack 'E:\FreeSpace2\fsport\tango_hi3_fs1.vp' with a checksum of 0x35c0f825
Found root pack 'E:\FreeSpace2\fsport\tango_hi4_fs1.vp' with a checksum of 0xe03da761
Found root pack 'E:\FreeSpace2\fsport\tango_hi5_fs1.vp' with a checksum of 0xe01788b3
Found root pack 'E:\FreeSpace2\fsport\warble_fs1.vp' with a checksum of 0x0b608285
Found root pack 'E:\FreeSpace2\mediavps\00Testing.vp' with a checksum of 0x9804f82b
Found root pack 'E:\FreeSpace2\mediavps\MV_A-Glows.vp' with a checksum of 0xc63fbd06
Found root pack 'E:\FreeSpace2\mediavps\MV_Advanced.vp' with a checksum of 0x55a96e8f
Found root pack 'E:\FreeSpace2\mediavps\MV_Assets.vp' with a checksum of 0x32fe68ec
Found root pack 'E:\FreeSpace2\mediavps\MV_CB_ANI_1.vp' with a checksum of 0x9c948078
Found root pack 'E:\FreeSpace2\mediavps\MV_CB_ANI_2.vp' with a checksum of 0xd1e3fc51
Found root pack 'E:\FreeSpace2\mediavps\MV_Effects.vp' with a checksum of 0x26b7e033
Found root pack 'E:\FreeSpace2\mediavps\MV_Music.vp' with a checksum of 0x5118d025
Found root pack 'E:\FreeSpace2\mediavps\MV_RadarIcons.vp' with a checksum of 0x8c887ae9
Found root pack 'E:\FreeSpace2\mediavps\MV_Root.vp' with a checksum of 0x9d6bb31f
Found root pack 'E:\FreeSpace2\FS2OGGcutscenepack.vp' with a checksum of 0x84396e99
Found root pack 'E:\FreeSpace2\multi-mission-pack.vp' with a checksum of 0x88e1e926
Found root pack 'E:\FreeSpace2\multi-voice-pack.vp' with a checksum of 0xd50e7442
Found root pack 'E:\FreeSpace2\root_fs2.vp' with a checksum of 0xce10d76c
Found root pack 'E:\FreeSpace2\smarty_fs2.vp' with a checksum of 0xddeb3b1e
Found root pack 'E:\FreeSpace2\sparky_fs2.vp' with a checksum of 0x164fe65a
Found root pack 'E:\FreeSpace2\sparky_hi_fs2.vp' with a checksum of 0xa11d56f1
Found root pack 'E:\FreeSpace2\stu_fs2.vp' with a checksum of 0xd77da83a
Found root pack 'E:\FreeSpace2\tango1_fs2.vp' with a checksum of 0x4c25221e
Found root pack 'E:\FreeSpace2\tango2_fs2.vp' with a checksum of 0x86920b82
Found root pack 'E:\FreeSpace2\tango3_fs2.vp' with a checksum of 0x705e8d71
Found root pack 'E:\FreeSpace2\warble_fs2.vp' with a checksum of 0xd85c305d
Searching root 'E:\FreeSpace2\fsport-mediavps\' ... 67 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_bastion1.vp' ... 4829 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_bastion2.vp' ... 6905 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_core.vp' ... 10 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_galatea.vp' ... 817 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_krios.vp' ... 204 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_mh_soyakaze.vp' ... 202 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_select_shp.vp' ... 2671 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\fs1_select_wep.vp' ... 4876 files
Searching root pack 'E:\FreeSpace2\fsport-mediavps\mv_fsport.vp' ... 493 files
Searching root 'E:\FreeSpace2\FSPort-STR\' ... 2 files
Searching root pack 'E:\FreeSpace2\FSPort-STR\fsport-str-voice.vp' ... 943 files
Searching root pack 'E:\FreeSpace2\FSPort-STR\fsport-str.vp' ... 63 files
Searching root 'E:\FreeSpace2\fsport\' ... 27 files
Searching root pack 'E:\FreeSpace2\fsport\a_logo_fix.vp' ... 29 files
Searching root pack 'E:\FreeSpace2\fsport\fsport-missions.vp' ... 211 files
Searching root pack 'E:\FreeSpace2\fsport\fsport3_3.vp' ... 864 files
Searching root pack 'E:\FreeSpace2\fsport\odeon_fs1.vp' ... 10 files
Searching root pack 'E:\FreeSpace2\fsport\sparky_hi_fs1.vp' ... 1230 files
Searching root pack 'E:\FreeSpace2\fsport\stu_fs1.vp' ... 1539 files
Searching root pack 'E:\FreeSpace2\fsport\tango_fs1.vp' ... 92 files
Searching root pack 'E:\FreeSpace2\fsport\tango_hi1_fs1.vp' ... 9 files
Searching root pack 'E:\FreeSpace2\fsport\tango_hi2_fs1.vp' ... 26 files
Searching root pack 'E:\FreeSpace2\fsport\tango_hi3_fs1.vp' ... 28 files
Searching root pack 'E:\FreeSpace2\fsport\tango_hi4_fs1.vp' ... 13 files
Searching root pack 'E:\FreeSpace2\fsport\tango_hi5_fs1.vp' ... 16 files
Searching root pack 'E:\FreeSpace2\fsport\warble_fs1.vp' ... 111 files
Searching root 'E:\FreeSpace2\mediavps\' ... 8 files
Searching root pack 'E:\FreeSpace2\mediavps\00Testing.vp' ... 5669 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_A-Glows.vp' ... 1641 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_Advanced.vp' ... 1496 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_Assets.vp' ... 1757 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_CB_ANI_1.vp' ... 32 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_CB_ANI_2.vp' ... 52 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_Effects.vp' ... 2043 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_Music.vp' ... 32 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_RadarIcons.vp' ... 24 files
Searching root pack 'E:\FreeSpace2\mediavps\MV_Root.vp' ... 300 files
Searching root 'E:\FreeSpace2\' ... 313 files
Searching root pack 'E:\FreeSpace2\FS2OGGcutscenepack.vp' ... 10 files
Searching root pack 'E:\FreeSpace2\multi-mission-pack.vp' ... 108 files
Searching root pack 'E:\FreeSpace2\multi-voice-pack.vp' ... 307 files
Searching root pack 'E:\FreeSpace2\root_fs2.vp' ... 157 files
Searching root pack 'E:\FreeSpace2\smarty_fs2.vp' ... 10 files
Searching root pack 'E:\FreeSpace2\sparky_fs2.vp' ... 3027 files
Searching root pack 'E:\FreeSpace2\sparky_hi_fs2.vp' ... 1337 files
Searching root pack 'E:\FreeSpace2\stu_fs2.vp' ... 2355 files
Searching root pack 'E:\FreeSpace2\tango1_fs2.vp' ... 32 files
Searching root pack 'E:\FreeSpace2\tango2_fs2.vp' ... 15 files
Searching root pack 'E:\FreeSpace2\tango3_fs2.vp' ... 10 files
Searching root pack 'E:\FreeSpace2\warble_fs2.vp' ... 52 files
Found 51 roots and 47074 files.
AutoLang: Language auto-detection successful...
Setting language to English
TBM  =>  Starting parse of 'mv_root-lcl.tbm' ...
Initializing OpenAL...
  OpenAL Vendor     : Creative Labs Inc.
  OpenAL Renderer   : Software
  OpenAL Version    : 1.1

  Available Playback Devices:
    Speakers (Realtek High Definition Audio) via DirectSound  *preferred*
    DirectSound Default
    Realtek Digital Output(RCA) (Realtek High Definition Audio) via DirectSound
    Realtek Digital Output (Realtek High Definition Audio) via DirectSound
    WaveOut Default
    Speakers (Realtek High Definiti via WaveOut
    Realtek Digital Output(RCA) (Re via WaveOut
    Realtek Digital Output (Realtek via WaveOut
    No Output
    Generic Software on Speakers (Realtek High Definition Audio)
    Generic Software on Realtek Digital Output(RCA) (Realtek High Definition Audio)
    Generic Software on Realtek Digital Output (Realtek High Definition Audio)

  Available Capture Devices:
    Realtek Digital Input (Realtek   *default*
    Realtek Digital Input (Realtek  via WaveIn

  Found extension "AL_EXT_float32".
  Found extension "ALC_EXT_EFX".

  Sample rate: 44100 (44100)
  EFX enabled: NO
  Playback device: Speakers (Realtek High Definition Audio) via DirectSound
  Capture device: Realtek Digital Input (Realtek
... OpenAL successfully initialized!
Initializing OpenGL graphics device at 1440x900 with 32-bit color...
  Initializing WGL...
  Requested WGL Video values = R: 8, G: 8, B: 8, depth: 32, double-buffer: 1
  Actual WGL Video values    = R: 8, G: 8, B: 8, depth: 32, double-buffer: 1
  OpenGL Vendor    : NVIDIA Corporation
  OpenGL Renderer  : Quadro FX 1800/PCI/SSE2
  OpenGL Version   : 3.3.0

  Using extension "GL_EXT_fog_coord".
  Using extension "GL_ARB_multitexture".
  Using extension "GL_ARB_texture_env_add".
  Using extension "GL_ARB_texture_compression".
  Using extension "GL_EXT_texture_compression_s3tc".
  Using extension "GL_EXT_texture_filter_anisotropic".
  Using extension "GL_ARB_texture_env_combine".
  Using extension "GL_EXT_compiled_vertex_array".
  Using extension "GL_EXT_draw_range_elements".
  Using extension "GL_ARB_texture_mirrored_repeat".
  Using extension "GL_ARB_texture_non_power_of_two".
  Using extension "GL_ARB_vertex_buffer_object".
  Using extension "GL_ARB_pixel_buffer_object".
  Using extension "GL_SGIS_generate_mipmap".
  Using extension "GL_EXT_framebuffer_object".
  Using extension "GL_ARB_texture_rectangle".
  Using extension "GL_EXT_bgra".
  Using extension "GL_ARB_texture_cube_map".
  Using extension "GL_EXT_texture_lod_bias".
  Using extension "GL_ARB_point_sprite".
  Using extension "GL_ARB_shading_language_100".
  Using extension "GL_ARB_shader_objects".
  Using extension "GL_ARB_vertex_shader".
  Using extension "GL_ARB_fragment_shader".
  Using extension "GL_NV_vertex_program3".
  Found special extension function "wglSwapIntervalEXT".

  Compiling shader: main-v.sdr (null-v.sdr), main-f.sdr (null-f.sdr)
  Compiling shader: main-v.sdr (lne-v.sdr), main-f.sdr (lbgsne-f.sdr)
  Compiling shader: main-v.sdr (lne-v.sdr), main-f.sdr (lbsne-f.sdr)
  Compiling shader: main-v.sdr (lfne-v.sdr), main-f.sdr (lfbgsne-f.sdr)
  Compiling shader: main-v.sdr (lfne-v.sdr), main-f.sdr (lfbsne-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (lb-f.sdr)
  Compiling shader: main-v.sdr (b-v.sdr), main-f.sdr (b-f.sdr)
  Compiling shader: main-v.sdr (b-v.sdr), main-f.sdr (bg-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (lbg-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (lbgs-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (lbs-f.sdr)
  Compiling shader: main-v.sdr (le-v.sdr), main-f.sdr (lbgse-f.sdr)
  Compiling shader: main-v.sdr (le-v.sdr), main-f.sdr (lbse-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (lbgn-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (lbgsn-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (lbn-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (lbsn-f.sdr)
  Compiling shader: main-v.sdr (lf-v.sdr), main-f.sdr (lfb-f.sdr)
  Compiling shader: main-v.sdr (lf-v.sdr), main-f.sdr (lfbg-f.sdr)
  Compiling shader: main-v.sdr (lf-v.sdr), main-f.sdr (lfbgs-f.sdr)
  Compiling shader: main-v.sdr (lf-v.sdr), main-f.sdr (lfbs-f.sdr)
  Compiling shader: main-v.sdr (lfe-v.sdr), main-f.sdr (lfbgse-f.sdr)
  Compiling shader: main-v.sdr (lfe-v.sdr), main-f.sdr (lfbse-f.sdr)
  Compiling shader: main-v.sdr (lfn-v.sdr), main-f.sdr (lfbgn-f.sdr)
  Compiling shader: main-v.sdr (lfn-v.sdr), main-f.sdr (lfbgsn-f.sdr)
  Compiling shader: main-v.sdr (lfn-v.sdr), main-f.sdr (lfbn-f.sdr)
  Compiling shader: main-v.sdr (lfn-v.sdr), main-f.sdr (lfbsn-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (null-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (lg-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (lgs-f.sdr)
  Compiling shader: main-v.sdr (l-v.sdr), main-f.sdr (ls-f.sdr)
  Compiling shader: main-v.sdr (le-v.sdr), main-f.sdr (lgse-f.sdr)
  Compiling shader: main-v.sdr (le-v.sdr), main-f.sdr (lse-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (lgn-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (lgsn-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (ln-f.sdr)
  Compiling shader: main-v.sdr (ln-v.sdr), main-f.sdr (lsn-f.sdr)
  Compiling shader: main-v.sdr (lne-v.sdr), main-f.sdr (lgsne-f.sdr)
  Compiling shader: main-v.sdr (lne-v.sdr), main-f.sdr (lsne-f.sdr)
  Compiling shader: main-v.sdr (la-v.sdr), main-f.sdr (la-f.sdr)
  Compiling shader: main-v.sdr (la-v.sdr), main-f.sdr (lba-f.sdr)
  Compiling shader: main-v.sdr (ba-v.sdr), main-f.sdr (ba-f.sdr)
  Compiling shader: main-v.sdr (ba-v.sdr), main-f.sdr (bga-f.sdr)
  Compiling shader: main-v.sdr (la-v.sdr), main-f.sdr (lbga-f.sdr)
  Compiling shader: main-v.sdr (la-v.sdr), main-f.sdr (lbgsa-f.sdr)
  Compiling shader: main-v.sdr (la-v.sdr), main-f.sdr (lbsa-f.sdr)
  Compiling shader: main-v.sdr (lea-v.sdr), main-f.sdr (lbgsea-f.sdr)
  Compiling shader: main-v.sdr (lea-v.sdr), main-f.sdr (lbsea-f.sdr)
  Compiling shader: main-v.sdr (lna-v.sdr), main-f.sdr (lbgna-f.sdr)
  Compiling shader: main-v.sdr (lna-v.sdr), main-f.sdr (lbgsna-f.sdr)
  Compiling shader: main-v.sdr (lna-v.sdr), main-f.sdr (lbna-f.sdr)
  Compiling shader: main-v.sdr (lna-v.sdr), main-f.sdr (lbsna-f.sdr)
  Compiling shader: main-v.sdr (lnea-v.sdr), main-f.sdr (lbgsnea-f.sdr)
  Compiling shader: main-v.sdr (lnea-v.sdr), main-f.sdr (lbsnea-f.sdr)
  Compiling shader: main-v.sdr (lfa-v.sdr), main-f.sdr (lfba-f.sdr)
  Compiling shader: main-v.sdr (lfa-v.sdr), main-f.sdr (lfbga-f.sdr)
  Compiling shader: main-v.sdr (lfa-v.sdr), main-f.sdr (lfbgsa-f.sdr)
  Compiling shader: main-v.sdr (lfa-v.sdr), main-f.sdr (lfbsa-f.sdr)
  Compiling shader: main-v.sdr (lfea-v.sdr), main-f.sdr (lfbgsea-f.sdr)
  Compiling shader: main-v.sdr (lfea-v.sdr), main-f.sdr (lfbsea-f.sdr)
  Compiling shader: main-v.sdr (lfna-v.sdr), main-f.sdr (lfbgna-f.sdr)
  Compiling shader: main-v.sdr (lfna-v.sdr), main-f.sdr (lfbgsna-f.sdr)
  Compiling shader: main-v.sdr (lfna-v.sdr), main-f.sdr (lfbna-f.sdr)
  Compiling shader: main-v.sdr (lfna-v.sdr), main-f.sdr (lfbsna-f.sdr)
  Compiling shader: main-v.sdr (lfnea-v.sdr), main-f.sdr (lfbgsnea-f.sdr)
  Compiling shader: main-v.sdr (lfnea-v.sdr), main-f.sdr (lfbsnea-f.sdr)
  Compiling shader: soft-v.sdr (soft-v.sdr), soft-f.sdr (soft-f.sdr)
Loading built-in default shader for: soft-v.sdr
Loading built-in default shader for: soft-f.sdr
  Compiling shader: soft-v.sdr (soft-v.sdr), soft-f.sdr (soft-f.sdr)
Loading built-in default shader for: soft-v.sdr
Loading built-in default shader for: soft-f.sdr

  Compiling post-processing shader 1 ...
  Compiling post-processing shader 2 ...
  Compiling post-processing shader 3 ...
  Compiling post-processing shader 4 ...
  Compiling post-processing shader 5 ...
Loading built-in default shader for: fxaa-v.sdr
Loading built-in default shader for: fxaa-f.sdr
  Compiling post-processing shader 6 ...

  Max texture units: 4 (32)
  Max elements vertices: 1048576
  Max elements indices: 1048576
  Max texture size: 8192x8192
  Max render buffer size: 8192x8192
  Can use compressed textures: YES
  Texture compression available: YES
  Post-processing enabled: YES
  Using bilinear texture filter.
  Using GLSL for model rendering.
  OpenGL Shader Version: 3.30 NVIDIA via Cg compiler
... OpenGL init is complete!
Size of bitmap info = 742 KB
Size of bitmap extra info = 48 bytes
ANI cursorweb with size 24x24 (25.0% wasted)
GRAPHICS: Initializing default colors...
SCRIPTING: Beginning initialization sequence...
SCRIPTING: Beginning Lua initialization...
LUA: Opening LUA state...
LUA: Initializing base Lua libraries...
LUA: Beginning ADE initialization
ADE: Initializing enumeration constants...
ADE: Assigning Lua session...
SCRIPTING: Beginning main hook parse sequence....
Wokka!  Error opening file (scripting.tbl)!
TABLES: Unable to parse 'scripting.tbl'!  Error code = 5.
TBM  =>  Starting parse of 'mouse-sct.tbm' ...
TBM  =>  Starting parse of 'mv_flak-sct.tbm' ...
TBM  =>  Starting parse of 'mv_exp-sct.tbm' ...
TBM  =>  Starting parse of 'mv_dbrs-sct.tbm' ...
SCRIPTING: Inititialization complete.
SCRIPTING: Splash screen overrides checked
SCRIPTING: Splash hook has been run
SCRIPTING: Splash screen conditional hook has been run
Using high memory settings...
Wokka!  Error opening file (interface.tbl)!
WMCGUI: Unable to parse 'interface.tbl'!  Error code = 5.
TBM  =>  Starting parse of 'mv_effects-sdf.tbm' ...
Windows reported 16 joysticks, we found 0
Current soundtrack set to -1 in event_music_reset_choices
TBM  =>  Starting parse of 'mv_music-mus.tbm' ...
TBM  =>  Starting parse of 'mv_effects-mfl.tbm' ...
TBM  =>  Starting parse of 'fs1_effects-mfl.tbm' ...
Wokka!  Error opening file (armor.tbl)!
TABLES: Unable to parse 'armor.tbl'!  Error code = 5.
TBM  =>  Starting parse of 'mv_effects-amr.tbm' ...
TBM  =>  Starting parse of 'mv_assets-aip.tbm' ...
TBM  =>  Starting parse of 'fsport-aip.tbm' ...
TBM  =>  Starting parse of 'str-aip.tbm' ...
TBM  =>  Starting parse of 'mv_effects-wxp.tbm' ...
TBM  =>  Starting parse of 'fs1_effects-wxp.tbm' ...
BMPMAN: Found EFF (exp20.eff) with 75 frames at 20 fps.
BMPMAN: Found EFF (ExpMissileHit1.eff) with 92 frames at 30 fps.
BMPMAN: Found EFF (noeffect.eff) with 1 frames at 1 fps.
BMPMAN: Found EFF (exp04.eff) with 49 frames at 22 fps.
BMPMAN: Found EFF (exp05.eff) with 93 frames at 20 fps.
BMPMAN: Found EFF (exp06.eff) with 92 frames at 22 fps.
BMPMAN: Found EFF (capflash.eff) with 40 frames at 10 fps.
BMPMAN: Found EFF (Maxim_Impact.eff) with 23 frames at 30 fps.
ANI Lamprey_Impact with size 80x80 (37.5% wasted)
ANI Avenger_Impact with size 80x80 (37.5% wasted)
ANI Leech_Impact with size 80x80 (37.5% wasted)
TBM  =>  Starting parse of 'mv_root-wep.tbm' ...
TBM  =>  Starting parse of 'mv_effects-wep.tbm' ...
TBM  =>  Starting parse of 'mv_assets-wep.tbm' ...
TBM  =>  Starting parse of 'mekhu-wep.tbm' ...
TBM  =>  Starting parse of 'fs2_primaries-wep.tbm' ...
TBM  =>  Starting parse of 'railguncycle-wep.tbm' ...
TBM  =>  Starting parse of 'fs1_tech-wep.tbm' ...
TBM  =>  Starting parse of 'fs1_shockwave-wep.tbm' ...
TBM  =>  Starting parse of 'fs1_primaries-wep.tbm' ...
TBM  =>  Starting parse of 'fs1_missiles-wep.tbm' ...
TBM  =>  Starting parse of 'fs1_effects-wep.tbm' ...
TBM  =>  Starting parse of 'fs1_beampierce-wep.tbm' ...
TBM  =>  Starting parse of 'mv_effects-obt.tbm' ...
TBM  =>  Starting parse of 'mv_root-shp.tbm' ...
TBM  =>  Starting parse of 'radar-shp.tbm' ...
TBM  =>  Starting parse of 'mv_effects-shp.tbm' ...
TBM  =>  Starting parse of 'mv_assets-shp.tbm' ...
TBM  =>  Starting parse of 'shivans-shp.tbm' ...
TBM  =>  Starting parse of 'shaitan-shp.tbm' ...
TBM  =>  Starting parse of 'scorpion-shp.tbm' ...
TBM  =>  Starting parse of 'poseidon-shp.tbm' ...
TBM  =>  Starting parse of 'Frankencadia-shp.tbm' ...
TBM  =>  Starting parse of 'colossus-shp.tbm' ...
TBM  =>  Starting parse of 'charybdis-shp.tbm' ...
TBM  =>  Starting parse of 'artemistest-shp.tbm' ...
TBM  =>  Starting parse of 'fsport-turretangles-shp.tbm' ...
TBM  =>  Starting parse of 'fsport-resetmodels-shp.tbm' ...
TBM  =>  Starting parse of 'fsport-abtrails-shp.tbm' ...
TBM  =>  Starting parse of 'str-hulks-shp.tbm' ...
TBM  =>  Starting parse of 'radar-hulks-shp.tbm' ...
TBM  =>  Starting parse of 'HTLHades-shp.tbm' ...
TBM  =>  Starting parse of 'fs1_trails-shp.tbm' ...
TBM  =>  Starting parse of 'fs1_shockwave-shp.tbm' ...
TBM  =>  Starting parse of 'fs1_models-shp.tbm' ...
TBM  =>  Starting parse of 'fsport-reticle-hdg.tbm' ...
TBM  =>  Starting parse of 'mv_root-hdg.tbm' ...
ANI support1 with size 108x24 (25.0% wasted)
ANI damage1 with size 148x25 (21.9% wasted)
ANI wingman1 with size 71x53 (17.2% wasted)
ANI wingman2 with size 35x53 (17.2% wasted)
ANI wingman3 with size 14x53 (17.2% wasted)
ANI toggle1 with size 57x20 (37.5% wasted)
ANI head1 with size 164x132 (48.4% wasted)
ANI weapons1 with size 126x20 (37.5% wasted)
ANI weapons1_b with size 150x20 (37.5% wasted)
ANI objective1 with size 149x21 (34.4% wasted)
ANI energy1 with size 12x41 (35.9% wasted)
ANI targetview1 with size 137x156 (39.1% wasted)
ANI targetview2 with size 4x96 (25.0% wasted)
ANI targetview3 with size 7x20 (37.5% wasted)
ANI 2_radar1 with size 209x170 (33.6% wasted)
ANI 2_energy2_fs1 with size 85x96 (25.0% wasted)
ANI 2_reticle1_fs1 with size 40x24 (25.0% wasted)
ANI targhit1 with size 31x21 (34.4% wasted)
ANI 2_leftarc_fs1 with size 77x139 (45.7% wasted)
ANI 2_toparc1_fs1 with size 251x59 (7.8% wasted)
ANI 2_toparc2_fs1 with size 31x34 (46.9% wasted)
ANI 2_toparc3_fs1 with size 30x34 (46.9% wasted)
ANI netlag1 with size 29x30 (6.3% wasted)
ANI 2_lead1_fs1 with size 40x40 (37.5% wasted)
ANI 2_lock1_fs1 with size 46x46 (28.1% wasted)
ANI 2_lockspin_fs1 with size 51x51 (20.3% wasted)
ANI time1 with size 47x23 (28.1% wasted)
ANI 2_rightarc1_fs1 with size 79x139 (45.7% wasted)
ANI 2_rightarc4_fs1 with size 43x43 (32.8% wasted)
ANI 2_rightarc5_fs1 with size 43x43 (32.8% wasted)
ANI 2_rightarc6_fs1 with size 43x43 (32.8% wasted)
TBM  =>  Starting parse of 'mv_effects-str.tbm' ...
TBM  =>  Starting parse of 'str-str.tbm' ...
loading animated cursor "cursor"
ANI cursor with size 18x24 (25.0% wasted)
MediaVPs: Explosions script loaded!
MediaVPs: Flaming debris script loaded!
Ships.tbl is : INVALID!!!!
Weapons.tbl is : INVALID!!!!
cfile_init() took 671
TrackIR Init Failed - 1
Got event GS_EVENT_GAME_INIT (49) in state NOT A VALID STATE (0)
SOUND => Loading 'main_amb.wav'
SOUND ==> Converting sound from ADPCM to PCM
SOUND ==> Coverted sound from ADPCM to PCM successfully
PLR => Verifying 'DEBUG.plr' with version 0...
PLR => Parsing:  Flags...
PLR => Verifying complete!
PLR => Verifying 'Mike.plr' with version 0...
PLR => Parsing:  Flags...
PLR => Verifying complete!
PLR => Verifying 'MikeBTA.plr' with version 0...
PLR => Parsing:  Flags...
PLR => Verifying complete!
PLR => Verifying 'MikeJAD.plr' with version 0...
PLR => Parsing:  Flags...
PLR => Verifying complete!
PLR => Verifying 'MikeTEST.plr' with version 0...
PLR => Parsing:  Flags...
PLR => Verifying complete!
ANI cursor.ani with size 18x24 (25.0% wasted)
SOUND => Loading 'user_o.wav'
SOUND => Loading 'commit.wav'
Got event GS_EVENT_MAIN_MENU (0) in state GS_STATE_INITIAL_PLAYER_SELECT (37)
PLR => Loading 'Mike.plr' with version 0...
PLR => Parsing:  Flags...
PLR => Parsing:  Info...
PLR => Parsing:  Scoring...
PLR => Parsing:  ScoringMulti...
PLR => Parsing:  HUD...
PLR => Parsing:  Variables...
PLR => Parsing:  Multiplayer...
PLR => Parsing:  Controls...
PLR => Parsing:  Settings...
Someone passed an extension to bm_load for file 'GTI.pcx'
PLR => Loading complete!
CSG => Loading 'Mike.str.csg' with version 0...
CSG => Parsing:  Flags...
CSG => Parsing:  Info...
CSG => Parsing:  Missions...
CSG => Parsing:  Techroom...
CSG => Parsing:  Loadout...
CSG => Parsing:  Scoring...
CSG => Parsing:  RedAlert...

[attachment deleted by ninja]

[niffiwan]

Thanks for sending the pilot files.

Would you be able to add a comment to the mantis issue to describe what you were doing when the problem occurred?

[mjn.mixael]

Done'd

[Echelon9]

A means of fixing two of the PVS-Studio issues that were found in Antipodes is proposed below. On further inspection, this section of offending code is actually in trunk as well, just protected by the INF_BUILD setting.

Could those who know the multiplayer code, and in particular the methods used to size the network packets please review? This is important as I've changed the type from unsigned short (ushort) to integer (int). It looks like this was missed when the scoring.h structure elements were changed, as seen by the commented out lines.

Code: [Select]

False 1 9412 V568 It's odd that the argument of sizeof() operator is the '(ushort) sc->m_okKills [idx]' expression. code multimsgs.cpp 6478 False
False 1 9415 V568 It's odd that the argument of sizeof() operator is the '(ushort) sc->kills [idx]' expression. code multimsgs.cpp 6486 False


Code: [Select]

Index: code/network/multimsgs.cpp
===================================================================
--- code/network/multimsgs.cpp (revision 7797)
+++ code/network/multimsgs.cpp (working copy)
@@ -6475,7 +6475,7 @@
  ADD_SHORT(offset);
  for (idx=offset; idx<MAX_SHIP_CLASSES && idx<offset+MAX_SHIPS_PER_PACKET; idx++)
  {
- ADD_USHORT((ushort)sc->m_okKills[idx]);
+ ADD_INT(sc->m_okKills[idx]);
  }
  break;
 
@@ -6483,7 +6483,7 @@
  ADD_SHORT(offset);
  for (idx=offset; idx<MAX_SHIP_CLASSES && idx<offset+MAX_SHIPS_PER_PACKET; idx++)
  {
- ADD_USHORT((ushort)sc->kills[idx]);
+ ADD_INT(sc->kills[idx]);
  }
  break;
  }
@@ -6541,8 +6541,8 @@
  GET_SHORT(si_offset);
  for (idx = si_offset; idx<MAX_SHIP_CLASSES && idx<si_offset+MAX_SHIPS_PER_PACKET; idx++)
  {
- GET_USHORT(u_tmp);
- sc->kills[idx] = u_tmp;
+ GET_INT(i_tmp);
+ sc->kills[idx] = i_tmp;
  }
  break;
 
@@ -6550,8 +6550,8 @@
  GET_SHORT(si_offset);
  for (idx = si_offset; idx<MAX_SHIP_CLASSES && idx<si_offset+MAX_SHIPS_PER_PACKET; idx++)
  {
- GET_USHORT(u_tmp);
- sc->m_okKills[idx] = u_tmp;
+ GET_INT(i_tmp);
+ sc->m_okKills[idx] = i_tmp;
  }
  break;
 
Index: code/stats/scoring.h
===================================================================
--- code/stats/scoring.h (revision 7797)
+++ code/stats/scoring.h (working copy)
@@ -104,7 +104,6 @@
  int m_score;
  //ushort m_kills[MAX_SHIP_CLASSES];     // this will represent all kills in the mission (bonehead or not)
  int m_kills[MAX_SHIP_CLASSES]; //DTP max
- //ushort m_okKills[MAX_SHIP_CLASSES];   // this will be only the "valid" kills the player made
  int m_okKills[MAX_SHIP_CLASSES]; //DTP max
  int m_kill_count; // total kills for this mission
  int m_kill_count_ok;             // total (non-friendly) kills for this mission
@@ -119,7 +118,6 @@
  int m_player_deaths; // player deaths for the mission (really only useful for multiplayer)
 
  // kills by player for multiplayer dogfight
- //ushort m_dogfight_kills[MAX_PLAYERS];
  int m_dogfight_kills[MAX_PLAYERS];//DTP max
 
 } scoring_struct;

[attachment deleted by ninja]

[karajorma]

Could those who know the multiplayer code, and in particular the methods used to size the network packets please review?

Basically that means me!

I'm out of town at the moment and won't be back home until Wednesday. If you see me on IRC then, remind me.


EDIT : Checked it out, you're fine with regards to actually breaking the max packet length. One of the other other cases added 3 ints to the packet so changing from a ushort to 3 ints would be fine. The problem you're going to face is that this change does break compatibility for this particular packet. Which means that anyone playing antipodes 8 builds against with anything including this change will result in strange data for the kill counts.

For this reason changes like this usually get stored up and applied all at once. Although if no one actually uses antipodes for multiplayer there's no reason not to add them in now.

[Echelon9]

Could those who know the multiplayer code, and in particular the methods used to size the network packets please review?

Basically that means me!

I'm out of town at the moment and won't be back home until Wednesday. If you see me on IRC then, remind me.


EDIT : Checked it out, you're fine with regards to actually breaking the max packet length. One of the other other cases added 3 ints to the packet so changing from a ushort to 3 ints would be fine. The problem you're going to face is that this change does break compatibility for this particular packet. Which means that anyone playing antipodes 8 builds against with anything including this change will result in strange data for the kill counts.

For this reason changes like this usually get stored up and applied all at once. Although if no one actually uses antipodes for multiplayer there's no reason not to add them in now.

I've committed the fix to Antipodes branch, with a succinct comment in the SVN log to note that this will break multiplayer compatibility between SVN revisions.

[pecenipicek]

EDIT : Checked it out, you're fine with regards to actually breaking the max packet length. One of the other other cases added 3 ints to the packet so changing from a ushort to 3 ints would be fine. The problem you're going to face is that this change does break compatibility for this particular packet. Which means that anyone playing antipodes 8 builds against with anything including this change will result in strange data for the kill counts.

We're using Antipodes builds for TAP work, but we're generally always pushing for the whole team to have the most recent builds in anyhow, so i dont think that doing this kind of stuff would break anything drastically.



if we do encounter anything very much out of the ordinary, i'll mantis it.

[Echelon9]

We're using Antipodes builds for TAP work, but we're generally always pushing for the whole team to have the most recent builds in anyhow, so i dont think that doing this kind of stuff would break anything drastically.

if we do encounter anything very much out of the ordinary, i'll mantis it.

Thanks.

[niffiwan]

Crashing pilot file

The converter is asserting in debug when converting this pilot, I can't figure out why but maybe someone else can, if it crashes for them too.

I've just committed three patches that deal with various pilot conversion issues:

8002: Fixes an issue with converting the pilot file from this internal thread, I also fixed a number of similar errors in calling cfread_string_len, there's a few more of these in trunk that I still need to get rid of.

8003: Fixes an issue with converting the pl2 file from chief1983 (above)

8004: Fixes an issue with converting the Windmills.cs2 file from chief1983 (above)

I've tested these changes with the two pilot files already mentioned, plus a couple of test pilots of my own, further testing from anyone is appreciated!

[Zacam]

Awesome work there niffiwan. Thank you.

I still need to retest the conversion of Retail pilots to guard against people starting on the GOG version and then switching to the FSO version once I can confirm whether or not a problem actually exists.

[niffiwan]

Thanks Zacam.

I've found some more issues with the pilot conversions that I still need to take care of, at least one of the problems (viewed cutscenes get lost) is due to some of the changes I made (I think the cutscene data is being eaten by the read stats code).  So perhaps hold off on testing anything for now.

Most of this work so far has been about getting ready to tackle the retail to new-pilot-code conversion issue as I'm pretty sure at the moment it won't even attempt to convert from retail - you need to go retail to current-pilot-code (inferno or "standard"), then convert to the new-pilot-code format.

[Zacam]

...
I think the cutscene data is being eaten by the read stats code
...

If I'm not mistaken, pre-removal of the INF_BUILD had a define for stats based on whether or not it was an INF Build. You might want to take a look at pre-INF_BUILD removal to see if that structure for the stats makes any better sense for the pilot. I think we just went with removing the non-INF_BUILD version, but maybe that's a case we need to keep depending on the differences.