[Swifty]

Does it at least look okay when shadows are disabled? No problems with the deferred lighting?

[chief1983]

It does seem to be much improved.  I didn't see any artifacting on the hulls with shadows disabled.

[Echelon9]

Hello Swifty,
Sending you a code review comment, about stray variable clip_plane_equation added as part of the deferred lighting and soft shadows feature. See GitHub Issue#233.

[Familiar]

Hello everyone, I may be wrong, but this beauty is not included in 3.7.3 Nightlies yet? Latest shadow build is based on 3.7.1 in this thread, does someone has more recent one?
I'm asking just for gaming purpose, just finished (again) FSPort + ST:R + Frespace Blue + BP:AoA, now continuing on BP:WiH

Or I just dumb and there's an option to enable shadows in Nightly build?

Appreciate your answers, thank you in advance.

[The E]

Shadows are present in current nightlies, but have to be enabled manually. There should be an option to do so in the Launcher's graphics flags section.

[Familiar]

Shadows are present in current nightlies, but have to be enabled manually. There should be an option to do so in the Launcher's graphics flags section.

OMG I must be blind -enable_shadows flags, and it is in wx launcher options.
I tried only -shadow_quality 2, which had no warning of unrecognizable flag, but no shadows.

Thank you kind sir for the hint.

[Lykurgos88]

BTW, what is the value range of "-shadow_quality" parameter? I couldn't find any information in the "command-line reference" wiki page.

[Bryan See]

And what of the cockpit POFs? Will it be affected by deferred lighting and shadowing? I think not.

[Phantom Hoover]

-shadow_quality should be changed to implicitly include -enable_shadows when given a nonzero argument, though

[CountBuggula]

And what of the cockpit POFs? Will it be affected by deferred lighting and shadowing? I think not.

I just tested and sadly, cockpits aren't affected by this.  Shades only, no self-shadows.  The question is whether this was an oversight or deliberate due to technical constraints?

[DahBlount]

And what of the cockpit POFs? Will it be affected by deferred lighting and shadowing? I think not.

I just tested and sadly, cockpits aren't affected by this.  Shades only, no self-shadows.  The question is whether this was an oversight or deliberate due to technical constraints?

Technical constraints. iirc, something to do with rendering order or something like that.

[CountBuggula]

And what of the cockpit POFs? Will it be affected by deferred lighting and shadowing? I think not.

I just tested and sadly, cockpits aren't affected by this.  Shades only, no self-shadows.  The question is whether this was an oversight or deliberate due to technical constraints?

Technical constraints. iirc, something to do with rendering order or something like that.

Sadness.  Besides the obvious appeal of just seeing shadows from other items in the cockpit, showing your cockpit go dark when you passed under a massive Star Destroyer would be amazing.

[niffiwan]

BTW, what is the value range of "-shadow_quality" parameter? I couldn't find any information in the "command-line reference" wiki page.

Added

-shadow_quality should be changed to implicitly include -enable_shadows when given a nonzero argument, though

Good point, it'd be trivial to make this change & a good simple task for anyone wanting to code for FSO. You could even remove -enable_shadows entirely & let -shadow_quality control if shadows are enabled.

Anyway, if anyone is interested all the code for this is in code/cmdline/cmdline.cpp; around line 1742.

[Bryan See]

Excuse me, where can I get these built-in shader code for all of this?

[niffiwan]

Excuse me, where can I get these built-in shader code for all of this?

Have a look in code/globalincs/def_files.cpp.

[The E]

Good point, it'd be trivial to make this change & a good simple task for anyone wanting to code for FSO. You could even remove -enable_shadows entirely & let -shadow_quality control if shadows are enabled.

I don't think this is a good plan. Right now, non-boolean flags are not very well supported by the Launcher, moving a relatively important flag like this one outside of the main graphics features list will render it basically undiscoverable. I agree that letting shadow_quality act as another way to switch on shadows is a good idea, that should definitely be done, but let's keep enable_shadows around a while longer.

[Lykurgos88]

Added

Thanks! 

Would it be possible to offer an additional value of "3" corresponding 2048x2048 shadow maps?

[DahBlount]

Would it be possible to offer an additional value of "3" corresponding 2048x2048 shadow maps?

I don't think this is a good idea.

[Spoon]

Would it be possible to offer an additional value of "3" corresponding 2048x2048 shadow maps?

I don't think this is a good idea.

Why not? If people have pc's that can handle it then why not let them have it?

[The E]

Indeed.