[SirKnightly]

Here is the nightly for OS X on 06 Feb 2014 - Revision 10410

Group: Standard
fso-OSX-Standard-20140206_r10410.tgz
MD5Sum

Code: [Select]

------------------------------------------------------------------------
r10376 | The_E | 2014-01-31 11:38:31 -0600 (Fri, 31 Jan 2014) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/mission/missionmessage.cpp

Remove a pointless, :v: original assert (All ships should be able to send messages regardless of whether they're flyable; checking whether they are accomplishes literally nothing)

------------------------------------------------------------------------
r10377 | karajorma | 2014-02-01 06:27:51 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

There was some confusion about the old help text.
------------------------------------------------------------------------
r10378 | Echelon9 | 2014-02-01 16:05:47 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/weapon/weapons.cpp

Fix Mantis 2997: Make +Bitmap a required table item if a weapon trail has been set
------------------------------------------------------------------------
r10379 | Echelon9 | 2014-02-01 16:19:18 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/.gitignore

Expand the .gitignore exclusions to cover modern Xcode project local files. Based off StackOverflow suggestions as documented.
------------------------------------------------------------------------
r10380 | Echelon9 | 2014-02-01 16:27:45 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/model.h

Fix Coverity 1093859: Uninitialized scalar field In mst_info::​mst_info(): A scalar field is not initialized by the constructor (CWE-457). From Flaming_Sword.
------------------------------------------------------------------------
r10381 | Echelon9 | 2014-02-01 16:29:24 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelanim.cpp

Fix Coverity 1093669 Out-of-bounds access: In triggered_rotation::add_queue(queued_animation *, int): Out-of-bounds access to a buffer (CWE-119). From Flaming_Sword.
------------------------------------------------------------------------
r10382 | Echelon9 | 2014-02-01 16:31:02 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelcollide.cpp

Fix Coverity 1093413 Logically dead code: In model_collide_sub(void *): Code can never be reached because of a logical contradiction (CWE-561). From Flaming_Sword.
------------------------------------------------------------------------
r10383 | Echelon9 | 2014-02-01 16:32:19 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelinterp.cpp

Fix Coverity 1093728 Allocation size mismatch: In model_allocate_interp_data(int, int, int): Allocation size is not a multiple of the target pointer's pointed-to type (CWE-131). From Flaming_Sword.
------------------------------------------------------------------------
r10384 | Echelon9 | 2014-02-01 16:33:44 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelread.cpp

Fix Coverity 1093455 Dereference after null check: In read_model_file(polymodel *, char *, int, model_subsystem *, int): Pointer is checked against null but then dereferenced anyway (CWE-476). From Flaming_Sword.
------------------------------------------------------------------------
r10385 | Echelon9 | 2014-02-01 16:34:58 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/collideweaponweapon.cpp

Fix Coverity 1107319 Copy-paste error: In collide_weapon_weapon(obj_pair *): A copied piece of code is inconsistent with the original (CWE-398). From Flaming_Sword.
------------------------------------------------------------------------
r10386 | Echelon9 | 2014-02-01 16:36:28 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/objcollide.cpp

Fix Coverity 1102734 Uninitialized scalar field: In collider_pair::collider_pair(): A scalar field is not initialized by the constructor (CWE-457). From Flaming_Sword.
------------------------------------------------------------------------
r10387 | Echelon9 | 2014-02-01 16:38:07 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/object.cpp

Fix Coverity 1129278 Uninitialized scalar field: In object::object(): A scalar field is not initialized by the constructor (CWE-457). From Flaming_Sword.
------------------------------------------------------------------------
r10388 | Echelon9 | 2014-02-01 16:39:33 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/objectsnd.cpp

Fix Coverity 1093392 Logically dead code: In obj_snd_assign(int, int, vec3d *, int, int, ship_subsys *): Code can never be reached because of a logical contradiction (CWE-561). From Flaming_Sword.
------------------------------------------------------------------------
r10389 | Echelon9 | 2014-02-01 16:40:43 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelinterp.cpp

Fix Coverity 1093407 Logically dead code: In model_interp_sub(void *, polymodel *, bsp_info *, int): Code can never be reached because of a logical contradiction (CWE-561). From Flaming_Sword.
------------------------------------------------------------------------
r10390 | Echelon9 | 2014-02-01 16:43:10 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/object/objectsnd.cpp

Fix Coverity 1093446 Dereference after null check: In obj_snd_stop_all(): Pointer is checked against null but then dereferenced anyway (CWE-476). From Flaming_Sword.
------------------------------------------------------------------------
r10391 | Echelon9 | 2014-02-01 16:44:49 -0600 (Sat, 01 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/model/modelcollide.cpp

Fix Coverity 1093576 Improper use of negative value: In model_collide_flatpoly(unsigned char *): Negative value can be returned from function is not being checked before being used improperly (CWE-394). From Flaming_Sword.
------------------------------------------------------------------------
r10392 | m_m | 2014-02-02 06:13:08 -0600 (Sun, 02 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ai/aicode.cpp

Fix for Coverity 1107329: Improper use of negative value
------------------------------------------------------------------------
r10393 | m_m | 2014-02-02 06:14:11 -0600 (Sun, 02 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/missionui/redalert.cpp

Fix for Coverity 1147623: Out-of-bounds access
------------------------------------------------------------------------
r10403 | karajorma | 2014-02-03 21:44:15 -0600 (Mon, 03 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/parse/sexp.cpp

If we've already written the content of CTEXT(n) to a variable, we should use that, rather than calling CTEXT(n) 500+ times.
------------------------------------------------------------------------
r10404 | Goober5000 | 2014-02-05 19:52:30 -0600 (Wed, 05 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/mission/missionparse.cpp

only warn once, because old missions tended to have a *lot* of these broken +Team values
------------------------------------------------------------------------
r10405 | Goober5000 | 2014-02-05 19:55:56 -0600 (Wed, 05 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

wing names with the hash at the beginning aren't subject to the name bashing
------------------------------------------------------------------------
r10406 | Goober5000 | 2014-02-05 20:58:49 -0600 (Wed, 05 Feb 2014) | 2 lines
Changed paths:
   M /trunk/fs2_open/code/hud/hudsquadmsg.cpp

following up from r10000 and r10004, fix the hud squad message display for support ship aborts
(and in the process optimize things slightly)
------------------------------------------------------------------------
r10407 | Goober5000 | 2014-02-05 22:07:11 -0600 (Wed, 05 Feb 2014) | 1 line
Changed paths:
   M /trunk/fs2_open/code/ship/ship.cpp

Mantis #3004: ship_get_ship_with_dock_bay was written in such a way that it allowed a negative array index to create all sorts of havoc
------------------------------------------------------------------------