Author Topic: Why can't ships launch from a player ship?  (Read 1355 times)

0 Members and 1 Guest are viewing this topic.

Offline General Battuta

  • Poe's Law In Action
  • 214
  • i wonder when my postcount will exceed my iq
Why can't ships launch from a player ship?
If the player ship has a fighterbay, wings don't seem to be able to arrive from it. Y not

 

Offline zookeeper

  • *knock knock* Who's there? Poe. Poe who?
  • 210
Re: Why can't ships launch from a player ship?
Ohh, interesting. I only took a brief look, but as far as I can tell...

mission_did_ship_arrive() and mission_do_departure() use mission_parse_get_arrival_ship() to find the anchor ship. But, that function searches Ship_arrival_list, which won't contain the player ship because the player ship never arrives. Why it searches that list and how does it ever find anchor ships which don't arrive but are in the mission from the beginning, I don't know. But maybe that helps someone else in finding the problem, if it's something else after all.

 

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
Re: Why can't ships launch from a player ship?
And the reason why this happened was that the player ship(s) were always kept on the arrival list in order to make multiplayer respawns work. I've created a pull request that fixes this.

This fix only affects single player behaviour, multi is unchanged.
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns

 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: Why can't ships launch from a player ship?
Yeah, I'm not so sure I like that. Why not fix it so that this works in multi and singleplayer by adding a check to the actual arrival and departure functions?
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]

 

Offline The E

  • He's Ebeneezer Goode
  • Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
Re: Why can't ships launch from a player ship?
I've made an amendment.
If I'm just aching this can't go on
I came from chasing dreams to feel alone
There must be changes, miss to feel strong
I really need lifе to touch me
--Evergrey, Where August Mourns