Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: m!m on November 11, 2011, 12:56:40 pm

Title: Patch: Custom ship explosion sound
Post by: m!m on November 11, 2011, 12:56:40 pm

The attached patch adds a "$ExplosionSnd" ship class option after "$CargoScanningSnd" to specify a ship specific explosion sound.

Regards,
m!m

[attachment deleted by a basterd]

Title: Re: Patch: Custom ship explosion sound
Post by: Zacam on November 13, 2011, 03:47:15 am

Why not propagate it near/with the customizable Death/Explosions entries that Wanderer put in? Would make more sense there I'd think unless we're just grouping (or attempting to) all sound related elements together.

Title: Re: Patch: Custom ship explosion sound
Post by: m!m on November 13, 2011, 05:29:23 am

I thought grouping the sound related entries would be the best way to do it as then the parse function can also be put into the dedicated parse_ship_sounds function.

Title: Re: Patch: Custom ship explosion sound
Post by: torc on November 15, 2011, 05:03:44 pm

Sorry if i bump this thread, but should some coder take a look at it please?

This code can solve me a huge sound issue.

Thanks in advance for the help...hope to don't bother you :)

Title: Re: Patch: Custom ship explosion sound
Post by: Eli2 on November 16, 2011, 08:40:56 am

The patch looks good, one idea thou.

Would it be possible to do the selection of the explosion sound when parsing the ship.
and add the mapping from SND_SHIP_EXPLODE_1 to SND_CAPSHIP_EXPLODE or SND_SHIP_EXPLODE_2 there ?

You could remove the ship_has_sound function then.

Title: Re: Patch: Custom ship explosion sound
Post by: JCDNWarrior on November 16, 2011, 08:53:37 am

Sounds like a good patch, if it works well I'll definitely experiment with that. Would be great to give Shivan ships a much different, alien sound when their ships explode, for instance.

Title: Re: Patch: Custom ship explosion sound
Post by: m!m on November 19, 2011, 12:53:17 pm

Sorry to :bump: but
I had a talk with Eli2 on IRC about this patch but we didn't come to a satisfying solution for the mostly redundant ship_has_sound function which doesn't break backwards compatibility. Can somebody take a look?

Title: Re: Patch: Custom ship explosion sound
Post by: karajorma on November 19, 2011, 06:49:03 pm

Why is ship_has_sound() redundant?

Title: Re: Patch: Custom ship explosion sound
Post by: m!m on November 20, 2011, 02:13:14 am

It only differs in two line from ship_get_sound() but I think it's the only way.

Title: Re: Patch: Custom ship explosion sound
Post by: m!m on January 15, 2012, 09:58:09 am

:bump: ing again but the attachment in the first post got deleted. I'd really appreciate a review of the patch as it could be really helpful :nod:

[attachment deleted by a ninja]

Title: Re: Patch: Custom ship explosion sound
Post by: torc on January 22, 2012, 06:56:02 am

hello.... sorry about re-bumping,but the review of this patch would be great....thanks for the help.

Title: Re: Patch: Custom ship explosion sound
Post by: assasing123 on February 17, 2012, 02:10:57 pm

i agree too, this could be quite usefull. so bump