[SirKnightly]

Here is the nightly for 13 February 2018 - Revision a0a8812

At least one of the nightly builds failed!


Group: MacOSX
nightly_20180213_a0a8812-builds-MacOSX.tar.gz (Mirror)


Group: Linux
nightly_20180213_a0a8812-builds-Linux.tar.gz (Mirror)


Group: Win64
nightly_20180213_a0a8812-builds-Win64.zip (Mirror)

Code: [Select]

------------------------------------------------------------------------
commit 6fad19c
Author: Fabian Woltermann <Mon Feb 12 10:40:56 2018 +0100>
Commit: Fabian Woltermann <Mon Feb 12 10:40:56 2018 +0100>

    More changes requested by CI
 code/lighting/lighting.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

------------------------------------------------------------------------
commit 119b5d6
Author: Fabian Woltermann <Mon Feb 12 08:57:39 2018 +0100>
Commit: Fabian Woltermann <Mon Feb 12 08:57:39 2018 +0100>

    Addressing feedback and CI issues
 code/graphics/opengl/gropengldeferred.cpp | 4 ++--
 code/graphics/shadows.cpp                 | 4 +---
 code/model/modelrender.cpp                | 2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)

------------------------------------------------------------------------
commit 0b612c2
Author: Fabian Woltermann <Sat Feb 10 14:20:45 2018 +0100>
Commit: Fabian Woltermann <Sat Feb 10 14:20:45 2018 +0100>

    Remove an unused #define
 code/globalincs/systemvars.h | 1 -
 code/lighting/lighting.cpp   | 3 ---
 code/lighting/lighting.h     | 2 --
 3 files changed, 6 deletions(-)

------------------------------------------------------------------------
commit 8aee62b
Author: Fabian Woltermann <Sat Feb 10 14:09:32 2018 +0100>
Commit: Fabian Woltermann <Sat Feb 10 14:09:32 2018 +0100>

    Make sure directional lights are always rendered; this kinda spiralled out into a bit of general cleanup regarding the lighting code.
 code/graphics/light.cpp                   |  60 ++--
 code/graphics/opengl/gropengldeferred.cpp |  77 ++---
 code/graphics/shadows.cpp                 |  14 +-
 code/lighting/lighting.cpp                | 451 +++++++++++-------------------
 code/lighting/lighting.h                  |   2 +-
 code/model/modelrender.cpp                |   6 +-
 code/model/modelrender.h                  |   2 +-
 7 files changed, 229 insertions(+), 383 deletions(-)


[Makhpella]

Meant to post this yesterday. Uhm, my game crashes whenever I view a ship in the F3 menu. Posting here because I hadn`t started FSO in a while, so I only noticed with this build, but I can check other builds if you want. Also happens with the February 14th build. Attached log.

[attachment stolen by Russian hackers]

[AdmiralRalwood]

Meant to post this yesterday. Uhm, my game crashes whenever I view a ship in the F3 menu. Posting here because I hadn`t started FSO in a while, so I only noticed with this build, but I can check other builds if you want. Also happens with the February 14th build. Attached log.

Code: [Select]

Int3(): From C:\projects\fs2open-github-com\code\graphics\light.cpp at line 141
Something asked the lighting code to create a light with a nonexistant type. This obviously shouldn't happen; unfortunately, this log is insufficient, by itself, to determine what the problem is. Someone will need to do more involved debugging. As it happens, this nightly was when some changes to the lighting code were introduced, so it would be helpful if you could confirm that the problem doesn't occur in the previous nightly, as that would narrow down which changes were at fault very quickly.

[Makhpella]

Checked the 9th, 10th, and 11th builds, and they`re ok. With 14th I can view the models in the tech room just fine, I can play missions just fine, it`s just the ship lab that crashes.

[The E]

Incidentally, this is something that's fixed not happening in the new lab code. A more specific fix can be found here.

[m!m]

I cannot reproduce this bug with the current master version (which is the same as the newest nightly). What steps do you need to do to cause this issue? It would also be helpful to know if this happens only with one mod or all mods.

Since it will be fixed in the new lab code it's not a high priority to fix this now but I would still like to know what exactly caused this in case there is a bigger issue somewhere else.

[Makhpella]

Not doing anything out of the ordinary. Just starting FSO, entering the lab, choosing a model and it dies. I checked with BP, BTA, and FS2.
I tried to see if it`s caused by any of my usual render options (thrusters, rotate systems, full detail), which I sometimes checked before loading a model, but that was a nope.
Going to check 15th now.

Edit: It`s still there. Interestingly, it usually crashed instantly, but I loaded up BP`s Morena, and it actually let me rotate it for a few seconds before crashing. Only the first time, though. I tried disabling the Launcher graphics options, didn`t do a thing. Loaded SG as well, it just crashes as soon as the model loads.

Adding today`s log, just in case.

[attachment stolen by Russian hackers]