Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: m!m on June 29, 2018, 10:42:38 am

Title: Lighting settings in game_settings.tbl
Post by: m!m on June 29, 2018, 10:42:38 am
I just submitted some changes (https://github.com/scp-fs2open/fs2open.github.com/pull/1770) which would allow a mod to specify the lighting settings in the mod table. Before that gets merged I would like to let everyone know that this pull request exists in case someone has something to say about the general idea of this feature.
Title: Re: Lighting settings in game_settings.tbl
Post by: The E on June 29, 2018, 12:35:45 pm
One issue is definitely clear: Since we've treated those lighting settings as user input exclusively so far, user input should retain priority over game_settings definitions (this post is written quickly, off the cuff and without checking whether we parse cmdline options before or after game_settings)
Title: Re: Lighting settings in game_settings.tbl
Post by: chief1983 on June 29, 2018, 02:41:57 pm
Why should we not give a mod the ability to lock down the settings a bit?  Yes we gave users that ability so they could experiment and find things that worked, but for a mod like Windmills it is absolutely critical that it be played with very specific lighting settings, and if we could bundle those with the mod via a table, and prevent user override additionally, I can't see any reason why that wouldn't be preferred.  I just feel that if a mod wants to go to the extent of developing very specific lighting settings critical to the mood, etc, the user shouldn't just be able to easily override those because they're used to being able to do so.  I don't think anyone would be upset if a mod going forward prevented that, and if so they could take it up with the modder.
Title: Re: Lighting settings in game_settings.tbl
Post by: The E on June 29, 2018, 04:42:08 pm
There is probably a middle ground there. Let mods define a min, max and default value and clamp the user preference to that if it exists.
Title: Re: Lighting settings in game_settings.tbl
Post by: m!m on June 29, 2018, 05:18:18 pm
For the first question, yes the game_settings values override whatever the user specified.

I guess I could add a range feature. That shouldn't be hard to implement.

EDIT: I have implemented the requested range feature in the changes I linked to above.
Title: Re: Lighting settings in game_settings.tbl
Post by: AdmiralRalwood on June 29, 2018, 06:37:35 pm
There is probably a middle ground there. Let mods define a min, max and default value and clamp the user preference to that if it exists.
This was the only suggestion I was gonna make. Looks good... or, well, wait, it looks like the default value is missing?

It seems to accept either a range or an override value, with no option to set a different default than the normal (beyond implicitly through the range clamping the regular default).
Title: Re: Lighting settings in game_settings.tbl
Post by: m!m on June 29, 2018, 06:39:44 pm
Well, that proves that coding while being hungry does not work :nervous:
I'll fix it later.