[Zacam]

I can't imagine an extra calculation is that big of a deal in debug just during load.

Depends on what is being calculated. Full CRC enumeration on the VP's for example (as a default without having to run -verify_vps) adds quite a lot.

[KeldorKatarn]

Well this isn't a big calculation. It is just a few time dereferencing values plus comparing them. That's all.

To get back to topic: Can this please be added to trunc? It will greatly improve the usefulness of the debug build for checking a model's correctness.
Since we've recently started to give all our capital ships mesh shields we could really use this

[portej05]

I'm OK with committing this, as long as:
1) Debug code remains in an ifdef _DEBUG or ifndef NDEBUG (i.e. debug builds are for debugging)
2) Someone can confirm that these warnings are not a nuisance with model data outside of that which KK is using
3) Some check to ensure that warnings are only shown once per model - it would be bloody irritating to see 6 warnings per model.

Patch doesn't look too bad.

[KeldorKatarn]

3) probably needs to be fixed but that will be easy with setting a local bool per model and setting that one to true once a warning has been shown.

On the other hand I'd consider making this an error instead of a warning. This is not something that will simply lead to strange effects in the game, like a missing texture,
but instead will always lead to a crash sooner or later. So a model with faults like this should never be loaded actually.

[Tolwyn]

I tend to agree that the shield checking code is necessary - just imagine the nightmare of hunting down a CTD issue after the release. I used the model in question in quite a few missions, yet I did not experience any crashes.

[portej05]

The checking code has been committed.
I used KKs checking code, but replaced Warning with 'Error'.

[KeldorKatarn]

Thanks

[Tolwyn]

The checking code has been committed.
I used KKs checking code, but replaced Warning with 'Error'.

Thanks a bunch.