Author Topic: [Patch] Improved "delete pilot"-warning  (Read 1412 times)

0 Members and 1 Guest are viewing this topic.

[Patch] Improved "delete pilot"-warning
I just deleted a false pilot by accident  :(
To prevent this type of accident in future, I created a patch that adds the pilot's name to the warning message. It's now "Are you sure you wish to delete the pilot 'Pilot Name'?"

I hope this will be useful.
-DerKuchen

[attachment deleted by admin]

 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: [Patch] Improved "delete pilot"-warning
Hmmmm, one thing I don't like is that you seem to have removed the use of XSTR() which basically means that the line won't translate for versions of the game running in other languages. Which basically means that sooner or later someone is going to file that as a bug.
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]

 
Re: [Patch] Improved "delete pilot"-warning
I had to change the string, so I think XSTR won't find the correct translation.
Maybe the string could be the old string with the pilot names just added... e.g. "Are you sure you wish to delete this pilot? (Pilot Name)"
Or is there a possibility to add new translations?

Edit: Here's the new patch, now with properly translated messages.

[attachment deleted by admin]
« Last Edit: July 02, 2008, 05:43:04 am by DerKuchen »

 
Re: [Patch] Improved "delete pilot"-warning
Any update on this?

 

Offline karajorma

  • King Louie - Jungle VIP
  • Administrator
  • 214
    • Karajorma's Freespace FAQ
Re: [Patch] Improved "delete pilot"-warning
The thing I'm wondering about now is what will happen to that trailing argument if the XSTR converts the string to one which doesn't contain a %s (Which I presume the French and Germans ones don't). If the game just discards it without error I'll add this now. :)
Karajorma's Freespace FAQ. It's almost like asking me yourself.

[ Diaspora ] - [ Seeds Of Rebellion ] - [ Mind Games ]

 
Re: [Patch] Improved "delete pilot"-warning
There are no problems with German umlauts (I'm using a German client), I think French special characters should work as well.