Hard Light Productions Forums

Community Projects => The FreeSpace Upgrade Project => Topic started by: 0rph3u5 on June 06, 2021, 07:18:50 am

Title: Shivan Comm Node - problems with subobject deletion via SEXP
Post by: 0rph3u5 on June 06, 2021, 07:18:50 am

I have this visual I've found years back. The missions it would have appeared in all fell victim to other circumstances.
But I though I get it out of the mothballs for reason that are non of your buisness. Actually with FSO 21.0.0, I though I could at least ditch having an additional asset around that needs to managed.

Except when I put it through the test on a recent-ish Nightly (20210601) it didn't work - I rolled the Shivan Comm Node back to the retail asset, ran the same SEXP again and it worked.

Please compare the left and middle segments of the following image to see the results:

(https://media.discordapp.net/attachments/797458611298107392/851068114536103976/sigh0594.png?width=1440&height=266)

I adjusted the event to account for the addition of the MVP-exclusive "piece-outer4a" suboject/subsystem:

Code: [Select]

$Formula: ( when
   ( true )
   ( ship-subsys-no-replace
      "Shivan Comm Node 2"
      ( true )
      "core"
      "piece4a"
      "piece-outer4a"
   )
   ( ship-subsys-vanish
      "Shivan Comm Node 2"
      ( true )
      "core"
      "piece4a"
      "piece-outer4a"
   )
   ( destroy-subsys-instantly
      "Shivan Comm Node 2"
      "core"
      "piece4a"
      "piece-outer4a"
   )
)
+Name: no-crystal-node
+Repeat Count: 1
+Interval: 1
But the intended result was not produced (see above on the right).

Of course, I had to a look at mv_assets_s-shp.tbm. And I am not quite sure what about it is breaking the SEXP:

Code: [Select]

$Subsystem: piece-outer4a, 0.0, 0.0
$Flags: ( "ignore if dead" "damage as hull" "no aggregate" "no disappear" "allow destroyed rotation" "untargetable" )
Considering it is the FSU who are responsible for this happening, it is only fair to get you involved in fixing it.

EDIT: Debug log; the debug build processes the event with any comment:
https://fsnebula.org/log/60bcbe2ad424e511af391314

Title: Re: Shivan Comm Node - problems with subobject deletion via SEXP
Post by: Goober5000 on June 06, 2021, 01:41:48 pm

It looks as if this was done to prevent the outer arms from rotating around a nonexistent center.  And separately, piece4a was split into an outer and inner piece, and "piece4a" was made a subsystem.  And they now have destroyed submodel versions as well.

I tried turning piece-inner4a into a subsystem and giving it the "no replace" flag, but that didn't work.  We'll need one of the FSU modders to chime in.