Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Nightly Builds => Topic started by: SirKnightly on July 18, 2009, 12:13:11 pm

Title: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: SirKnightly on July 18, 2009, 12:13:11 pm
Here is the nightly for Windows on 18 Jul 2009 - Revision 5452

fso-WIN-20090718_r5452.7z (http://swc.fs2downloads.com/builds/WIN/fso-WIN-20090718_r5452.7z)
MD5Sum (http://swc.fs2downloads.com/builds/WIN/fso-WIN-20090718_r5452.md5)

Code: [Select]
------------------------------------------------------------------------
r5452 | karajorma | 2009-07-17 16:18:22 -0500 (Fri, 17 Jul 2009) | 1 line
Changed paths:
   M /trunk/fs2_open/code/fred2/fred.rc
   M /trunk/fs2_open/code/fred2/initialstatus.cpp
   M /trunk/fs2_open/code/fred2/initialstatus.h
   M /trunk/fs2_open/code/fred2/missionsave.cpp
   M /trunk/fs2_open/code/fred2/resource.h
   M /trunk/fs2_open/code/mission/missionparse.cpp
   M /trunk/fs2_open/code/ship/ship.h

GUI and mission saving stuff for Chief's Force-Shields-On Parse flag.
------------------------------------------------------------------------


Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: Rodo on July 19, 2009, 10:38:31 am
ok.. so I was playing bp-22 (last mission of Blue planet) and I got some problems about the red alert carry status, so I figured I was gonna check that out... in the process I found something else, some kind of weird error in the message part (written in screen).

Don't know if this has been always like this, but when you place a long message the game crashes, I made a test mission that crashes when loading the message, and the bp mission has another issue, it doesn't show the name of the ship that's sending the message.

I edited this in fred and no warning came up so I guess this might be a build problem (I think in previous version fred warned about long messages but I'm not sure).

- Tested in R 5452 AND in RC3 and both crash with this mission (http://www.filefront.com/14075707/test.fs2)

- Tested same thing on bp mission here (http://www.filefront.com/14075837/BP_mission.fs2) and in the dialogue lines of the "shuttle" you'll see the name is missing, I was not able to replicate this on my own mission. (you'll need the BP files for this one.. sorry).

-Tested on Mediavps and retail (without mods) and both crashed.

specs:
C:\Games\FreeSpace2\fs2_open_3_6_11r-20090718_r5452.exe -spec -glow -env -mipmap -nomotiondebris -noscalevid -missile_lighting -normal -3dshockwave -cache_bitmaps -dualscanlines -targetinfo -orbradar -rearm_timer -ballistic_gauge -ship_choice_3d -weapon_choice_3d -3dwarp -warp_flash -snd_preload  -ambient_factor 50 -spec_exp 11 -spec_point .6 -spec_static 1 -spec_tube .5 -ogl_spec 82 -fov .88


Sorry for not uploading this to mantis, still can't get my account validated  :(
Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: portej05 on July 19, 2009, 11:01:42 am
Cheers for the bug report.
You can blame this on line 711 of hudmessage.cpp. Doesn't correctly handle the case when split_str_once returns the passed pointer when the str pointer points to something too long.
I don't really know how to fix this one.
Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: captain-custard on July 19, 2009, 04:48:28 pm
Cheers for the bug report.
You can blame this on line 711 of hudmessage.cpp. Doesn't correctly handle the case when split_str_once returns the passed pointer when the str pointer points to something too long.
I don't really know how to fix this one.

how about the message is shortened ?
Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: portej05 on July 21, 2009, 08:58:58 am
Hi Folks,

Would you guys please test the attached build - it's got a fix for Rodos problem.
FS2ReleaseExe (http://porteous.no-ip.org/FS2Files/LongHUDMessageFix/fs2_open_3_6_11r.exe)
Patch (http://porteous.no-ip.org/FS2Files/LongHUDMessageFix/LongHUDMessageFix.patch)

That said, you shouldn't have a single word that is going to span the entire width of the screen... This is an edge case the code wasn't designed or tested for.
Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: chief1983 on July 21, 2009, 10:44:01 am
What a quaint little patch.
Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: The E on July 21, 2009, 10:49:29 am
There is still a bug in there that causes some strings to not be displayed. An example can be found in BP's last mission, where messages from Admiral Bei's shuttle are displayed without the "Admiral Bei:" part.

Diisregard that, seems to be an issue with the mission.
Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: Rodo on July 21, 2009, 11:00:38 am
will also test when back at home, tnks portej.

EDIT: works just fine :D
Title: Re: Nightly (Windows): 18 Jul 2009 - Revision 5452
Post by: chief1983 on July 22, 2009, 10:47:00 am
That's been committed, it's in the latest Windows nightly build.