[crizza]

Sry for bugging, but does anyone happen to have the files? The DL-link is dead

[Toranks]

4º missions, Into the Fire, have a bug and can't load. The solution is change on FH2261_04.fs2 mission file:

Code: [Select]

$Formula: ( every-time-argument
   ( random-multiple-of
      "exp04.eff"
      "exp06.eff"
      "exp20.eff"
      "exp05.eff"
      "P_moon4"
      "P_moon4"
      "P_moon4"
   )
   ( true )
   ( modify-variable
      @bank[0]
      ( rand-multiple 0 359 )
   )
   ( modify-variable
      @heading[0]
      ( rand-multiple 0 359 )
   )
   ( modify-variable
      @Pitch[0]
      ( rand-multiple 0 359 )
   )
   ( modify-variable
      "@eff[<Default Value>]"
      <argument>
   )
   ( modify-variable
      @Size[15]
      ( rand-multiple 8 26 )
   )
)
      <argument> with "<argument>"

Code: [Select]

   ( modify-variable
      "@eff[<Default Value>]"
      "<argument>"
   )
I have no knowledge of code, I have found the solution by loading the mission in FRED, saving, and checking the changes with a text matcher

Bug report:
https://fsnebula.org/log/62c4e719e83d03e719f3407e

WARNING: "Error in mission event: "Explosions Random": Not a number.
(Bad node appears to be: <argument>)

[Toranks]

Same error on 6º mission, and same fix, change all <argument> with "<argument>" on FH2261_06.fs2

Code: [Select]

$Formula: ( when
   ( and
      ( not
         ( is-disabled-delay
            0
            "EAS Charlemagne"
         )
      )
      ( >
         ( mission-time )
         ( + @HarvesterGun[0] 9 )
      )
      ( are-waypoints-done-delay
         "Harvester"
         "Harvester Engines"
         0
      )
   )
   ( when-argument
      ( random-multiple-of
         "engine01"
         "engine02"
         "engine03"
         "engine04"
      )
      ( true )
      ( modify-variable
         "@Target[engine01]"
         <argument>
      )
   )
   ( when-argument
      ( random-multiple-of
         "turret03-base"
         "turret08-base"
      )
      ( = @HarvesterSide[0] 0 )
      ( modify-variable
         "@Turret[turret03-base]"
         <argument>
      )
   )
   ( when-argument
      ( random-multiple-of
         "turret13-base"
         "turret20-base"
      )
      ( = @HarvesterSide[0] 1 )
      ( modify-variable
         "@Turret[turret03-base]"
         <argument>
      )
   )
   ( every-time
      ( not
         ( is-subsystem-destroyed-delay
            "EAS Charlemagne"
            "@Target[engine01]"
            1
         )
      )
      ( fire-beam
         "Harvester"
         "@Turret[turret03-base]"
         "EAS Charlemagne"
         "@Target[engine01]"
      )
      ( modify-variable
         @HarvesterGun[0]
         ( mission-time )
      )
   )
)

[0rph3u5]

WARNING: "Error in mission event: "Explosions Random": Not a number.
(Bad node appears to be: <argument>)

Needs to be

Code: [Select]

"<argument>" if the variable is a string variable.

[Toranks]

WARNING: "Error in mission event: "Explosions Random": Not a number.
(Bad node appears to be: <argument>)

Needs to be

Code: [Select]

"<argument>" if the variable is a string variable.

Thanks, this works too

[Vidmaster]

Okay, this is interesting. M4 has a super-duper hack-y SEXP to spawn explosions around the player, simulating a bigger and more exciting battle than the game's balancing (particular the capship speed) can actually visually produce. It is absolutely possible that what we did back in the day is highly illegal in newer versions of FSOpen. As I wrote in the other thread, all I can say is that it did work at some point (half a lifetime ago). I do not even remember the details of this particular function anymore, I recall only discussing how to realize this with FUBAR-BHDR.
M6 on the other hand is the assault on the Earth Alliance Base, where the Harvester is supposed to kill the engines of that carrier with its beams. I vividly remember the existance of a problematic bug in this mission but do not remember what exactly it was. Also, since I lacked the wisdom of proper versioning back in the day, there is no way to know what file you actually have. However, having an actual SEXP crash is something I do not remember, so that is that.

So, as before: Do all the changes you want, all of my TBP-work is in the community-domain. That includes fix-releases, re-releases, re-mixes, fixing the spelling errors and other stuff as long as you include the original credits.

[Vidmaster]

Gosh, that OP of the thread is embarrasing.
Cringeworthy.
Terrible.
I was young and stupid.

Why people play these campaigns and consider them worthwhile is beyond me.

[0rph3u5]

It is absolutely possible that what we did back in the day is highly illegal in newer versions of FSOpen. As I wrote in the other thread, all I can say is that it did work at some point (half a lifetime ago). I do not even remember the details of this particular function anymore, I recall only discussing how to realize this with FUBAR-BHDR.

It is not illegal in modern FSO, it should still work if correctly implimented.

The issue here comes from a bug fix to the modify-variable SEXP that was implimented a while ago. Basically, the SEXP used to not properly distinguish between Number and String variable types if you did not double check the input. Now that should happen automatically.