Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Goober5000 on January 08, 2003, 11:46:17 pm

Title: Thruster Bug Fixed
Post by: Goober5000 on January 08, 2003, 11:46:17 pm

I'm posting this as a new topic, because I'd like some opinions.  I'm a bit ambivalent about the result - it looks almost the same as the original effect.  See for yourselves if you want - I've linked a fixed build below.  Does somebody want to post screenshots and see if there's any difference now?  I'm inclined to just comment back in the original code, if there's not much difference.  Bobboau, why did you change the thruster glow this way in the first place?

http://fs2source.warpcore.org/exes/thrusters_fixed.zip

Title: Thruster Bug Fixed
Post by: Inquisitor on January 09, 2003, 08:31:15 am

I'd also like to poiint out th at Goober is using bugzilla the right way :)

Title: Thruster Bug Fixed
Post by: Bobboau on January 09, 2003, 10:20:38 am

was it the code that multiplied the size of the glow by it's direction and the thrus for that direction?
well that was to give ships that had thrusters pointing in diferent directions go off in proportion to how fast the are accelerating in a direction and how much the thruster was pointing in that direction

Title: Thruster Bug Fixed
Post by: Goober5000 on January 09, 2003, 10:52:36 am

Bugzilla is fun. :) :nod:

Yeah, but the problem was, that was what caused the huge glows.

The engine normals on MODded ships all had wildly different values, and the only way to standardize them was to normalize the vector.  But what normalization does is transform the original vector into a unit vector (magnitude 1) that points in the same direction.  Since engine glow strength is determined by magnitude, the vector itself didn't matter.

When the code was all fixed, it became just a fancy way of doing the exact same thing as it originally did. ;) That's why I'm wondering about changing it back.

Title: Thruster Bug Fixed
Post by: Sesquipedalian on January 09, 2003, 05:43:40 pm

That exe is giving some wierd graphics problems.

(http://www.3dap.com/hlp/hosted/scroll/misc/tbfixgfxprobs01.jpg)
Weird glyph floating on the side of the hull for no apparent reason.  Changeed its image constantly.  Also note corruption of HUD graphics.
(http://www.3dap.com/hlp/hosted/scroll/misc/tbfixgfxprobs02.jpg)
Large section of the background inexplicably disappears.
(http://www.3dap.com/hlp/hosted/scroll/misc/tbfixgfxprobs03.jpg)
Green Prometheus fire is now blue.

Title: Thruster Bug Fixed
Post by: Goober5000 on January 09, 2003, 05:59:20 pm

Hey, at least the thrusters are fixed! :lol:

Yeah, I noticed that too.  I Bugzilla'd it - it has something to do with the new graphics code.  When Phreak uploaded his new osapi.cpp version, the problems started, and when I updated the codebase with four new files today, they disappeared.  I have yet to rebuild an exe with the rolled-back version of bmpman.cpp.

Title: Thruster Bug Fixed
Post by: Goober5000 on January 09, 2003, 07:01:46 pm

Here's the latest build, in release form.

http://fs2source.warpcore.org/exes/fs2_open.zip

Title: Thruster Bug Fixed
Post by: Sesquipedalian on January 09, 2003, 08:09:36 pm

That's better.

Title: Thruster Bug Fixed
Post by: phreak on January 09, 2003, 08:33:30 pm

:confused:

the osapi.cpp only did something with opengl mode

Title: Thruster Bug Fixed
Post by: Goober5000 on January 09, 2003, 08:46:13 pm

And I was all confused when the update fixed it.  Something's amiss... :wtf:

Title: Thruster Bug Fixed
Post by: Nico on January 10, 2003, 02:30:12 am

Oh, yeah, completly forgot to say: In bob's release: I have a very strange bug: my new custom explosion, when playing ( so when i've destroyed a ship ), doesn't playe all her frames, instead it plays random PCX from my effect folder, s it looks like a very fast slideshow of the OTT effects... not so cool...
I post that here coz I dunno if it was doing that already before.