Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Test Builds => Topic started by: Goober5000 on March 21, 2008, 10:19:46 pm

Title: 2008-03-21 Trunk build
Post by: Goober5000 on March 21, 2008, 10:19:46 pm
"Trunk" is what we call "the stable branch" in SVN. :) And here it is.  Taylor checked in a bunch of new changes and fixes over the past few days, and WMC added his camera code and several scripting improvements, so see what you think.
http://fs2source.warpcore.org/exes/latest/20080321-Goober5000.7z
Title: Re: 2008-03-21 Trunk build
Post by: Colonol Dekker on March 21, 2008, 10:22:20 pm
Yay! Direct link ftw, cheers :)
*DLS to try out.
Title: Re: 2008-03-21 Trunk build
Post by: Wanderer on March 22, 2008, 12:25:17 am
I see the alternate subsystem names code made it here too
Title: Re: 2008-03-21 Trunk build
Post by: MP-Ryan on March 22, 2008, 07:33:33 am
This build, like Taylor's Xt0314 build, breaks the TVWP.

Specifically, it breaks the ammo gauge.  The weapon is present, but has no ammunition.  This is not a pilot file bu because switching back to the 0306 Xt build or any previous build fixes the problem without switching pilots.

Furthermore, it may be related to handling of tables.  In the third mission of the TVWP demo you can select the weapons your shrike is armed with.  If you drag the M-72s off the Shrike and then try to drag them back, a message flashes up saying the shrike cannot handle M-72 weaponry.  However, previous builds do not have this problem.  This would seem to illustrate a recently added bug in the way weapons tables are handled, specifically with weapons which contain ammunition.

It is most obvious in the TVWP but the nature of the bug suggest this is not mod-specific but encompasses table-handling itself.  As this is the second public test build with the bug present, I would say you've now got it in SVN.
Title: Re: 2008-03-21 Trunk build
Post by: ARSPR on March 22, 2008, 07:44:11 am
This build, like Taylor's Xt0314 build, breaks the TVWP.

Mantis it?
Title: Re: 2008-03-21 Trunk build
Post by: Mobius on March 22, 2008, 07:49:19 am
I see the alternate subsystem names code made it here too

Is that what I think it is? It can be used to mark Railgun turrets(that are considered normal "laser turrets")! :D
Title: Re: 2008-03-21 Trunk build
Post by: Wanderer on March 22, 2008, 08:01:38 am
Is that what I think it is? It can be used to mark Railgun turrets(that are considered normal "laser turrets")! :D
Yeah.. that's it. Goes before the subsystem armor entry (if it has any).

Example... GTFr Triton...
Code: [Select]
$Name:                  GTFR Triton
   +nocreate
$Subsystem:             turret01,1,1.0
   $Alt Subsystem Name: Flak Turret
   $Default PBanks:        ( "Standard Flak" )
$Subsystem:             turret02,1,1.0
   $Alt Subsystem Name: Subach Turret
   $Default PBanks:        ( "Subach HL-7" )
$Subsystem:             communications,         10,     0.0
   $Alt Subsystem Name: Subspace Comms
$Subsystem:             navigation,          5,      0.0
   $Alt Subsystem Name: Astrogation
Title: Re: 2008-03-21 Trunk build
Post by: asyikarea51 on March 22, 2008, 10:23:56 am
I notice this build handles the F3 viewer slightly differently, in earlier builds the viewer turns itself off when I exit it, in this build, the last selected ship is still shown even after exiting and re-entering the viewer. Also there's no normal mapping but that doesn't matter since this isn't an official release.

One question about the $Alt Subsystem Name: Apart from tables, can the names be set in FRED (or by manually editing the file with a text editor at the very least)? Considering that weapons can be changed in FRED...

:)
Title: Re: 2008-03-21 Trunk build
Post by: Wanderer on March 22, 2008, 01:16:56 pm
From what i discussed with karajorma there should be a SEXP for doing the trick as well.

This build, like Taylor's Xt0314 build, breaks the TVWP.

Specifically, it breaks the ammo gauge.  The weapon is present, but has no ammunition.  This is not a pilot file bu because switching back to the 0306 Xt build or any previous build fixes the problem without switching pilots.
Just making sure... are you 100 % sure there is nothing wrong in your tables?
Title: Re: 2008-03-21 Trunk build
Post by: Mobius on March 22, 2008, 01:21:12 pm
:yes:

Railguns will work fine with modifications to the table entry, but a SEXP would be formidable.
Title: Re: 2008-03-21 Trunk build
Post by: Wanderer on March 22, 2008, 01:30:32 pm
At least sexps.html tells it is in there.... Change -> Subsystems and Cargo -> change-subsystem-name

Quote from: sexps.html
change-subsystem-name
    change-subsystem-name
    Changes the name of the specified subsystem on the specified ship
    Takes 3 or more arguments
    1: Name(s) of ship(s)
    2: New name for the subsystem (names larger than the maximum display size will be truncated
    3: Name(s) of subsystem(s) to rename
Title: Re: 2008-03-21 Trunk build
Post by: Mobius on March 22, 2008, 01:33:04 pm
:yes:
Title: Re: 2008-03-21 Trunk build
Post by: karajorma on March 22, 2008, 04:39:53 pm
Do you really think I'd add a feature and not add a SEXP if one was possible? :D
Title: Re: 2008-03-21 Trunk build
Post by: asyikarea51 on March 23, 2008, 05:29:27 am
Do you really think I'd add a feature and not add a SEXP if one was possible? :D

Uhhhhh... o_O
*aa51 gets all :nervous:

:lol:

Anyway, seems like this build still doesn't fix an extremely minor sound issue that's been bugging me for a while now, but rather than get on the coders' nerves, I'll play around with file names and other builds, find a simple solution or something.
Title: Re: 2008-03-21 Trunk build
Post by: MP-Ryan on March 23, 2008, 07:21:47 am
This build, like Taylor's Xt0314 build, breaks the TVWP.

Specifically, it breaks the ammo gauge.  The weapon is present, but has no ammunition.  This is not a pilot file bu because switching back to the 0306 Xt build or any previous build fixes the problem without switching pilots.
Just making sure... are you 100 % sure there is nothing wrong in your tables?

Yes.  It's the TVWP pack straight from the demo download.  And it works fine in ALL builds from march 6th and earlier.  The error is due to something that's been committed between March 6th and now.

Try it yourself.  The bug affects all of the first three missions (and I have no idea if it affects the ones beyond that, though I'd imagine it does).
Title: Re: 2008-03-21 Trunk build
Post by: Zacam on March 23, 2008, 05:40:43 pm
The previous builds may or may not have caught on to the fact that there was an error in the tables and now it is.

Just because it never previously showed up does not mean it previously was not an issue. Remember the 3.6.8Z Alpha Patches? Everything _seemed_ to render fine until it got fixed, necessitating the mvp Alpha patches.

About it not being a pilot problem, you mention switching a build back without changing the pilot and the problem goes away, but did you create a new pilot to test with?

(Downloading TVWP now)
Title: Re: 2008-03-21 Trunk build
Post by: MP-Ryan on March 23, 2008, 05:57:30 pm
The previous builds may or may not have caught on to the fact that there was an error in the tables and now it is.

Just because it never previously showed up does not mean it previously was not an issue. Remember the 3.6.8Z Alpha Patches? Everything _seemed_ to render fine until it got fixed, necessitating the mvp Alpha patches.

About it not being a pilot problem, you mention switching a build back without changing the pilot and the problem goes away, but did you create a new pilot to test with?

(Downloading TVWP now)

A completely new pilot file experiences this problem in the new build.  A completely new pilot does not experience this problem in any build prior to 0306.  Pilots used in both sets of builds experience the problem in the new build, but not in the older ones.

It's not a pilot file compatibility/corruption issue.

The weapons.tbl and ships.tbl files for TVWP match up appropriately as well for weapons compatibility.  I have no idea why a new build should suddenly cause the game to fail to recognize the compatibility of a particular weapon with a particular ship, but it does.

For ease of testing, use mission 3 of the demo because it has the ship and weapons selection tabs in the briefing enabled.  You'll see the error if you drag the M-72 off the shrike and then attempt to drag it back.
Title: Re: 2008-03-21 Trunk build
Post by: ARSPR on March 24, 2008, 10:15:16 am
I can confirm both MP-Ryan troubles. As he says, TVWP "A Calm Sea" mission is perfect for testing.

I haven't tested this build, (I'm too used to Taylor's Xt normal mapping builds), but I can narrow down the problem to something between Xt0313 and Xt0314. So depending on when Taylor synchronized his own code tree, the trouble comes from some post in March 12th, 13th or 14th.

@MP-Ryan: Again, mantis it?  ;)



EDIT: --------
This trouble is maybe solved BUT TWICE.

+I've just installed TortoiseSVN
+I've downloaded the code following Kara's explanation.
+Just to play a little with TortoiseSVN, I've done "Show Log" and I get the attached screenshot
+As you can see the last two posts from Taylor and WMC seem to be for the very same issue...

[attachment deleted by ninja]
Title: Re: 2008-03-21 Trunk build
Post by: taylor on March 24, 2008, 10:45:38 am
This trouble is maybe solved BUT TWICE.

+I've just installed TortoiseSVN
+I've downloaded the code following Kara's explanation.
+Just to play a little with TortoiseSVN, I've done "Show Log" and I get the attached screenshot
+As you can see the last two posts from Taylor and WMC seems to be for the very same issue...
We fixed two different bugs actually.  My commit was for the ballistic weapon problem and WMC's was for bad handling of wing numbers for destroyed/departed ships. :)
Title: Re: 2008-03-21 Trunk build
Post by: MP-Ryan on March 24, 2008, 05:20:30 pm
@MP-Ryan: Again, mantis it?  ;)

Taylor has generally said not to Mantis Xt build bugs - I wasn't sure if the same when for these recent builds or not.
Title: Re: 2008-03-21 Trunk build
Post by: karajorma on March 24, 2008, 05:46:14 pm
The yardstick is whether or not the code responsible for the bug is in SVN. Taylor's xt builds have lots of code in them which isn't in SVN which means that is someone other than him looks at the bug they often find they can't reproduce it.

Goober doesn't mention having any features which need testing before they go into SVN which therefore means that pretty much any actual bug you hit should be in Mantis.
Title: Re: 2008-03-21 Trunk build
Post by: ARSPR on March 25, 2008, 02:32:56 am
@MP-Ryan: Again, mantis it?  ;)

Taylor has generally said not to Mantis Xt build bugs - I wasn't sure if the same when for these recent builds or not.
Yes, but you said that THIS BUILD (which is not just Taylor's own and not submitted code) suffers the issue.



Nevertherless, I think this issue is solved now.
Title: Re: 2008-03-21 Trunk build
Post by: Talon 1024 on March 27, 2008, 08:51:30 pm
So...  Why doesn't this build support GLSL/Normal maps?
Title: Re: 2008-03-21 Trunk build
Post by: Goober5000 on March 27, 2008, 08:54:59 pm
Because those aren't in the stable branch yet.  See the first post.
Title: Re: 2008-03-21 Trunk build
Post by: neoterran on March 27, 2008, 09:02:53 pm
Ummm, OT but can us poor mac users get a build...? It's been 3 months already :|
Title: Re: 2008-03-21 Trunk build
Post by: taylor on March 27, 2008, 09:56:39 pm
Ummm, OT but can us poor mac users get a build...? It's been 3 months already :|
I'm the only SCP person who makes them and I simply don't have enough time to do it for the foreseeable future.  I want to say that I will, but it ain't likely to happen anytime soon.

Feel free to make and post your own though.  If you want the code base for the Xt builds then send a PM my way and I'll give you a link.  You will pretty much be on your own regarding getting a working project file going in either case though.  The SVN project file is seriously out of date, and the current Xt project file requires modified system headers to compile.  :sigh:
Title: Re: 2008-03-21 Trunk build
Post by: blowfish on March 27, 2008, 10:00:51 pm
Ummm, OT but can us poor mac users get a build...? It's been 3 months already :|
I'm the only SCP person who makes them and I simply don't have enough time to do it for the foreseeable future.  I want to say that I will, but it ain't likely to happen anytime soon.

Feel free to make and post your own though.  If you want the code base for the Xt builds then send a PM my way and I'll give you a link.  You will pretty much be on your own regarding getting a working project file going in either case though.  The SVN project file is seriously out of date, and the current Xt project file requires modified system headers to compile.  :sigh:

I've tried, but the XCode project file is really messed up and/or in need of major updating.  I would like to see a new mac build, there are some new features that I would really like to take advantage of, but if no one is around to build it and/or update the project file I understand.
Title: Re: 2008-03-21 Trunk build
Post by: taylor on March 30, 2008, 08:47:45 pm
Ummm, OT but can us poor mac users get a build...? It's been 3 months already :|
http://icculus.org/~taylor/fso/testing/20080330_trunk-osx.tgz

 :D
Title: Re: 2008-03-21 Trunk build
Post by: Goober5000 on March 31, 2008, 01:12:05 am
Three days is not within the foreseeable future?!? :p
Title: Re: 2008-03-21 Trunk build
Post by: taylor on March 31, 2008, 01:42:59 am
Three days is not within the foreseeable future?!? :p
Well, I didn't foresee it 3 days ago.  :D

I was just getting the project file usable, while working on other Mantis bugs, and a working set of builds was an unfortunate side-effect of the process. ;)