Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Wanderer on March 23, 2008, 09:56:33 am

Title: Ballistic primaries flag
Post by: Wanderer on March 23, 2008, 09:56:33 am
So... About this flag in ships.tbl... Is it needed or is it not? Depending on the build you use it either triggers warnings if its missing or if it is present.

Quite a while ago it was IIRC mandatory to get fighter to use the ballistic primaries. Then using it started triggering warnings and flag was generally removed from ships.tbl. Now the game again triggers warnings if the flag is missing? Could quite well be related into this issue (http://www.hard-light.net/forums/index.php/topic,52871.0.html) reported by MP-Ryan. So any ideas?
Title: Re: Ballistic primaries flag
Post by: Quiet on March 23, 2008, 10:03:35 pm
Is this the warning you're getting Wanderer? "Pbank capacity specified for non-ballistic-primary-enabled ship" and then assert failures if you try and fire?

After I switched from a CVS build to the latest trunk from SVN I got that (I'm working around it by tweaking some of the btrl tables since it's not urgent I need them). I'm still learning the code but is it possible this is happening?

In ship/parse_ship at line 3800 the ballistic flag is set (sip->flags |= SIF_BALLISTIC_PRIMARIES;)

Then at 3897 it's reset if a $Flag entry is found (sip->flags = SIF_DEFAULT_VALUE;)
Title: Re: Ballistic primaries flag
Post by: taylor on March 23, 2008, 10:39:01 pm
After I switched from a CVS build to the latest trunk from SVN I got that (I'm working around it by tweaking some of the btrl tables since it's not urgent I need them). I'm still learning the code but is it possible this is happening?

In ship/parse_ship at line 3800 the ballistic flag is set (sip->flags |= SIF_BALLISTIC_PRIMARIES;)

Then at 3897 it's reset if a $Flag entry is found (sip->flags = SIF_DEFAULT_VALUE;)
I noticed the same thing a few minutes ago and already committed a fix. :)
Title: Re: Ballistic primaries flag
Post by: Goober5000 on March 23, 2008, 11:33:32 pm
Oops. :nervous: