Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Echelon9 on March 31, 2008, 03:35:12 am

Title: Patch against rev-4568: Unused variable in chttpget.cpp
Post by: Echelon9 on March 31, 2008, 03:35:12 am

Hi,

I've begun looking in detail at areas of the fs2_open code where I can improve performance. As a basic test, please find the attached and included below patch.
Yes, I know it's rather mundane, but I just wanted to ensure later patches are in the right format and to try the process of getting patches included in trunk.

Code: [Select]

Index: code/inetfile/chttpget.cpp
===================================================================
--- code/inetfile/chttpget.cpp (revision 4568)
+++ code/inetfile/chttpget.cpp (working copy)
@@ -238,7 +238,7 @@
  return;
  }
 
- uint arg = 1;
+// uint arg = 1;
 // ioctlsocket( m_DataSock, FIONBIO, &arg );
 
  char *pURL = URL;

I'm primarily a Mac coder, so that will be where coming patches will focus.

[attachment deleted by ninja]

Title: Re: Patch against rev-4568: Unused variable in chttpget.cpp
Post by: taylor on March 31, 2008, 05:50:29 am

You can really just ignore the inetfile stuff, since I'm thinking about dumping it and replacing it with libcurl or something.  Right now none of that code really works very well, and isn't used.  I doubt it will ever be fixed at this point, unless you want to work on it by chance? ;)

Otherwise the patch is fine, style wise and all. :)