Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: DerKuchen on July 01, 2008, 10:48:16 am

Title: [Patch] Improved "delete pilot"-warning
Post by: DerKuchen on July 01, 2008, 10:48:16 am: I just deleted a false pilot by accident :(
To prevent this type of accident in future, I created a patch that adds the pilot's name to the warning message. It's now "Are you sure you wish to delete the pilot 'Pilot Name'?"

I hope this will be useful.
-DerKuchen

[attachment deleted by admin]
Title: Re: [Patch] Improved "delete pilot"-warning
Post by: karajorma on July 02, 2008, 02:19:13 am: Hmmmm, one thing I don't like is that you seem to have removed the use of XSTR() which basically means that the line won't translate for versions of the game running in other languages. Which basically means that sooner or later someone is going to file that as a bug.
Title: Re: [Patch] Improved "delete pilot"-warning
Post by: DerKuchen on July 02, 2008, 05:28:19 am: I had to change the string, so I think XSTR won't find the correct translation.
Maybe the string could be the old string with the pilot names just added... e.g. "Are you sure you wish to delete this pilot? (Pilot Name)"
Or is there a possibility to add new translations?

Edit: Here's the new patch, now with properly translated messages.

[attachment deleted by admin]
Title: Re: [Patch] Improved "delete pilot"-warning
Post by: DerKuchen on July 06, 2008, 07:57:45 am: Any update on this?
Title: Re: [Patch] Improved "delete pilot"-warning
Post by: karajorma on July 06, 2008, 09:35:26 am: The thing I'm wondering about now is what will happen to that trailing argument if the XSTR converts the string to one which doesn't contain a %s (Which I presume the French and Germans ones don't). If the game just discards it without error I'll add this now. :)
Title: Re: [Patch] Improved "delete pilot"-warning
Post by: DerKuchen on July 06, 2008, 10:43:22 am: There are no problems with German umlauts (I'm using a German client), I think French special characters should work as well.