Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Aardwolf on November 26, 2009, 03:24:33 pm

Title: Project Proposal (POF editor)
Post by: Aardwolf on November 26, 2009, 03:24:33 pm
It has come to my attention that the code for PCS2 is GPL'd. This means that we could create our own SVN for it, with public access (at least for download). Thus, people could do freelance programming of features and bugfixes, and it would actually be possible to get stuff done.

Note that this isn't about Kazan, as much as it is about me (and presumably others) wanting to see continuing work on PCS2.

My apologies to Kazan for stealing his baby.
Title: Re: Project Proposal (POF editor)
Post by: portej05 on November 26, 2009, 10:05:03 pm
Hi Aardwolf,

I have talked to Kazan about using PCS2 code previously.
The end result was that he'd prefer PCS2 to remain PCS2 in the sf.net repository.
While the GPL does allow you to do what you want, but mixing up the environment with random builds doesn't sounds like a good idea.

I suggest PM'ing Kazan.
Title: Re: Project Proposal (POF editor)
Post by: Spicious on November 26, 2009, 10:21:19 pm
If you're trying to move away from one antiquated version control system, maybe you should avoid moving straight to another antiquated version control system.
Title: Re: Project Proposal (POF editor)
Post by: Galemp on November 27, 2009, 12:25:44 am
SVN is antiquated? News to me.
Title: Re: Project Proposal (POF editor)
Post by: Nuke on November 27, 2009, 02:12:20 am
pcs2 was on cvs last i checked. however i dont think many if any active coders have write access to it.
Title: Re: Project Proposal (POF editor)
Post by: Spicious on November 27, 2009, 04:24:37 am
SVN is antiquated? News to me.
It is compared to a distributed version control system. See the git tech talk for why. For something like this distributed should make a lot more sense than centralised anyway.
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on November 27, 2009, 11:06:16 am
Spicious, I was going to suggest github but didn't think this was the venue for the discussion.  I figured that if we did try to start a side project though, it'd be a good testbed for it since only a handful of devs would be using it.
Title: Re: Project Proposal (POF editor)
Post by: Spicious on November 28, 2009, 01:20:32 am
Git tends to be fairly irritating to use on Windows.
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on November 29, 2009, 02:49:59 pm
It's getting better, with msysgit and TortoiseGit.  TortoiseGit has made huge advances in usability in the last year.
Title: Re: Project Proposal (POF editor)
Post by: Aardwolf on November 29, 2009, 05:39:16 pm
On the topic of PCS2, I'll try talking to Kazan (that is, via PM) and see if he's not too unhappy with this idea, or if he has a better one.

Edit: PM sent.
Title: Re: Project Proposal (POF editor)
Post by: Iss Mneur on November 29, 2009, 08:12:34 pm
It's getting better, with msysgit and TortoiseGit.  TortoiseGit has made huge advances in usability in the last year.

Mercurial (http://selenic.com/mercurial/) and TortoisHG also work pretty good on windows. Its not git, but is a DVCS.

As for the topic, like I said in IRC, as it has not been updated for over a year I doubt he would have an issue with it being updated by someone else, as long as credit is given.

If confusion of the name is concern, call it PCS3.
Title: Re: Project Proposal (POF editor)
Post by: Kazan on November 30, 2009, 07:03:08 am
as i said in my PM - i would prefer it stay in my CVS repository at sf.net, but I will gladly add people to the contributor list so they can commit.

if you really really want we can migrate it to my SF.net SVN


and screw your "omg X is antiquiate, use GIT" crap, i'm tired of hearing that where ever i go.  there is no good technical reason to use GIT over SVN as far as I've seen - just more of the "it's a bunch of trendy ideas tossed into a pot!" crap that i've seen infecting the OSS community [another example: pulseaudio]

(i sound like an old man saying "damn kids! get off my lawn!")
Title: Re: Project Proposal (POF editor)
Post by: Dragon on November 30, 2009, 08:33:52 am
When you will finish debating about whether to use Tortoise SVN or not, can you consider adding Modelview-like shield mesh editor to PCS2?
Currently, it's the only adventage Modelview has over PCS2.
I'd also like to be able to edit the position of shield mesh, just like it's possible in case of subobjects.
And I'd like to see squadron insygnia editor similar to one that was in PCS1, but, if possible, easier to use.
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on November 30, 2009, 09:43:35 am
I think those have been on the roadmap for a while already.  They'd likely get implemented if there were people working on PCS again.
Title: Re: Project Proposal (POF editor)
Post by: Aardwolf on November 30, 2009, 11:02:29 am
There was also the one "show-stopping" bug on Intel-cards which caused the (attempted) rendering of omnipoints to crash PCS2 --- something to do with VBOs.

Anyway, it's good to hear you're willing to let more people contribute.
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on November 30, 2009, 11:20:06 am
Kazan, also, I wasn't excited about git until I started using it here at work.  Now that I have, I'm in love with it, and think simply using git instead of svn would make even the SCP development more fluid.  The branching support is far ahead of that in SVN, which isn't really branching at all.  Just take a look at these arguments for git (http://whygitisbetterthanx.com/).  Git would actually help you handle code input from multiple developers on PCS2.  Just look at some of the workflow examples.  I've got no problem leaving it where it is, although I'd rather have SVN than CVS personally.
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on November 30, 2009, 02:29:12 pm
it might not be a bad idea to move PCS2 under FSO, the two projects are obviously tightly related, and even though PCS2 is designed to be able to handle more file formats, let's face it, the name has POF in the acronym. I might want to get back to coding for it after this semester and it would be a whole lot easier if the administrator of the repository was active.

note: I do NOT feel strongly about this. just saying the idea has merit.

P.S. is there a linux IDE project of some sort set up for PCS2, I've been using kubuntu for the last few months and this would be a great way to get my feet wet in coding for linux.
Title: Re: Project Proposal (POF editor)
Post by: Spicious on December 01, 2009, 07:45:43 am
as i said in my PM - i would prefer it stay in my CVS repository at sf.net, but I will gladly add people to the contributor list so they can commit.
A big advantage of DVCS is avoiding this problem almost entirely. Tech talk (http://www.youtube.com/watch?v=4XpnKHJAok8).

PCS2 will not compile under GCC. I suspect something like the template subclasses not being declared correctly according to the spec.
Title: Re: Project Proposal (POF editor)
Post by: portej05 on December 01, 2009, 08:24:59 am
Request thread split!

I suggest putting it in SVN@SF and adding someone who can moderate patches for it until this is all figured out.

Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 01, 2009, 09:13:24 am
PCS2 will not compile under GCC. I suspect something like the template subclasses not being declared correctly according to the spec.

tell me more :)
I thought I did everything correctly and I thought the recent versions of visual studio were more standards compliant, though I suppose more != completely. and there is some major template usage going on.
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on December 01, 2009, 10:09:03 am
You might need to enable more levels of warnings to get VS2008 to tell you what's wrong.  For instance, GCC4.2 now defaults to complaining about const char* to char* conversions, which VS doesn't by default but apparently can complain about.  Just a thought.
Title: Re: Project Proposal (POF editor)
Post by: Kazan on December 06, 2009, 01:03:06 pm
as i said in my PM - i would prefer it stay in my CVS repository at sf.net, but I will gladly add people to the contributor list so they can commit.
A big advantage of DVCS is avoiding this problem almost entirely. Tech talk (http://www.youtube.com/watch?v=4XpnKHJAok8).

PCS2 will not compile under GCC. I suspect something like the template subclasses not being declared correctly according to the spec.

it's not? crapola.

PS: I prefer SCons or Waf - as opposed to the gods-forsaken GNU Make or CMake systems for doing linux builds.
Title: Re: Project Proposal (POF editor)
Post by: Nuke on December 08, 2009, 12:07:05 am
i wouldnt mind using svn over cvs just so i dont have to have software to access both. also i wouldnt mind pcs2 supporting the same compilers that freespace does. i was able to download the code but i dont think i could compile it with vc 2008 express.
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 08, 2009, 09:35:07 pm
I use VS2008...
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on December 08, 2009, 10:21:32 pm
Yeah I thought it was VS 2008 compatible too.
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 08, 2009, 11:56:13 pm
also nuke has a point, PCS2 is the _only_ reason I have any CVS clients installed right now.

and for that matter I don't even remember how to get the source,
it looks like tortise cvs does not work with windows 7
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on December 09, 2009, 01:02:09 am
Likewise here, I don't use any other CVS repos.  Smells like upgrade time to me anyway.
Title: Re: Project Proposal (POF editor)
Post by: Spicious on December 09, 2009, 06:06:36 am
There's a whole heap of problems with a unicode build of wx due to lack of proper conversions. There are a fair few about >> for nested templates. There are lots of "there are no arguments to '...' that depend on a template parameter, so a declaration of '...' must be available". There's one "extra qualification 'PCS2_MainWindow::' on member 'putTitle'". There's one #include <wx\wx.h>. As far as I can tell the SConscript file is written in the style of a Makefile.

The problems I had last time I tried seem to have gone away though.
Title: Re: Project Proposal (POF editor)
Post by: Kazan on December 09, 2009, 07:01:56 am
yes it is built against a non-unicode build of wx.. it is one of the various problems that i was working on.  head is not stable right now - the branch (the name of which I forget right now) is stable, it's fixes.. i think it is "2.0-fixes")

we can move it over to SVN.

I use VS2008 as well.
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 09, 2009, 07:15:55 pm
you know wx recently released a version that does away with the unicode/not-unicode distinction
Title: Re: Project Proposal (POF editor)
Post by: Nuke on December 09, 2009, 09:52:20 pm
i may have just been trying to use the wrong version of wx
Title: Re: Project Proposal (POF editor)
Post by: Spicious on December 10, 2009, 06:48:46 am
you know wx recently released a version that does away with the unicode/not-unicode distinction
Unless it's done by dropping unicode, that won't solve the current problems. It'd help reduce future messes though.
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 19, 2009, 11:35:33 pm
so has anything come of this thread? I've got some recreational coding time.
Title: Re: Project Proposal (POF editor)
Post by: Aardwolf on December 21, 2009, 06:10:49 pm
I'm not sure, but I think we may have swayed Kazan to move to SVN?

And he seems to be more willing to let other people contribute than I first suspected...

@Bobboau : If you could fix it so omnipoints don't break on my crummy Intel 945... well, I have nothing to offer, but I (and a few others) would greatly appreciate it.
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 22, 2009, 08:40:47 am
I currently can't even get the current source code to download, tortoise SVN doesn't work in windows 7 and every time I start looking for another client I get distracted by something shiny, besides I don't want to install a CVS client if it's about to get migrated to SVN, however I also recognize Kaz realy doesn't want to mess with it right now, and I don't quite want to be put into a management position of the thing right now either, so I guess someone else needs to step up and take a management position of the repository.
Title: Re: Project Proposal (POF editor)
Post by: The E on December 22, 2009, 09:37:22 am
/me looks at his tortoise client running happily on Windows 7 x64


Hmm. I must be doing something wrong then.
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on December 22, 2009, 10:03:30 am
You could also just use command line SVN for now, there's at least 3 recommended installers on the subversion site (CollabNet's, SlikSVN, and Tigris.org's own).
Title: Re: Project Proposal (POF editor)
Post by: Zacam on December 22, 2009, 12:32:30 pm
It's small enough and I'm involved enough that I _might_ be able to provide an SVN solution for the code.

Let me just make sure the server space has the ability to do so (it is currently hosting quite a lot as it already is).

And TortiseSVN client works just fine in both x64 and x32 Win7. Not sure about running an SVN server in it. It might help to run the installer (and make sure it's up to date) as "Administrator" (even though the primary user account _is_ an Admin account, it's not the same) and it should be just fine).

Feel free to PM me with any difficulties you are having and I'll see if I can provide some assistance.
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 22, 2009, 12:44:29 pm
I guess I could try running it as admin...
Title: Re: Project Proposal (POF editor)
Post by: Bobboau on December 23, 2009, 12:51:31 am
well, that seems to have been the problem
Title: Re: Project Proposal (POF editor)
Post by: chief1983 on December 23, 2009, 01:02:55 am
Anyway, if no one else wants to I could probably handle managing the SF svn repo.  Just sayin'.
Title: Re: Project Proposal (POF editor)
Post by: Spicious on December 29, 2009, 06:28:36 am
I've found a marvellous problem (at least with my current version): pcs2.h includes main_panel.h which includes model_editor_ctrl.h which includes op_stack.h which needs definitions from later on in pcs2.h.