Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Scourge of Ages on September 17, 2010, 02:42:37 pm

Title: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: Scourge of Ages on September 17, 2010, 02:42:37 pm
I've been informed that this is a code thing so... If it's possible, this would be a great thing for large battles and multiplayer games where multiple fighters will need to be rearmed simultaneously.
Could a flag be added in Species_defs.tbl to define on a per-species basis the max support ships, to avoid potentially breaking retail and/or other campaigns?

See: http://www.hard-light.net/forums/index.php?topic=71592.msg1415336#msg1415336
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: General Battuta on September 17, 2010, 02:49:48 pm
The discussion that informed you was an offshoot of some work we've been doing to look at this on IRC. I'd like to request that this please, please be a mission or AI profiles flag.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: Scourge of Ages on September 17, 2010, 03:01:59 pm
Understood, sir! Didn't know it was already open, so thought I'd just put this out there formally.

Looking forward to whatever you all figure out.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: General Battuta on September 17, 2010, 03:05:14 pm
It was a great move to make this a formal request, actually, as I was terribly negligent in not doing so. Forum threads are good things.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: TopAce on September 17, 2010, 03:12:29 pm
I'd prefer to have this as a mission flag, set in the Mission Specs editor. You may not want to constantly have three support ships around for some missions that'd be too easy with that kind of reparation capability.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: General Battuta on September 17, 2010, 03:14:33 pm
Yeah I concur.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: karajorma on September 17, 2010, 10:57:39 pm
I'd have to look at it again but as an option for the set support ship SEXP seems like the most logical place to me.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: General Battuta on September 17, 2010, 11:01:03 pm
I'd have to look at it again but as an option for the set support ship SEXP seems like the most logical place to me.

That'd be great. That's what I actually thought its final argument did at first.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: Iss Mneur on September 18, 2010, 02:06:16 am
I'd have to look at it again but as an option for the set support ship SEXP seems like the most logical place to me.

That'd be great. That's what I actually thought its final argument did at first.
Well, I was bored and I thought I would take a stab at this.  Karajorma, I hope you hadn't put to much work into this.

Added control of having more than one support ship per team to set-support-ship as an optional 7th arg.  Doc for set-support-ship updated to reflect new functionality and clarified to make the difference between the 6th arg and the 7th arg apparent.  Download the FSO and FRED binaries and .pdbs from:http://www.box.net/shared/566ekybavm
 (http://www.box.net/shared/566ekybavm)
Diff to come after I take a second look my fix.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: General Battuta on September 18, 2010, 09:28:54 am
I'd have to look at it again but as an option for the set support ship SEXP seems like the most logical place to me.

That'd be great. That's what I actually thought its final argument did at first.
Well, I was bored and I thought I would take a stab at this.  Karajorma, I hope you hadn't put to much work into this.

Added control of having more than one support ship per team to set-support-ship as an optional 7th arg.  Doc for set-support-ship updated to reflect new functionality and clarified to make the difference between the 6th arg and the 7th arg apparent.  Download the FSO and FRED binaries and .pdbs from:http://www.box.net/shared/566ekybavm
 (http://www.box.net/shared/566ekybavm)
Diff to come after I take a second look my fix.


You are a god.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: karajorma on September 18, 2010, 10:28:10 pm
I'm still a little worried about what effects that might have if used in multiplayer.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: Iss Mneur on September 19, 2010, 12:59:59 am
You are a god.

I assume that means that it works?  I suppose that is why I didn't get more VA script from you today either, right? :P

I'm still a little worried about what effects that might have if used in multiplayer.
Well, I am not changing anything that deals with multiplayer, or the implementation of support ships, just the way that the support ship code regulates the counts.  That is, the way that a support ship is requested has not changed.  That being said, I have posted the patch for the newest build on internal for code review, before it gets committed to trunk.



Okay, new build for you three people that downloaded the last one.  Same as last time, FRED and FSO with their .pdbs can be downloaded from: http://www.box.net/shared/3vm0ql3boo (http://www.box.net/shared/3vm0ql3boo).  I have played a few missions of retail and the support ship seems to be working fine.

The changes are mostly mostly code style changes, but there is a possibility that I did break something.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: General Battuta on September 19, 2010, 01:11:48 am
You are a god.

I assume that means that it works?  I suppose that is why I didn't get more VA script from you today either, right? :P

Are you sure you didn't get more? Kassim and a good chunk of Laporte are done.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: Iss Mneur on September 21, 2010, 12:19:26 am
Committed in revision 6482.  Feature is activated by a seventh parameter to set-support-ship.  See the sexp help for more information.
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: General Battuta on September 21, 2010, 06:56:21 am
Committed in revision 6482.  Feature is activated by a seventh parameter to set-support-ship.  See the sexp help for more information.

wooooooooo
Title: Re: Request: Increase MAX_SUPPORT_SHIPS_PER_TEAM
Post by: chief1983 on September 21, 2010, 01:12:42 pm
And OS X and Windows nightlies are up that have it :)