Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: zookeeper on March 23, 2012, 08:33:52 am

Title: New pilots inherit volume levels from current pilot: bug or feature?
Post by: zookeeper on March 23, 2012, 08:33:52 am
Currently, if you start the game and immediately create a new pilot in the pilot selection screen, the new pilot gets the hard-coded default volume settings. However, if you've already selected a pilot and then proceed to create a new one, the new pilot will inherit the currently selected pilot's volume levels. Based on looking at the code, I know how and why it happens, but I can't really tell if it's a bug or not. In a way it might make sense since no matter which pilot you use, you're still on the same physical machine and likely want to use the same volume settings.

The reason I'm asking is because I tried to add game_settings.tbl options for setting the default volume levels, and the easy implementation for that would suffer from the same inheritance issue as the hard-coded defaults now do.
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: Aardwolf on March 23, 2012, 02:04:54 pm
Er... is game_settings.tbl a renamed mod.tbl, or what?
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: mjn.mixael on March 23, 2012, 02:10:37 pm
game_settings is the 'mod.tbl'
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: Aardwolf on March 23, 2012, 06:13:43 pm
So, what I said? 'K.
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: jr2 on March 23, 2012, 09:47:26 pm
as far as i can understand, what was meant in the op was ' I tried to add game_settings .tbl options' <-- notice the space after _settings

SO, game_settings is a setting under mod.tbl, the "game_settings.tbl" was simply a typo


... did I infer correctly?
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: karajorma on March 23, 2012, 10:33:17 pm
Game_settings.tbl is the name for the actual table. Everyone just calls it mod.tbl since that was the original name for it. Oh and the .tbm is called mod.tbm
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: Nuke on March 24, 2012, 03:28:26 am
if you want to clone another pilots settings you should inherit settings, but if you create a fresh pilot from scratch it should reset to defaults. the whole reason it lets you clone pilots is to give you a choice between defaults and existing settings.
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: Aardwolf on March 24, 2012, 01:20:12 pm
Well duh. But volume settings (or at least a "master volume") is something you might want as a program-wide setting, so that if you had the volume turned down to 1 and the speakers up to max, you don't accidentally deafen yourself when you create a new pilot.

Adding a "master volume" setting seems like it might be trouble to do, though.
Title: Re: New pilots inherit volume levels from current pilot: bug or feature?
Post by: Nuke on March 24, 2012, 08:26:19 pm
if you dont want to use defaults you have the option of cloning another pilot. though i have nothing against setting the default master volume somewhere though. so that the defaults arent full blast.