Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Cross-Platform Development => Topic started by: rsaxvc on November 24, 2013, 01:32:47 pm

Title: GCC 4.2.1 fixup
Post by: rsaxvc on November 24, 2013, 01:32:47 pm

Could someone review+apply the attached patch to tips? Basically, "goto done_secondary" was skipping the initialization of "bank_adjusted". This patch moves the initialization of "bank_adjusted" to just after we know the bank, but before we fire any gotos.

[attachment deleted by an evil time traveler]

Title: Re: GCC 4.2.1 fixup
Post by: niffiwan on November 24, 2013, 03:19:13 pm

Thanks for the patch!  I think this has been committed along with a few other fixes:  http://svn.icculus.org/fs2open?limit_changes=0&view=rev&sortby=file&revision=10156

Title: Re: GCC 4.2.1 fixup
Post by: Echelon9 on November 24, 2013, 06:32:18 pm

Thanks rsaxvc for the bug report and the patch -- I'd seen LLVM/Clang report on this too, but hadn't had time to run it to ground yet.

Title: Re: GCC 4.2.1 fixup
Post by: rsaxvc on November 24, 2013, 06:54:08 pm

Well that was fast.

Also, part of that link isn't working. http://svn.icculus.org/fs2open/trunk/fs2_open/code/ship/ship.cpp?limit_changes=0&view=markup&sortby=file&pathrev=10156

Title: Re: GCC 4.2.1 fixup
Post by: niffiwan on November 24, 2013, 07:59:31 pm

hmm.. ViewVC has had a few oddities creep in since the icculus.org SVN server died and they rebuilt it...

Title: Re: GCC 4.2.1 fixup
Post by: chief1983 on November 25, 2013, 12:19:30 am

Yeah, I've just been dealing with it until we can move to git.  I guess someone could contact them about it though.