Hard Light Productions Forums

General FreeSpace => FreeSpace & FreeSpace Open Support => Topic started by: Spline64 on August 24, 2015, 09:19:00 pm

Title: Issue in Derelict mod
Post by: Spline64 on August 24, 2015, 09:19:00 pm
Hello,

Having an issue with the 6th mission in Derelict (Bait and Switch) and am getting this error when the ships we are attacking are confirmed as friendly. All turn green and in about 10 seconds get a crash back to terminal with the error:

ASSERTION: "shipnum >= 0 && shipnum < MAX_SHIPS" at missionparse.cpp:6665  Arriving ship '' does not exist!

I have attached a log. Other 5 missions went without a hitch.
So something is wrong with the ship that is trying to appear correct?

Running Ubuntu 14.04 LTS

Any ideas would be appreciated.

Thanks,
Spline64

[attachment deleted by nobody]
Title: Re: Issue in Derelict mod
Post by: niffiwan on August 24, 2015, 09:31:27 pm
Are you using the latest version of the code from github?
Title: Re: Issue in Derelict mod
Post by: Spline64 on August 24, 2015, 09:45:33 pm
Using fs2_open 3.7.2 Debug....compiled on July 1st 2015
I'll check if they have a new version out.

Thanks,
Spline64
Title: Re: Issue in Derelict mod
Post by: AdmiralRalwood on August 24, 2015, 10:02:06 pm
Using fs2_open 3.7.2 Debug....compiled on July 1st 2015
Code: [Select]
FreeSpace 2 Open version: 3.7.3
Your log seems to think you're not using 3.7.2.
Title: Re: Issue in Derelict mod
Post by: Spline64 on August 24, 2015, 10:08:36 pm
I apologize...need to actually read the log before I post.
Title: Re: Issue in Derelict mod
Post by: Spline64 on August 24, 2015, 10:41:45 pm
Just tried this in a windows  install  on a different computer using  version 3.7.3 and got the same error message.

Guess I've found my problem.

Thanks,
Spline64
Title: Re: Issue in Derelict mod
Post by: AdmiralRalwood on August 24, 2015, 10:51:31 pm
Just tried this in a windows  install  on a different computer using  version 3.7.3 and got the same error message.

Guess I've found my problem.

Thanks,
Spline64
Well, that still doesn't tell us what commit your version of FSO was compiled from, whether the problem still exists in current master, and whether or not you have problems with 3.7.2 Final.
Title: Re: Issue in Derelict mod
Post by: Spline64 on August 24, 2015, 11:31:53 pm
Tested on Revision : 2434365
Downloaded latest build, 50Feb3e.  Same error.

Sorry, never tested 3.7.2_final on this distro.

Will compile 3.7.2 Final and let ya know
 (btw 3.7.2 Final works fine on Windows )

Spline64
Title: Re: Issue in Derelict mod
Post by: Spline64 on August 26, 2015, 12:33:28 am
Tested the following builds:

fs2_open_3.7.2  --   latest commit eb46c94d08 --  Works correctly on Ubuntu 14.04 LTS.

fs2_open_3.7.3  --   latest commit 3a5f7143a2 --  errors in 6th mission as described
fs2_open_3.7.3_debug  --  same as above

Crashing when the RedBeard and "friends" try to appear.

Looked at all models in the tech room, all are accessable

I have attached a windows log of 3.7.3 with the same commit that has the same issue.

Really trying to test the heck out of this so I understand what's going on.

Thanks,



[attachment deleted by nobody]
Title: Re: Issue in Derelict mod
Post by: Goober5000 on September 01, 2015, 04:33:43 pm
Crashing when the RedBeard and "friends" try to appear.

Looking at the mission in question (attached), one thing that jumps out at me is that Kidd wing is set to arrive near a member of Jolly Roger wing, but Jolly Roger is cued to arrive after Kidd wing.  This is a circular dependency, so the bug lies in the mission.  That does raise the question of how the mission ever worked in the first place though.

The problem is confounded by the fact that the Assertion error message actually mislabels the ship.  The empty ship name '' is the arrival anchor, not the arriving ship itself, and the arriving ship's name does not appear in the error message.  Even so, it doesn't make sense that the arrival anchor is an empty ship name.  It would be good to trace through a debugger and find out exactly what is going on here.

Spline64, see if the second attachment (dl1-06-fixed.fs2) fixes the problem.  Put it in your data\missions folder and remove the "-fixed" from the file name so that it's just dl1-06.fs2.

EDIT: Turns out the modified mission will not fix the problem; see next post.  It's a code bug.

[attachment deleted by nobody]
Title: Re: Issue in Derelict mod
Post by: Goober5000 on September 02, 2015, 12:15:30 am
Gah.  The real, root cause of this error is someone trying to add a scripting hook for arrivals in mission_maybe_make_ship_arrive() and making a mess of it.  Time to open a Mantis or github ticket.