Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: General Battuta on October 25, 2015, 08:29:24 am

Title: Mother ****in personas
Post by: General Battuta on October 25, 2015, 08:29:24 am
Yo I want to tell you about a behavior which is Not Good, It's Bad:

If a persona does not have a message specified for a specific condition (say, rearm) it randomly grabs a line from another persona and uses it.

This is weird and strange. Maybe I don't want Shivan Fighter Bob to ever talk about calling for support. Could we get a flag to disable it?
Title: Re: Mother ****in personas
Post by: AdmiralRalwood on October 25, 2015, 09:18:24 am
It looks like it should be fairly easy to add relevant code to the message_send_builtin_to_player() function in missionmessage.cpp to initialize best_match to a higher value based on some property of the Persona; this would cause it to not consider lower-quality matches (e.g. "same species") to be valid choices. We'd also need to make the function abort gracefully if there are no valid matches (it currently hits an Int3() if that's the case).
Title: Re: Mother ****in personas
Post by: Goober5000 on October 25, 2015, 06:02:57 pm
Yo I want to tell you about a behavior which is Not Good, It's Bad:

Speaking of which, there's no need to tarnish perfectly reasonable questions with gratuitous vulgar language.  It's not going to get your request handled any faster.  Warning issued.
Title: Re: Mother ****in personas
Post by: General Battuta on November 13, 2015, 02:31:04 pm
Correction: I am a stupid person
Title: Re: Mother ****in personas
Post by: The E on November 14, 2015, 05:58:51 am
https://github.com/scp-fs2open/fs2open.github.com/pull/439
Title: Re: Mother ****in personas
Post by: General Battuta on November 21, 2015, 01:34:54 pm
Request handled! Thank you scp bamfs. I'll let you know if it does anything strange.