Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Nightly Builds => Topic started by: SirKnightly on November 06, 2015, 12:52:18 pm

Title: Nightly (Windows): 06 Nov 2015 - Revision fbc9ede
Post by: SirKnightly on November 06, 2015, 12:52:18 pm
Here is the nightly for Windows on 06 Nov 2015 - Revision fbc9ede

Open non-feature issues in Mantis (http://scp.indiegames.us/mantis/view_all_set.php?type=3&source_query_id=611): 124

Group: Standard
fso_Standard_20151106_fbc9ede.7z (http://swc.fs2downloads.com/builds/WIN/fso_Standard_20151106_fbc9ede.7z)
MD5Sum (http://swc.fs2downloads.com/builds/WIN/fso_Standard_20151106_fbc9ede.md5)

Group: AVX
fso_AVX_20151106_fbc9ede.7z (http://swc.fs2downloads.com/builds/WIN/fso_AVX_20151106_fbc9ede.7z)
MD5Sum (http://swc.fs2downloads.com/builds/WIN/fso_AVX_20151106_fbc9ede.md5)

Group: SSE
fso_SSE_20151106_fbc9ede.7z (http://swc.fs2downloads.com/builds/WIN/fso_SSE_20151106_fbc9ede.7z)
MD5Sum (http://swc.fs2downloads.com/builds/WIN/fso_SSE_20151106_fbc9ede.md5)

Group: NO-SSE
fso_NO-SSE_20151106_fbc9ede.7z (http://swc.fs2downloads.com/builds/WIN/fso_NO-SSE_20151106_fbc9ede.7z)
MD5Sum (http://swc.fs2downloads.com/builds/WIN/fso_NO-SSE_20151106_fbc9ede.md5)

Code: [Select]
------------------------------------------------------------------------
commit 1d66596
Author: niffiwan <Fri Nov 6 07:59:03 2015 +1000>
Commit: niffiwan <Fri Nov 6 07:59:03 2015 +1000>

    Disable shadows by default
 code/cmdline/cmdline.cpp | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

------------------------------------------------------------------------
commit b704050
Author: Goober5000 <Thu Nov 5 00:36:06 2015 -0500>
Commit: Goober5000 <Thu Nov 5 00:36:06 2015 -0500>

    change these functions to return bool rather than int; fixes a minor warning
 code/ship/shipfx.cpp | 42 +++++++++++++++++++++---------------------
 code/ship/shipfx.h   |  6 +++---
 2 files changed, 24 insertions(+), 24 deletions(-)

------------------------------------------------------------------------
commit bbad1c2
Author: Goober5000 <Thu Oct 29 09:34:18 2015 -0400>
Commit: Goober5000 <Thu Oct 29 09:34:18 2015 -0400>

    more const-correctness per PR comments
 code/graphics/2d.h                | 24 ++++++++++++------------
 code/graphics/gropengl.cpp        |  4 ++--
 code/graphics/gropengldraw.cpp    |  4 ++--
 code/graphics/gropengldraw.h      | 10 +++++-----
 code/graphics/gropengltexture.cpp |  2 +-
 code/graphics/gropengltnl.cpp     | 12 ++++++------
 code/graphics/gropengltnl.h       | 10 +++++-----
 code/graphics/grstub.cpp          | 24 ++++++++++++------------
 8 files changed, 45 insertions(+), 45 deletions(-)

------------------------------------------------------------------------
commit a7dcda9
Author: Goober5000 <Wed Oct 28 00:02:35 2015 -0400>
Commit: Goober5000 <Wed Oct 28 00:02:35 2015 -0400>

    wip to avoid const_cast
 code/render/3ddraw.cpp  | 2 +-
 code/render/3dsetup.cpp | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit bfc0948
Author: Goober5000 <Tue Oct 27 22:52:03 2015 -0400>
Commit: Goober5000 <Tue Oct 27 22:52:03 2015 -0400>

    let's change this antipattern here too
 code/starfield/starfield.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

------------------------------------------------------------------------
commit 75411d9
Author: Goober5000 <Tue Oct 27 22:46:35 2015 -0400>
Commit: Goober5000 <Tue Oct 27 22:46:35 2015 -0400>

    const-correctness inspired by 392, because why not be masochistic
 code/io/keycontrol.cpp                 |  2 +-
 code/missionui/missionscreencommon.cpp |  2 +-
 code/missionui/missionscreencommon.h   |  2 +-
 code/model/modelinterp.cpp             |  2 +-
 code/render/3d.h                       | 85 ++++++++++++++++++----------------
 code/render/3ddraw.cpp                 | 49 ++++++++++----------
 code/render/3dinternal.h               |  2 +-
 code/render/3dlaser.cpp                |  8 ++--
 code/render/3dmath.cpp                 | 20 ++++----
 code/render/3dsetup.cpp                | 23 ++++-----
 10 files changed, 101 insertions(+), 94 deletions(-)


Title: Re: Nightly (Windows): 06 Nov 2015 - Revision fbc9ede
Post by: chief1983 on November 06, 2015, 12:59:33 pm
This is the first Visual Studio 2015 automated nightly build.  Seems to have worked, if someone could confirm that this does work fine for them that would be helpful, still need to get a full set of game data on my new machine so I can actually test builds now.
Title: Re: Nightly (Windows): 06 Nov 2015 - Revision fbc9ede
Post by: General Battuta on November 19, 2015, 08:17:10 pm
This build broke the Blue Planet mission 'The Great Preservers'.

On builds before Nov 6, killing Arjuna Wing has no unusual effect.

On builds after Nov 6, killing Arjuna Wing causes a CTD in release builds. I haven't been able to repro this in debug builds.

We need to get a fix on this, because we have other important bugs that got fixed after Nov 6, but our game doesn't work after Nov 6!  :shaking:
Title: Re: Nightly (Windows): 06 Nov 2015 - Revision fbc9ede
Post by: General Battuta on November 19, 2015, 08:41:49 pm
Couple more clues:

There's a script operating on Arjuna Wing, and if you turn off that script, the crash doesn't happen.

If you compile your own builds, apparently the crash doesn't happen, so I'm told by top #scp men this may be a so-called compiler error?
Title: Re: Nightly (Windows): 06 Nov 2015 - Revision fbc9ede
Post by: niffiwan on November 19, 2015, 08:50:03 pm
Self compiled builds on 2013 (SSE2) & 2015 (AVX) haven't crashed.

SSE2 nightlies have crashed.

AVX nighties have sometimes crashed, but not always.

Proving elusive to track down, more info & test cases is good!
Title: Re: Nightly (Windows): 06 Nov 2015 - Revision fbc9ede
Post by: AdmiralRalwood on November 19, 2015, 11:42:13 pm
I'm pretty sure I've tracked this down (https://github.com/scp-fs2open/fs2open.github.com/pull/454).
Title: Re: Nightly (Windows): 06 Nov 2015 - Revision fbc9ede
Post by: General Battuta on November 20, 2015, 08:38:27 am
Fixed, as far as I can tell! What a strange, strange bug.