Hard Light Productions Forums
Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Bryan See on November 18, 2015, 08:43:11 am
-
Since the FS2 source code release, the maximum filename limit increase has been among the most neglected. Many modders having problems in specifying file names larger than 32 characters. When running either FRED or FS2, an error message usually appears, alerting that the 32-character has been exceeded.
As a result, I've decided to increase the filename limit to 256 in keeping with the modern operating systems such as the recently-released Windows 10. In addition to this, I've increased the callsign limit to 252.
I've made a pull request from my fork at GitHub. Here's my pull request: https://github.com/scp-fs2open/fs2open.github.com/pull/448 (https://github.com/scp-fs2open/fs2open.github.com/pull/448).
-
Assuming that the change itself is ok (I didn't try to find out), you really need to squash that into one commit.
-
I've reforked the FS2 SCP branch from scratch.
Here's the link https://github.com/scp-fs2open/fs2open.github.com/pull/451 (https://github.com/scp-fs2open/fs2open.github.com/pull/451), this time with no unwanted past commits.
EDIT: I've closed the pull request and reverted my fork's commit after reading The E's comments. I know it's not a critical issue nor a showstopper, but an annoyance, indeed. As The E pointed out, getting rid of MAX_PATH_LEN, which is at least tangentially related to MAX_FILENAME_LEN, are among the fixes upon the merger of Antipodes expected after getting through the 3.7.4 release candidate phase.
And, once the Antipodes was merged into the main branch, along with Swifty's PBR, I'm expecting that my branch will become the next one.
-
Please take a look at the discussion for your previous PR. This is not, despite appearances, a quick and easy change. It needs to be done with care and proper testing, and as I mentioned there, this change will also necessitate changing the .vp file format to allow long filenames (Or, at the very least, checking whether vps can handle such things).
-
Look at my edit above, The E. I agree with you.
-
And, once the Antipodes was merged into the main branch, along with Swifty's PBR, I'm expecting that my branch will become the next one.
Why would it be? What features do you have in your branches?
-
I would like to help the SCP further, but I don't have any features in my branches. I was planning to have features such as model-instancing to increase performance, Vulkan API, OpenCollada support, no 32-character limits, and so on.
-
We have several high profile features that are already written to at least near-completion, although order completed is no guarantee of being merged into master in a certain order. But there's 0 chance a branch would be considered for merging if it doesn't have any code yet :P
-
Also, if by "the next one" you mean "the next Antipodes", I think the general idea is not to have another Antipodes, but rather have regular PR-style branches that might just be maintained on the main repository (e.g. the current Antipodes might be named something like "feature/sdl-everywhere") so that everyone can contribute to them.