Hard Light Productions Forums
Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Spoon on February 18, 2017, 11:44:42 am
-
Yo dawgs, whats up with this yo yo
from
(https://ibin.co/3CqCte4sLZOW.png)
to
(https://ibin.co/3CqBitm9vOke.png)
From a build I received on 2017/02/12
These shield edges look like they could stab someone something fierce.
-
Looks like it's drawing triangles instead of quads...
Do you have any more information about the build, like what commit it's based on?
-
Dahblount told me:
[19:38] <DahBlount[mobile]> It was based off the orientation changes, commit 02ae98c
-
I can't find that commit in master :confused:
DahBlount, can you shed some more light?
-
I can't find that commit in master :confused:
You couldn't find this commit (https://github.com/scp-fs2open/fs2open.github.com/commit/028ae98c212446414251b2a074b729a38bff509e)?
-
Dahblount told me:
[19:38] <DahBlount[mobile]> It was based off the orientation changes, commit 02ae98c
I can't find that commit in master :confused:
You couldn't find this commit (https://github.com/scp-fs2open/fs2open.github.com/commit/028ae98c212446414251b2a074b729a38bff509e)?
02ae98c
028ae98
Given the originally quoted hash was wrong and I only had 30 secs at the time, no I couldn't :p
edit: finally had time to reproduce & bisect; github issue (https://github.com/scp-fs2open/fs2open.github.com/issues/1261) has been logged
-
I found the issue and submitted a fix for review: https://github.com/scp-fs2open/fs2open.github.com/pull/1262
The error occurred because the render code only rendered 4 of the 6 vertices that are required for the shield icon.
-
:yes: