Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: General Battuta on February 06, 2021, 10:00:26 am

Title: Adversary problems with strings.tbl
Post by: General Battuta on February 06, 2021, 10:00:26 am
Adversary has been having problems with strings.tbl in recent builds.

Quote
The issue won't affect other mods unless the modder has edited the strings.tbl
Basically, modifying a menu title entry in strings.tbl will not work if you're using a recent build.
The build will ignore your changes and use it's own entry for the description.

I think I've also noticed this - mods that should have the 'cutscene' and 'credits' menu options removed suddenly have them again. It'd be great if we could fix this so Adversary can be presented correctly on 21.0.0. Well, I guess it's too late for 21.0.0, but...on whatever's next.
Title: Re: Adversary problems with strings.tbl
Post by: AdmiralRalwood on February 06, 2021, 12:39:07 pm
This appears to be a regression introduced by PR #2390 (https://github.com/scp-fs2open/fs2open.github.com/pull/2390). As a workaround, you can enable the "$Use tabled strings for the default language:" mod table setting, although this might cause problems without an up-to-date tstrings.tbl.
Title: Re: Adversary problems with strings.tbl
Post by: General Battuta on February 06, 2021, 12:49:17 pm
What sort of problems? Or, alternately, what kind of strings.tbl changes would be required?
Title: Re: Adversary problems with strings.tbl
Post by: AdmiralRalwood on February 06, 2021, 01:35:25 pm
What sort of problems? Or, alternately, what kind of strings.tbl changes would be required?
strings.tbl and tstrings.tbl are completely separate; strings.tbl handles engine-internal strings, while tstrings.tbl handles "external" strings (strings defined in missions and tables, basically). Since tstrings.tbl defaults to "use the default string" instead of "use the English string defined in tstrings.tbl", any string with an index that isn't -1 might be "out of sync" with the version of that string in tstrings.tbl. I should note that most modders tend to define new XSTR entries with an index of -1 out of sheer force of habit, so this will probably only cause problems with modified retail descriptions (assuming any exist in the data).
Title: Re: Adversary problems with strings.tbl
Post by: General Battuta on February 06, 2021, 02:07:37 pm
I'm sorry, I don't really understand. What do I need to do to get Adversary's modified strings.tbl to correctly show up in game?
Title: Re: Adversary problems with strings.tbl
Post by: AdmiralRalwood on February 06, 2021, 02:12:18 pm
Enable this setting (https://wiki.hard-light.net/index.php/Game_settings.tbl#.24Use_tabled_strings_for_the_default_language:) in the mod table.
Title: Re: Adversary problems with strings.tbl
Post by: General Battuta on February 06, 2021, 02:33:23 pm
Lol jeez. Why does that default to no?
Title: Re: Adversary problems with strings.tbl
Post by: AdmiralRalwood on February 06, 2021, 04:49:44 pm
In this case, it was a matter of one table behaving one way (strings.tbl) and the other behaving the other way (tstrings.tbl) and the behavior was made more consistent at the expense of backwards compatibility.
Title: Re: Adversary problems with strings.tbl
Post by: Goober5000 on February 06, 2021, 06:52:49 pm
I'm going to take a look to see if this can be restored to use retail behavior.