Hard Light Productions Forums

Modding, Mission Design, and Coding => FS2 Open Coding - The Source Code Project (SCP) => Topic started by: Nightstorm on February 06, 2017, 10:34:29 am

Title: Tech Room weapons database in Diaspora
Post by: Nightstorm on February 06, 2017, 10:34:29 am

Hey folks,

Sorry for not finding this sooner as I don't go into it all that often.  However what I've found is that on any build after August 18, 2016 the weapons database doesn't work in the Tech Room.  The other two do.  If you select weapons it just displays nothing.  No error, no crash just nothing displayed.  That was a 32 bit build at the time.  I didn't see any mention of it and Karajorma was unaware.  Can anyone reproduce this?

Thanks,

Title: Re: Tech Room weapons database in Diaspora
Post by: chief1983 on February 06, 2017, 10:51:59 am

Strange, I was just trying to update Fate of the Galaxy's codebase and see what bugs we had with our code on top of current master, and I noticed we had no ships in the ship lab, but we had weapons.  I also could not click on the mission simulator at all.  Wonder if there are table issues in newer code, in each of the mods, causing each of these issues.  Not sure a git bisect would be feasible for tracking it down on my end because FotG's data has been evolving alongside code changes somewhat, but maybe a bisect would help track it down on the Diaspora side of things?

Title: Re: Tech Room weapons database in Diaspora
Post by: m!m on February 06, 2017, 11:19:24 am

I can reproduce this issue and I created a GitHub issue for it: https://github.com/scp-fs2open/fs2open.github.com/issues/1191

EDIT: Found the issue, fix submitted here: https://github.com/scp-fs2open/fs2open.github.com/pull/1192

Title: Re: Tech Room weapons database in Diaspora
Post by: mjn.mixael on February 06, 2017, 12:32:29 pm

Quote from: m!m on February 06, 2017, 11:19:24 am

I can reproduce this issue and I created a GitHub issue for it: https://github.com/scp-fs2open/fs2open.github.com/issues/1191

EDIT: Found the issue, fix submitted here: https://github.com/scp-fs2open/fs2open.github.com/pull/1192

You sir, get many efficiency points.  :)

Title: Re: Tech Room weapons database in Diaspora
Post by: m!m on February 06, 2017, 03:41:24 pm

Not quite. My first fix didn't actually fix the issue but now I found the proper solution (I hope).

Title: Re: Tech Room weapons database in Diaspora
Post by: m!m on February 07, 2017, 03:10:37 am

This bug should be fixed in the latest nightly.

Title: Re: Tech Room weapons database in Diaspora
Post by: Nightstorm on February 07, 2017, 06:15:27 am

Confirmed.  Great thank you!  You guys are awesome.