Author Topic: Possibly breaking filesystem change  (Read 2481 times)

0 Members and 1 Guest are viewing this topic.

Offline chief1983

  • Still lacks a custom title
  • Moderator
  • 212
  • ⬇️⬆️⬅️⬅️🅰➡️⬇️
    • Minecraft
    • Skype
    • Steam
    • Twitter
    • Fate of the Galaxy
Re: Possibly breaking filesystem change
Well, that sucks, unless subversion has become smarter about that I guess that would indeed be unavoidable.
Fate of the Galaxy - Now Hiring!  Apply within | Diaspora | SCP Home | Collada Importer for PCS2
Karajorma's 'How to report bugs' | Mantis
#freespace | #scp-swc | #diaspora | #SCP | #hard-light on EsperNet

"You may not sell or otherwise commercially exploit the source or things you created based on the source." -- Excerpt from FSO license, for reference

Nuclear1:  Jesus Christ zack you're a little too hamyurger for HLP right now...
iamzack:  i dont have hamynerge i just want ptatoc hips D:
redsniper:  Platonic hips?!
iamzack:  lays

 

Offline Goober5000

  • HLP Loremaster
  • Administrator
  • 214
    • Goober5000 Productions
Re: Possibly breaking filesystem change
Except FSO handles it inside VP files just fine, so clearly we do support it; we could just extend that support outside of a VP archive.

I have written the code to support different cases on Linux so with a bit of testing we could use that if the consensus is that we want to support that case.

This would be my preference.

I ran into this exact problem on the FSO Installer, which was first brought to my attention by (IIRC) niffiwan.  Some of the MediaVP zipfiles used the "MediaVPs" capitalization and some used "mediavps".  On Windows everything would be extracted into the same folder, but on Linux you'd end up with some files in one folder and some in another, leading to half-working MediaVPs when the game was run.  Rather than ask the MediaVP folks to re-package their files, I made the Installer do a case-insensitive search for existing folders with the same name.

It would be nice if everyone standardized on lowercase, but not even Volition was consistent in this (FS1 capitalized the first letter of the folder while FS2 used lowercase).  Using a case-insensitive search is the more robust solution.

 

Offline m!m

  • 211
Re: Possibly breaking filesystem change
The breaking change has been reverted and I submitted the case insensitive solution: https://github.com/scp-fs2open/fs2open.github.com/pull/1204

 

Offline m!m

  • 211
Re: Possibly breaking filesystem change
The case insensitive solution has been merged.

 

Offline Spoon

  • 212
  • ヾ(´︶`♡)ノ
Re: Possibly breaking filesystem change
The best outcome  :yes:
Urutorahappī!!

[02:42] <@Axem> spoon somethings wrong
[02:42] <@Axem> critically wrong
[02:42] <@Axem> im happy with these missions now
[02:44] <@Axem> well
[02:44] <@Axem> with 2 of them

 
Re: Possibly breaking filesystem change
I noticed that someone talked about case insensitive over case sensitive. My first thought is, why would that even be necessary? Isn't that why there are functions that convert strings to upper and lower case? Of course, a solution has already been merged, so my thought on the matter is irrelevant, of course.
There are only 10 kinds of people in the world;
those who understand binary and those who don't.

 

Offline The E

  • He's Ebeneezer Goode
  • Global Moderator
  • 213
  • Nothing personal, just tech support.
    • Steam
    • Twitter
Re: Possibly breaking filesystem change
I noticed that someone talked about case insensitive over case sensitive. My first thought is, why would that even be necessary? Isn't that why there are functions that convert strings to upper and lower case? Of course, a solution has already been merged, so my thought on the matter is irrelevant, of course.

The problem is that Unix filesystems are strictly case sensitive. "data", "Data" and "DATA" are all distinct directories, and since a lot of file paths in FSO are hardcoded (for example, tables are always assumed to be in "data/tables"), if someone ships a mod that has everything in a directory named "Data", FSO will not be able to open those files.
Let there be light
Let there be moon
Let there be stars and let there be you
Let there be monsters and let there be pain
Let us begin to feel again
--Devin Townsend, Genesis

 
Re: Possibly breaking filesystem change
Ouch. Right. Forgot about that.
There are only 10 kinds of people in the world;
those who understand binary and those who don't.