[EdrickV]

That program doesn't seem to work right using the commands on the Warpcore site, not entirely sure why, and the batch file is screwy and will go into an endless loop if you try to use -download. (There appears to be a limit on label size so download1 and download2 appear identical to the parser.)

[Inquisitor]

I'll delet all those and start over.

BASIC CVS should work, as should WinCVS.

[EdrickV]

Ok, I found something else out: That CVS exe is designed to be run from Cygwin, that's why it's complaining about not finding a home directory. (AKA the Unix style user's home folder.) It also seems to use /'s rather then \'s so won't work right from a DOS box.

[Sesquipedalian]

WinCVS.  Works like a dream.

[Goober5000]

Okay, I finally got the thing downloaded and loaded up in MSVC6.0.  Huge daunting mess of code...

I hit Rebuild All and the thing started chugging away, but then I got a bunch of errors...

Deleting intermediate files and output files for project 'code - Win32 Debug'.
Deleting intermediate files and output files for project 'Freespace2 - Win32 Debug'.
--------------------Configuration: code - Win32 Debug--------------------
Compiling...
\fs2_open\code\debugconsole\timerbar.cpp(82) : warning C4127: conditional expression is constant
\fs2_open\code\io\swff_lib.cpp(367) : warning C4100: 'lpvRef' : unreferenced formal parameter
\fs2_open\code\Model\ModelInterp.cpp(2672) : warning C4189: 'shipp' : local variable is initialized but not referenced
\fs2_open\code\Parse\SEXP.CPP(6791) : error C2143: syntax error : missing ';' before 'return'
\fs2_open\code\Parse\SEXP.CPP(6792) : error C2143: syntax error : missing ';' before '}'
\fs2_open\code\Parse\SEXP.CPP(6792) : error C2143: syntax error : missing ';' before '}'
\fs2_open\code\Parse\SEXP.CPP(6792) : error C2143: syntax error : missing ';' before '}'
\fs2_open\code\Parse\SEXP.CPP(6795) : error C2143: syntax error : missing ';' before '{'
\fs2_open\code\Parse\SEXP.CPP(6795) : error C2447: missing function header (old-style formal list?)
\fs2_open\code\Parse\SEXP.CPP(7967) : error C2065: 'sexp_num_kills' : undeclared identifier
\fs2_open\code\Network\Psnet2.cpp(2622) : warning C4101: 'ret' : unreferenced local variable
Error executing cl.exe.

fs2_open_debug.exe - 7 error(s), 4 warning(s)

I assume you guys know about these.  Are they bugs in the code, or am I using the wrong configuration?  I'm nervous about those "undeclared" and "unreferenced" messages...

[DTP]

Originally posted by Goober5000
Okay, I finally got the thing downloaded and loaded up in MSVC6.0.  Huge daunting mess of code...

I hit Rebuild All and the thing started chugging away, but then I got a bunch of errors...



I assume you guys know about these.  Are they bugs in the code, or am I using the wrong configuration?  I'm nervous about those "undeclared" and "unreferenced" messages...

edit: looking into it, seems SEXP is broken. looking into it.

ignore the warnings regarding timerbar, and lvp*** something

unrefenrenced means it is being setup to be used, but never used. in other words, not a bug, but bad habits from some programmers.

but it seems someone forgot a keyword seperator, the ";" sign, that can really goof up things.

edit2

error identified

someone forgot a {

at line 6785 in SEXP.cpp

if(ship_is_tagged(caller))

that should be

if(ship_is_tagged(caller)) {

Fixed, and commiting now, Goober5000, you need to down SEXP.cpp again, or in other words checkout from wincvs or whatever cvs program you use.

thx for the report.

[Sesquipedalian]

Oops.  I guess that was me.  Maybe I made a mistake in copying and pasting from EdrickV.  I guess if I had a compiler I'd be able to test these things.  Sorry.

[EdrickV]

You didn't miss a {, you added a }. To explain I'll show you the code I actually used in my version (I'd moved the comment out of the function after I originally posted) followed by your version.

Code: [Select]


object *caller = &Objects[Ships[sindex].objnum];
if(ship_is_tagged(caller))
return 1;
// not tagged
return 0;


Code: [Select]


object *caller = &Objects[Ships[sindex].objnum];
if(ship_is_tagged(caller)) { // This line and the one above were added.
// if(Ships[sindex].tag_left> 0.0f) The broken code. Changed by EdrickV@HLP
         return 1;
}
// not tagged
return 0;


One line if()'s don't need {}'s, the commented code makes it look like there's more to it though.

[Goober5000]

Originally posted by DTP
thx for the report.

You're welcome.  Thanks for the fix.