Author Topic: More compiler errors then you can poke a stick at :O  (Read 1587 times)

0 Members and 1 Guest are viewing this topic.

Offline Hornet

  • 24
More compiler errors then you can poke a stick at :O
I just got FRED2 open and tried to compile it, and the errors I got were disturbing

Theres alot of slopy errors in here, such as misplaces brackets.

Whats going on? I thought CVS builds were supposed to be... buildable?

man, ive gone through and found at least 20 straight up errors in this so far, one entire function was screwed cause someone put the closing bracket way too early and most of the funtion was in the global space. Is there any form of QC on the code that gets uploaded?


Theres things like this:
Quote
   char debris_size[3] = { "Small", "Medium", "Large" };

That returns an array bounds overflow. Of corse it does. "small" is 5 characters long :| Why you had to use an array there and not just a Cstring is beyond me.

Then theres the royal ones, The mismangament of pointers for instance, is going to be a pain in the butt to fix properly. I know this post sounds whingy, I know im the new guy round here, and maybe im missing something obvious (in which case, slap me), but it annoys the fu*k out of me when someone uploads code that they havent even bothered to make sure it obeys the syntax :mad:

itll take me at least two days to just sort through and get it building, let alone running, What if I get something wrong?
(eg brackets - say I found (3 * 3 / 5) + 2 )/ 3 and I had to pick between the two closing brackets, choosing the wrong one will break things)

And thats my 2 cents. Sorry if I seemd a bit ranty.
« Last Edit: July 15, 2005, 10:39:14 am by 2925 »

 

Offline knn

  • 28
More compiler errors then you can poke a stick at :O
"Fred2 is the omega of all giant unwieldy pieces of code. It`s big, it`s horrifying, and it just doesn`t care. View it at your own risk." - Dave Baranec
"Don't try to be a great man, just be a man and let history make its own judgments." -- Zefram Cochrane

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
More compiler errors then you can poke a stick at :O
Er... crap.  That was probably my fault.  I committed a bunch of changes the other day and forgot to go back and check them - breaking one of my own rules. :doh:

Sorry about that.  Give me an hour and I'll see if I can get it working.

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
More compiler errors then you can poke a stick at :O
K, all fixed.  Do a CVS update and you should be good to go. :)

 

Offline FireCrack

  • 210
  • meh...
More compiler errors then you can poke a stick at :O
I figured i should stick this here rather than filling up the whole SCP forum, anywyas, i get this error:

Quote
irc.cpp
d:\Games\FreeSpace2\fs2_open\code\irc\irc.cpp(554) : error C3861: 'NumChannels': identifier not found, even with argument-dependent lookup
d:\Games\FreeSpace2\fs2_open\code\irc\irc.cpp(555) : error C2107: illegal index, indirection not allowed
d:\Games\FreeSpace2\fs2_open\code\irc\irc.cpp(555) : error C2228: left of '.GetName' must have class/struct/union type



refrenced lines, irc.cpp

 
Code: [Select]
if (NumChannels() >= 1)
PrivateMessage(channels[current_channel].GetName(), UserInput);


Now, i'm preety sure this is part of the stuff for the PXO lobby (chat), so removing it shouldnt break anything, still i'd rather not remove it, anyone have any suggestions on this?
actualy, mabye not.
"When ink and pen in hands of men Inscribe your form, bipedal P They draw an altar on which God has slaughtered all stability, no eyes could ever soak in all the places you anoint, and yet to see you all at once we only need the point. Flirting with infinity, your geometric progeny that fit inside you oh so tight with triangles that feel so right."
3.141592653589793238462643383279502884197169399375105820974944 59230781640628620899862803482534211706...
"Your ever-constant homily says flaw is discipline, the patron saint of imperfection frees us from our sin. And if our transcendental lift shall find a final floor, then Man will know the death of God where wonder was before."

 

Offline Goober5000

  • HLP Loremaster
  • Moderator
  • 214
    • Goober5000 Productions
More compiler errors then you can poke a stick at :O
Ah yes, that too.  That was someone else's commit that wasn't quite complete.  Comment out those two lines and you should be good to go.

  

Offline FireCrack

  • 210
  • meh...
More compiler errors then you can poke a stick at :O
ok, just wanted to make sure i wasn't killing anything important.


Now for some reson this POS is compiling as a 16 bit MS dos program :mad: :mad: :mad:


Ok, i fixed that, seems that somthing was wrong when copying, but now i've got a problem as such that fs2 will crash on startup/
« Last Edit: July 16, 2005, 02:11:34 am by 2073 »
actualy, mabye not.
"When ink and pen in hands of men Inscribe your form, bipedal P They draw an altar on which God has slaughtered all stability, no eyes could ever soak in all the places you anoint, and yet to see you all at once we only need the point. Flirting with infinity, your geometric progeny that fit inside you oh so tight with triangles that feel so right."
3.141592653589793238462643383279502884197169399375105820974944 59230781640628620899862803482534211706...
"Your ever-constant homily says flaw is discipline, the patron saint of imperfection frees us from our sin. And if our transcendental lift shall find a final floor, then Man will know the death of God where wonder was before."