Author Topic: Nightly: 23 August 2025 - Revision c451a82f8  (Read 188 times)

0 Members and 1 Guest are viewing this topic.

Offline SirKnightly

  • George or Keira?
  • 212
Nightly: 23 August 2025 - Revision c451a82f8
Here is the nightly for 23 August 2025 - Revision c451a82f8



Group: Linux-arm64
nightly_20250823_c451a82f8-builds-Linux-arm64.tar.gz (Mirror)


Group: Linux-x86_64
nightly_20250823_c451a82f8-builds-Linux-x86_64.tar.gz (Mirror)


Group: MacOSX-arm64
nightly_20250823_c451a82f8-builds-Mac-arm64.tar.gz (Mirror)


Group: MacOSX-x86_64
nightly_20250823_c451a82f8-builds-Mac-x86_64.tar.gz (Mirror)


Group: Win32-SSE2
nightly_20250823_c451a82f8-builds-Win32-SSE2.zip (Mirror)


Group: Win64-SSE2
nightly_20250823_c451a82f8-builds-x64-SSE2.zip (Mirror)

[code]
------------------------------------------------------------------------
commit eb36b56f1
Author: Mike Nelson
Commit: Mike Nelson

    fix
 qtfred/src/ui/dialogs/VariableDialog.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit c39d6b290
Author: Mike Nelson
Commit: Mike Nelson

    convert tostdstring to const data
 qtfred/src/ui/dialogs/VariableDialog.cpp | 64 ++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 28 deletions(-)

------------------------------------------------------------------------
commit 89219df6a
Author: John Fernandez
Commit: John Fernandez

    And move this
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit fa80fc327
Author: John Fernandez
Commit: John Fernandez

    APPEND THIS
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit 84897636c
Author: John Fernandez
Commit: John Fernandez

    Hopefully last of clang warnings
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 4 ++--
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 4 ++--
 qtfred/src/ui/dialogs/VariableDialog.h             | 8 ++------
 3 files changed, 6 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit 9e618f663
Author: Kestrellius
Commit: GitHub

    Particle effect hooks for subsystem destruction (#6937)
 code/model/model.h               |  1 +
 code/particle/ParticleSource.cpp |  1 +
 code/ship/ship.cpp               | 17 +++++++++++++++++
 code/ship/ship.h                 |  1 +
 code/ship/shipfx.cpp             | 25 +++++++++++++++----------
 code/ship/shipfx.h               |  2 +-
 code/ship/shiphit.cpp            | 36 ++++++++++++++++++++++++++++++++----
 7 files changed, 68 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit 43e85dd8f
Author: Taylor Richards
Commit: GitHub

    update libpcp to lastest main (#6963)
 code/CMakeLists.txt                                |    2 +-
 code/network/multi_portfwd.cpp                     |    2 +-
 lib/CMakeLists.txt                                 |    2 +-
 lib/libpcp/CMakeLists.txt                          |   79 --
 lib/libpcp/src/net/pcp_socket.c                    |  345 -----
 lib/libpcp/src/net/sock_ntop.c                     |  353 -----
 lib/libpcp/src/pcp_api.c                           |  777 -----------
 lib/libpcp/src/pcp_event_handler.c                 | 1363 -------------------
 lib/libpcp/src/pcp_logger.h                        |  108 --
 lib/libpcp/src/pcp_msg.c                           |  714 ----------
 lib/libpcp/src/pcp_utils.h                         |  250 ----
 lib/libpcp/src/windows/stdint.h                    |  249 ----
 lib/libpcpnatpmp/CMakeLists.txt                    |   72 +
 lib/libpcpnatpmp/COPYING                           |   22 +
 lib/{libpcp => libpcpnatpmp}/Makefile.am           |   14 +-
 lib/libpcpnatpmp/README.md                         |   23 +
 lib/{libpcp/src => libpcpnatpmp}/default_config.h  |    2 +-
 .../pcp.h => libpcpnatpmp/include/pcpnatpmp.h}     |  141 +-
 .../libpcpnatpmp.pc.in}                            |    8 +-
 .../src/net/findsaddr-udp.c                        |   69 +-
 lib/{libpcp => libpcpnatpmp}/src/net/findsaddr.h   |    6 +-
 lib/{libpcp => libpcpnatpmp}/src/net/gateway.c     |  529 +++-----
 lib/{libpcp => libpcpnatpmp}/src/net/gateway.h     |    0
 lib/libpcpnatpmp/src/net/pcp_socket.c              |  567 ++++++++
 lib/{libpcp => libpcpnatpmp}/src/net/pcp_socket.h  |   36 +-
 lib/libpcpnatpmp/src/net/sock_ntop.c               |  346 +++++
 lib/{libpcp => libpcpnatpmp}/src/net/unp.h         |   29 +-
 lib/libpcpnatpmp/src/pcp_api.c                     |  769 +++++++++++
 lib/{libpcp => libpcpnatpmp}/src/pcp_client_db.c   |  265 ++--
 lib/{libpcp => libpcpnatpmp}/src/pcp_client_db.h   |   58 +-
 lib/libpcpnatpmp/src/pcp_event_handler.c           | 1369 ++++++++++++++++++++
 .../src/pcp_event_handler.h                        |   49 +-
 lib/{libpcp => libpcpnatpmp}/src/pcp_logger.c      |  105 +-
 lib/libpcpnatpmp/src/pcp_logger.h                  |  126 ++
 lib/libpcpnatpmp/src/pcp_msg.c                     |  696 ++++++++++
 lib/{libpcp => libpcpnatpmp}/src/pcp_msg.h         |    9 +-
 lib/{libpcp => libpcpnatpmp}/src/pcp_msg_structs.h |   98 +-
 .../src/pcp_server_discovery.c                     |  165 +--
 .../src/pcp_server_discovery.h                     |    2 +-
 lib/libpcpnatpmp/src/pcp_utils.h                   |  252 ++++
 .../src/windows/pcp_gettimeofday.c                 |   39 +-
 .../src/windows/pcp_gettimeofday.h                 |    0
 .../src/windows/pcp_win_defines.h                  |   34 +-
 43 files changed, 4991 insertions(+), 5153 deletions(-)

------------------------------------------------------------------------
commit a12c1de01
Author: Taylor Richards
Commit: GitHub

    fix memory access error with active games list (#6964)
 code/network/multiui.cpp | 40 ++++++++++++++++++++++++----------------
 1 file changed, 24 insertions(+), 16 deletions(-)

------------------------------------------------------------------------
commit b1247042a
Author: The Force
Commit: GitHub

    QTFred: Alt Ships Class dialogs (#6959)
 code/mission/missionparse.h                        |  26 +-
 qtfred/source_groups.cmake                         |   5 +
 .../dialogs/ShipEditor/ShipAltShipClassModel.cpp   | 120 ++++++++
 .../dialogs/ShipEditor/ShipAltShipClassModel.h     |  38 +++
 .../src/ui/dialogs/ShipEditor/ShipAltShipClass.cpp | 323 +++++++++++++++++++++
 .../src/ui/dialogs/ShipEditor/ShipAltShipClass.h   |  77 +++++
 .../src/ui/dialogs/ShipEditor/ShipEditorDialog.cpp |   4 +-
 .../src/ui/dialogs/ShipEditor/ShipEditorDialog.h   |   1 +
 qtfred/ui/ShipAltShipClass.ui                      | 162 +++++++++++
 9 files changed, 753 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit 3725f27a5
Author: John Fernandez
Commit: John Fernandez

    Match header
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 55efbe73b
Author: John Fernandez
Commit: John Fernandez

    Forgot that VS doesn't have auto save
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 5 +----
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 6 +++---
 2 files changed, 4 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit 40b992489
Author: John Fernandez
Commit: John Fernandez

    More clangy
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  8 ++++----
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit c21cbb306
Author: John Fernandez
Commit: John Fernandez

    Handle shadowing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit 7b9b237a6
Author: John Fernandez
Commit: John Fernandez

    No clever commit message this time
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

------------------------------------------------------------------------
commit f15a6bc3e
Author: John Fernandez
Commit: John Fernandez

    Handle more clang warnings
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 20 ++++++++------------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  8 ++++----
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  9 +++------
 qtfred/src/ui/dialogs/VariableDialog.h             | 10 +++++-----
 4 files changed, 20 insertions(+), 27 deletions(-)

------------------------------------------------------------------------
commit 3a7269275
Author: John Fernandez
Commit: John Fernandez

    blarg
 qtfred/ui/FredView.ui | 1 +
 1 file changed, 1 insertion(+)

------------------------------------------------------------------------
commit 81656e8df
Author: John Fernandez
Commit: John Fernandez

    Add back missing closing markup
 qtfred/ui/FredView.ui | 1 +
 1 file changed, 1 insertion(+)

------------------------------------------------------------------------
commit 552817b8e
Author: John Fernandez
Commit: John Fernandez

    Missing Parentheses
 qtfred/src/ui/dialogs/VariableDialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit 0241c9f4b
Author: John Fernandez
Commit: John Fernandez

    Scare off DeMorgan
 qtfred/src/ui/dialogs/VariableDialog.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

------------------------------------------------------------------------
commit c93c91013
Author: John Fernandez
Commit: John Fernandez

    Do what clang says or else
 qtfred/src/ui/dialogs/VariableDialog.cpp | 50 ++++++++++++++++----------------
 1 file changed, 25 insertions(+), 25 deletions(-)

------------------------------------------------------------------------
commit 81d08cd6f
Author: John Fernandez
Commit: John Fernandez

    More Clang
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

------------------------------------------------------------------------
commit 4efcd8294
Author: John Fernandez
Commit: John Fernandez

    Make sure to use empty
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 16 +++++++---------
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  4 ++--
 2 files changed, 9 insertions(+), 11 deletions(-)

------------------------------------------------------------------------
commit a4014ea98
Author: John Fernandez
Commit: John Fernandez

    According to the internet this should work
 qtfred/src/mission/dialogs/VariableDialogModel.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 1a60eff31
Author: John Fernandez
Commit: John Fernandez

    And try this
 qtfred/src/mission/dialogs/VariableDialogModel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit 7713e1b09
Author: John Fernandez
Commit: John Fernandez

    Don't overzealously mark this
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 2 +-
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit c85876d0d
Author: John Fernandez
Commit: John Fernandez

    don't forget headers
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 16 ++++++++--------
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 18 +++++++++---------
 2 files changed, 17 insertions(+), 17 deletions(-)

------------------------------------------------------------------------
commit 6cadc350b
Author: John Fernandez
Commit: John Fernandez

    Start fixing myriad clang issues
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 18 +++++++----------
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 23 +++++++++-------------
 2 files changed, 16 insertions(+), 25 deletions(-)

------------------------------------------------------------------------
commit 23254c993
Author: JohnAFernandez
Commit: JohnAFernandez

    Allow the loadout dialog to open varaible dialog
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 3 +--
 qtfred/src/ui/FredView.h                           | 4 +++-
 qtfred/src/ui/dialogs/LoadoutDialog.cpp            | 3 +--
 qtfred/ui/LoadoutDialog.ui                         | 3 +++
 qtfred/ui/VariableDialog.ui                        | 3 +++
 5 files changed, 11 insertions(+), 5 deletions(-)

------------------------------------------------------------------------
commit 29fa8c4f9
Author: JohnAFernandez
Commit: JohnAFernandez

    Final Fixes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 49 +++++++++++++++++++---
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  4 +-
 2 files changed, 46 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit ab7aa6356
Author: JohnAFernandez
Commit: JohnAFernandez

    Whoops
 qtfred/src/ui/dialogs/VariableDialog.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 77062e257
Author: JohnAFernandez
Commit: JohnAFernandez

    Make sure check eternal boxes are properly enabled
 qtfred/src/ui/dialogs/VariableDialog.cpp | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit 7229fdc42
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix variable read and write
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 25 +++++++++++-----------
 1 file changed, 13 insertions(+), 12 deletions(-)

------------------------------------------------------------------------
commit d8c7a63af
Author: John Fernandez
Commit: John Fernandez

    This should actually fix it.
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 3 +--
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 2cf24cb27
Author: JohnAFernandez
Commit: JohnAFernandez

    Trying to fix this mystifying error
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 4 +++-
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit 768f88b13
Author: JohnAFernandez
Commit: JohnAFernandez

    Linter Fixes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 33 +++++++++++++---------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +-
 2 files changed, 20 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit d1829a9f1
Author: John Fernandez
Commit: John Fernandez

    Fix Eternal flags being set with no persistence
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 14 +++++++----
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 29 ++++++++++++++++------
 2 files changed, 31 insertions(+), 12 deletions(-)

------------------------------------------------------------------------
commit 860e28fbd
Author: John Fernandez
Commit: John Fernandez

    Finish applying data from model to mission
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 81 +++++++++++++++++++++-
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  3 +-
 2 files changed, 80 insertions(+), 4 deletions(-)

------------------------------------------------------------------------
commit 07a389a5e
Author: John Fernandez
Commit: John Fernandez

    Typo
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit 87367d6b8
Author: John Fernandez
Commit: John Fernandez

    Make sure Keys and Items are proper length
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 45 +++++++++++++---------
 qtfred/src/ui/dialogs/VariableDialog.h             |  2 +-
 2 files changed, 27 insertions(+), 20 deletions(-)

------------------------------------------------------------------------
commit ad7e71369
Author: John Fernandez
Commit: John Fernandez

    Override the virtual reject function
 qtfred/src/ui/dialogs/VariableDialog.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit e5e272915
Author: John Fernandez
Commit: John Fernandez

    Add non-numeric keys to warning messages
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

------------------------------------------------------------------------
commit 039866d52
Author: John Fernandez
Commit: John Fernandez

    Linter Fixes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit d432f9b1e
Author: John Fernandez
Commit: John Fernandez

    Make to loop over the right constraint
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit c51bc08d1
Author: John Fernandez
Commit: John Fernandez

    linter fix
 qtfred/src/ui/dialogs/VariableDialog.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 3be4d0b15
Author: JohnAFernandez
Commit: JohnAFernandez

    Fixes based on testing and linters
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 84 ++++++++++++++--------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  3 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 19 +----
 qtfred/src/ui/dialogs/VariableDialog.h             | 13 +++-
 4 files changed, 72 insertions(+), 47 deletions(-)

------------------------------------------------------------------------
commit 7da79c174
Author: John Fernandez
Commit: John Fernandez

    Add sorting to other function calls
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 62a43512f
Author: John Fernandez
Commit: John Fernandez

    Finish safe to alter variable functions
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 55 ++++++++++++++++++++++
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  2 -
 3 files changed, 57 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 492683db2
Author: John Fernandez
Commit: John Fernandez

    Add A check to safeToAlter functions
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 68 +++++++++++++++++-----
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  7 ++-
 2 files changed, 57 insertions(+), 18 deletions(-)

------------------------------------------------------------------------
commit c53e6b148
Author: John Fernandez
Commit: John Fernandez

    Finish Safe to Alter Options in Model Update
 qtfred/src/ui/dialogs/VariableDialog.cpp | 77 +++++++++++++++++++-------------
 qtfred/src/ui/dialogs/VariableDialog.h   |  6 +--
 2 files changed, 50 insertions(+), 33 deletions(-)

------------------------------------------------------------------------
commit e7f6fa3c9
Author: John Fernandez
Commit: John Fernandez

    Upgrade Container Copying
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 48 ++++++++++++++--------
 1 file changed, 32 insertions(+), 16 deletions(-)

------------------------------------------------------------------------
commit 455d2c968
Author: John Fernandez
Commit: John Fernandez

    Add to Apply()
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 79 ++++++++++++++++++----
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  3 +
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  2 +-
 3 files changed, 69 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit b053131e7
Author: John Fernandez
Commit: John Fernandez

    Connect the x with prereject instead of reject.
 qtfred/src/ui/dialogs/VariableDialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit e502cdfe7
Author: John Fernandez
Commit: John Fernandez

    Finish the validation function
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 48 +++++++++++++++++++++-
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  1 -
 2 files changed, 46 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit e855fc81e
Author: JohnAFernandez
Commit: JohnAFernandez

    Check for conversion availability with same algo
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

------------------------------------------------------------------------
commit df7761547
Author: JohnAFernandez
Commit: JohnAFernandez

    Various Fixes Based on Testing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 51 +++++++++++++---------
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 39 +++++------------
 qtfred/ui/VariableDialog.ui                        | 46 +++++++++----------
 3 files changed, 65 insertions(+), 71 deletions(-)

------------------------------------------------------------------------
commit 20f992fe5
Author: John Fernandez
Commit: John Fernandez

    Fix Not being able to add map items by value
 qtfred/src/ui/dialogs/VariableDialog.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit d557a6eff
Author: JohnAFernandez
Commit: JohnAFernandez

    More Bug fixes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 11 +++++---
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 29 +++++++++++++++++-----
 2 files changed, 31 insertions(+), 9 deletions(-)

------------------------------------------------------------------------
commit e66803af0
Author: JohnAFernandez
Commit: JohnAFernandez

    Further Bug fixes based on testing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 24 +++++++++-------------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 21 +++++++++----------
 3 files changed, 21 insertions(+), 26 deletions(-)

------------------------------------------------------------------------
commit cd3464d33
Author: JohnAFernandez
Commit: JohnAFernandez

    Make sure string items can be deleted
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit bc5f986d7
Author: JohnAFernandez
Commit: JohnAFernandez

    Bug fixes from testing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  7 ++++-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 32 +++++++++++++++++++++-
 qtfred/ui/VariableDialog.ui                        |  4 +--
 3 files changed, 39 insertions(+), 4 deletions(-)

------------------------------------------------------------------------
commit 621030a72
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix various issues
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  14 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 155 +++++++++++----------
 2 files changed, 81 insertions(+), 88 deletions(-)

------------------------------------------------------------------------
commit 9b29e754c
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix overflow return values
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 28 +++++++++++++---------
 1 file changed, 17 insertions(+), 11 deletions(-)

------------------------------------------------------------------------
commit e4886db4d
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix shift up and down buttons
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 8 ++++----
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 8 +++++---
 2 files changed, 9 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit b9b36d2a7
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix Shift up and down buttons
 qtfred/src/ui/dialogs/VariableDialog.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 87fd99f9f
Author: JohnAFernandez
Commit: JohnAFernandez

    Finish implementation of type formatting option
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 12 ++--
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  4 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 67 ++++++++++++++--------
 qtfred/src/ui/dialogs/VariableDialog.h             |  1 +
 qtfred/ui/VariableDialog.ui                        | 26 +++++++++
 5 files changed, 80 insertions(+), 30 deletions(-)

------------------------------------------------------------------------
commit 03083d1a9
Author: JohnAFernandez
Commit: JohnAFernandez

    Implement a few missing container item features
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 156 ++++++++++++++++-----
 qtfred/src/mission/dialogs/VariableDialogModel.h   |   7 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 106 +++++++++++---
 qtfred/src/ui/dialogs/VariableDialog.h             |   4 +-
 4 files changed, 213 insertions(+), 60 deletions(-)

------------------------------------------------------------------------
commit 3120d6dda
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix the Addition of variables by typing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  28 +++++
 qtfred/src/mission/dialogs/VariableDialogModel.h   |   2 +
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 130 +++++++++++++++++----
 qtfred/ui/VariableDialog.ui                        |  47 +++++++-
 4 files changed, 180 insertions(+), 27 deletions(-)

------------------------------------------------------------------------
commit 8dde6d47c
Author: JohnAFernandez
Commit: JohnAFernandez

    More spacing adjustments and text changes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  4 ++--
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 16 ++++++++--------
 qtfred/ui/VariableDialog.ui                        |  6 +++---
 3 files changed, 13 insertions(+), 13 deletions(-)

------------------------------------------------------------------------
commit 98e78ec08
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix Containers Not Restoring Deleted Items
 qtfred/src/ui/dialogs/VariableDialog.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

------------------------------------------------------------------------
commit e1b9832fa
Author: JohnAFernandez
Commit: JohnAFernandez

    Fixes Based on Testing
 qtfred/src/ui/dialogs/VariableDialog.cpp | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

------------------------------------------------------------------------
commit c9e11d465
Author: JohnAFernandez
Commit: JohnAFernandez

    Fixes Based On Testing
 qtfred/src/ui/dialogs/VariableDialog.cpp | 110 +++++++++++++++++++------------
 qtfred/ui/VariableDialog.ui              |  15 ++++-
 2 files changed, 81 insertions(+), 44 deletions(-)

------------------------------------------------------------------------
commit d7c4c544e
Author: JohnAFernandez
Commit: JohnAFernandez

    Bug fixes according to testing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 35 ++++++----------------
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 25 +++++++++-------
 2 files changed, 24 insertions(+), 36 deletions(-)

------------------------------------------------------------------------
commit 50762246c
Author: JohnAFernandez
Commit: JohnAFernandez

    Fixes based on linter
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 36 +++++++++++-----------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 35 ++++++++++++---------
 qtfred/ui/VariableDialog.ui                        | 22 ++++++-------
 4 files changed, 50 insertions(+), 45 deletions(-)

------------------------------------------------------------------------
commit d04ce617f
Author: John Fernandez
Commit: John Fernandez

    Add swap keys and values button
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 101 +++++++++++++++++++++
 qtfred/src/mission/dialogs/VariableDialogModel.h   |   6 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  23 ++++-
 qtfred/src/ui/dialogs/VariableDialog.h             |   1 +
 4 files changed, 125 insertions(+), 6 deletions(-)

------------------------------------------------------------------------
commit 834042738
Author: John Fernandez
Commit: John Fernandez

    Make sure shift buttons apply the model
 qtfred/src/ui/dialogs/VariableDialog.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit eda645dcf
Author: John Fernandez
Commit: John Fernandez

    Make sure delete button changes text
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 89 +++++++++++++++++++---
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 10 ++-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 27 ++++++-
 3 files changed, 109 insertions(+), 17 deletions(-)

------------------------------------------------------------------------
commit 72b13631c
Author: John Fernandez
Commit: John Fernandez

    Implement sift up and down buttons
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 48 ++++++++++++
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  3 +
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 85 +++++++++++++++++++---
 qtfred/src/ui/dialogs/VariableDialog.h             |  2 +
 4 files changed, 128 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit 824b5bbb3
Author: John Fernandez
Commit: John Fernandez

    Write addNewVariable overload for typed items
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 6 ++++++
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 1 +
 2 files changed, 7 insertions(+)

------------------------------------------------------------------------
commit 2a8ec9cc4
Author: John Fernandez
Commit: John Fernandez

    Write setContainerKeyType
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 82 +++++++++++++++++++---
 1 file changed, 73 insertions(+), 9 deletions(-)

------------------------------------------------------------------------
commit 237bd53b6
Author: John Fernandez
Commit: John Fernandez

    Rename this variable for clarity
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 30 ++++++++++------------
 1 file changed, 14 insertions(+), 16 deletions(-)

------------------------------------------------------------------------
commit ba263d688
Author: JohnAFernandez
Commit: JohnAFernandez

    Trying to fixup The map/list switch function
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 129 +++++++++++----------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |   8 +-
 2 files changed, 72 insertions(+), 65 deletions(-)

------------------------------------------------------------------------
commit d333694a0
Author: JohnAFernandez
Commit: JohnAFernandez

    Adding Button for Key/Value Swap
 qtfred/ui/VariableDialog.ui | 83 ++++++++++++++++-----------------------------
 1 file changed, 29 insertions(+), 54 deletions(-)

------------------------------------------------------------------------
commit cf356ed3d
Author: John Fernandez
Commit: John Fernandez

    Finish writing change from list to map
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 85 +++++++++++++++++-----
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 12 +++
 2 files changed, 80 insertions(+), 17 deletions(-)

------------------------------------------------------------------------
commit 4677fb880
Author: John Fernandez
Commit: John Fernandez

    Start Applying List values to Keys, etc.
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 41 ++++++++++++++++++----
 1 file changed, 34 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit 5ee211203
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix Containers not deleting
 qtfred/src/ui/dialogs/VariableDialog.cpp | 1 +
 1 file changed, 1 insertion(+)

------------------------------------------------------------------------
commit 898f8a996
Author: JohnAFernandez
Commit: JohnAFernandez

    Increase size of dialog to store info better
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 25 ++++++------
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 14 +++----
 qtfred/ui/VariableDialog.ui                        | 44 ++++++++++++++--------
 3 files changed, 49 insertions(+), 34 deletions(-)

------------------------------------------------------------------------
commit c5b033235
Author: JohnAFernandez
Commit: JohnAFernandez

    More Fixes Based On Testing
 qtfred/src/ui/dialogs/VariableDialog.cpp | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit f1dd86477
Author: JohnAFernandez
Commit: JohnAFernandez

    More Fixes Based on testing
 qtfred/src/ui/dialogs/VariableDialog.cpp | 20 +++++++++++++++++++-
 qtfred/ui/VariableDialog.ui              | 16 ++++++++--------
 2 files changed, 27 insertions(+), 9 deletions(-)

------------------------------------------------------------------------
commit a8cc7d289
Author: JohnAFernandez
Commit: JohnAFernandez

    Appease the linter
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit e902f6d07
Author: JohnAFernandez
Commit: JohnAFernandez

    More change based on testing
 qtfred/src/ui/dialogs/VariableDialog.cpp | 61 +++++++++++++-------------------
 1 file changed, 24 insertions(+), 37 deletions(-)

------------------------------------------------------------------------
commit 0c2d1a7a1
Author: JohnAFernandez
Commit: JohnAFernandez

    Save Changes
 qtfred/src/ui/dialogs/VariableDialog.cpp |  2 +-
 qtfred/ui/VariableDialog.ui              | 71 +++++++++++++++++---------------
 2 files changed, 38 insertions(+), 35 deletions(-)

------------------------------------------------------------------------
commit c984faeda
Author: JohnAFernandez
Commit: JohnAFernandez

    Add Accept and Reject Signal Reactions
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  6 +++--
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 30 +++++++++++++++++++---
 qtfred/src/ui/dialogs/VariableDialog.h             |  3 +++
 qtfred/ui/VariableDialog.ui                        | 12 ++++-----
 5 files changed, 41 insertions(+), 12 deletions(-)

------------------------------------------------------------------------
commit dac5fbeb8
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix more Container issues based on testing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  6 +--
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 55 ++++------------------
 2 files changed, 13 insertions(+), 48 deletions(-)

------------------------------------------------------------------------
commit 94dbd9553
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix nullptr on copy
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

------------------------------------------------------------------------
commit 6e6b4098f
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix add container and add item rows
 qtfred/src/ui/dialogs/VariableDialog.cpp | 2 --
 1 file changed, 2 deletions(-)

------------------------------------------------------------------------
commit fc11ddcd4
Author: JohnAFernandez
Commit: JohnAFernandez

    Fixes Based On Linter and Testing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  8 +-
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 32 ++++++--
 qtfred/ui/VariableDialog.ui                        | 92 +++++++++++++---------
 4 files changed, 87 insertions(+), 47 deletions(-)

------------------------------------------------------------------------
commit ec4e50481
Author: John Fernandez
Commit: John Fernandez

    Hopefully fix Variable Persistence Not saving
 qtfred/src/ui/dialogs/VariableDialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit d143add82
Author: John Fernandez
Commit: John Fernandez

    Fixes to container options updates
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 22 ++++++++-------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  4 ++-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 31 ++++++++++++++++------
 3 files changed, 39 insertions(+), 18 deletions(-)

------------------------------------------------------------------------
commit ed3fcc8ac
Author: John Fernandez
Commit: John Fernandez

    Switch Key Options and Data Options
 qtfred/ui/VariableDialog.ui | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit c24457ff6
Author: John Fernandez
Commit: John Fernandez

    Add Clamping Function
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 43 ++++++++++++++--------
 1 file changed, 28 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit 4bb8456f6
Author: John Fernandez
Commit: John Fernandez

    Further Fix and Rename function for clarity
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 18 +++++++++++++-----
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  2 +-
 3 files changed, 15 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit 5503aec7b
Author: John Fernandez
Commit: John Fernandez

    Fix filtering out zero by accident
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit 4324b4110
Author: JohnAFernandez
Commit: JohnAFernandez

    More Fixes and Tweaks based on testing
 qtfred/src/ui/dialogs/VariableDialog.cpp |  31 +-
 qtfred/ui/VariableDialog.ui              | 541 +++++++++++++++++--------------
 2 files changed, 297 insertions(+), 275 deletions(-)

------------------------------------------------------------------------
commit 6134a42ef
Author: JohnAFernandez
Commit: JohnAFernandez

    Ton of fixes from testing
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 27 +++++++++----------
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 28 +++++++++----------
 qtfred/ui/VariableDialog.ui                        | 31 ++++++++++++++--------
 3 files changed, 47 insertions(+), 39 deletions(-)

------------------------------------------------------------------------
commit 2a4894d69
Author: John Fernandez
Commit: JohnAFernandez

    start implementing unified values in containers
------------------------------------------------------------------------
commit 55380f7e8
Author: John Fernandez
Commit: John Fernandez

    Start on SetContainerListOrMap
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 95 +++++++++++++++++++++-
 1 file changed, 93 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 3a5a2ab43
Author: John Fernandez
Commit: John Fernandez

    Linter errors from recent changes
 qtfred/src/ui/dialogs/VariableDialog.cpp | 2 +-
 qtfred/ui/VariableDialog.ui              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 4f0f57e71
Author: John Fernandez
Commit: John Fernandez

    Clean up the model in a few places
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

------------------------------------------------------------------------
commit 880167230
Author: John Fernandez
Commit: John Fernandez

    Fix more linter errors
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 10 ++++++----
 qtfred/src/ui/dialogs/VariableDialog.cpp           |  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

------------------------------------------------------------------------
commit a18ac34c0
Author: John Fernandez
Commit: John Fernandez

    Fix Linter errors
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 4 ++--
 qtfred/src/mission/dialogs/VariableDialogModel.h   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

------------------------------------------------------------------------
commit dd44d7d13
Author: John Fernandez
Commit: John Fernandez

    Fixing more issues
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 190 ++++++++++-----------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  31 ++++
 qtfred/src/ui/dialogs/VariableDialog.cpp           |   3 +-
 3 files changed, 128 insertions(+), 96 deletions(-)

------------------------------------------------------------------------
commit 84cad8c18
Author: John Fernandez
Commit: John Fernandez

    More Fixes and polish
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 8 ++++----
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

------------------------------------------------------------------------
commit 9dfc6d7c6
Author: John Fernandez
Commit: John Fernandez

    Fixes for UI bugs
 qtfred/src/ui/dialogs/VariableDialog.cpp | 49 +++++++++++++++++---------------
 1 file changed, 26 insertions(+), 23 deletions(-)

------------------------------------------------------------------------
commit 3c7639a9e
Author: JohnAFernandez
Commit: JohnAFernandez

    And one more apparently
 qtfred/src/ui/dialogs/VariableDialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit 7f1e72ecc
Author: JohnAFernandez
Commit: JohnAFernandez

    Some final ui adjustments
 qtfred/src/ui/dialogs/VariableDialog.cpp |  8 +++---
 qtfred/ui/VariableDialog.ui              | 44 ++++++++++++++++++++------------
 2 files changed, 31 insertions(+), 21 deletions(-)

------------------------------------------------------------------------
commit d14733073
Author: JohnAFernandez
Commit: JohnAFernandez

    Fix null item crash
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  8 ++++----
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 17 ++++++++++-------
 2 files changed, 14 insertions(+), 11 deletions(-)

------------------------------------------------------------------------
commit f38dbae31
Author: John Fernandez
Commit: John Fernandez

    Save changes to transfer over
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 7f0666cc3
Author: John Fernandez
Commit: John Fernandez

    More Fixes, but Requires Linter For more progress
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  2 +-
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 11 ++++++-----
 3 files changed, 8 insertions(+), 7 deletions(-)

------------------------------------------------------------------------
commit 91723be9c
Author: John Fernandez
Commit: John Fernandez

    And stub another function for now
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 5 +++++
 1 file changed, 5 insertions(+)

------------------------------------------------------------------------
commit 4e669f9ce
Author: John Fernandez
Commit: John Fernandez

    don't forget to change name.
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 3 +++
 1 file changed, 3 insertions(+)

------------------------------------------------------------------------
commit 209e905a0
Author: John Fernandez
Commit: John Fernandez

    Add copy Container Function
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 13 +++++++++++++
 1 file changed, 13 insertions(+)

------------------------------------------------------------------------
commit a82db02b4
Author: John Fernandez
Commit: John Fernandez

    Fix missing function
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit 22663cb29
Author: John Fernandez
Commit: John Fernandez

    Finish Dialog Code
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |   4 +-
 qtfred/src/mission/dialogs/VariableDialogModel.h   |   3 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 103 ++++++++++++++++++---
 3 files changed, 95 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit 3698cbe09
Author: John Fernandez
Commit: John Fernandez

    Hopefully Final Linter mistakes
 qtfred/src/ui/dialogs/VariableDialog.cpp | 26 +++++++++++++++-----------
 qtfred/src/ui/dialogs/VariableDialog.h   |  2 +-
 2 files changed, 16 insertions(+), 12 deletions(-)

------------------------------------------------------------------------
commit 29754cafc
Author: John Fernandez
Commit: John Fernandez

    More Linter Fixes
 qtfred/src/ui/dialogs/VariableDialog.cpp | 20 ++++++++++----------
 qtfred/src/ui/dialogs/VariableDialog.h   |  2 ++
 2 files changed, 12 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit 474527ef8
Author: John Fernandez
Commit: John Fernandez

    More Linter Fixes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  3 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 41 +++++++++++-----------
 2 files changed, 22 insertions(+), 22 deletions(-)

------------------------------------------------------------------------
commit ce32ef302
Author: John Fernandez
Commit: John Fernandez

    Linter Fixes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  5 +-
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  4 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 85 ++++++++++++----------
 3 files changed, 53 insertions(+), 41 deletions(-)

------------------------------------------------------------------------
commit 792cf0a0e
Author: John Fernandez
Commit: John Fernandez

    More fixes
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 16 ++++++++--------
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 22 ++++++++++++----------
 2 files changed, 20 insertions(+), 18 deletions(-)

------------------------------------------------------------------------
commit 314ba9278
Author: John Fernandez
Commit: John Fernandez

    Fix Compiler Errors
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 18 +++++++++---------
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

------------------------------------------------------------------------
commit 626465609
Author: John Fernandez
Commit: John Fernandez

    As far as I can tell populating items is done
 qtfred/src/ui/dialogs/VariableDialog.cpp | 167 ++++++++++++++++++++++++++++++-
 1 file changed, 164 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit 6bd3b43cd
Author: John Fernandez
Commit: John Fernandez

    Don't forget extra line left by accident
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 1 -
 1 file changed, 1 deletion(-)

------------------------------------------------------------------------
commit 3bec6d8cf
Author: John Fernandez
Commit: John Fernandez

    No const here
 qtfred/src/mission/dialogs/VariableDialogModel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

------------------------------------------------------------------------
commit 72271be1f
Author: John Fernandez
Commit: John Fernandez

    Getting closer to completion of basics
 qtfred/src/ui/dialogs/VariableDialog.cpp | 135 +++++++++++++++++++++++++++----
 1 file changed, 121 insertions(+), 14 deletions(-)

------------------------------------------------------------------------
commit bb838ea4d
Author: John Fernandez
Commit: John Fernandez

    Place getCurrentContainerRow in more places
 qtfred/src/ui/dialogs/VariableDialog.cpp | 122 +++++++++++++------------------
 1 file changed, 51 insertions(+), 71 deletions(-)

------------------------------------------------------------------------
commit ad74c21b8
Author: John Fernandez
Commit: John Fernandez

    Edit onVariablesTableUpdated
 qtfred/src/mission/dialogs/VariableDialogModel.h |   1 +
 qtfred/src/ui/dialogs/VariableDialog.cpp         | 204 ++++++++++++-----------
 2 files changed, 110 insertions(+), 95 deletions(-)

------------------------------------------------------------------------
commit e7b0f6187
Author: John Fernandez
Commit: John Fernandez

    Start applying currentVariableRow
 qtfred/src/ui/dialogs/VariableDialog.cpp | 113 ++++++++++++++++---------------
 1 file changed, 57 insertions(+), 56 deletions(-)

------------------------------------------------------------------------
commit 7c37628e1
Author: John Fernandez
Commit: John Fernandez

    Add get item rows to reduce duplicate code
 qtfred/src/mission/dialogs/VariableDialogModel.h |   1 +
 qtfred/src/ui/dialogs/VariableDialog.cpp         | 140 ++++++++++++++++++++++-
 qtfred/src/ui/dialogs/VariableDialog.h           |   3 +
 3 files changed, 138 insertions(+), 6 deletions(-)

------------------------------------------------------------------------
commit 2a337133c
Author: John Fernandez
Commit: John Fernandez

    Fixes and add a couple more UI functions
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 18 +++--
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  1 +
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 91 +++++++++++++++-------
 3 files changed, 74 insertions(+), 36 deletions(-)

------------------------------------------------------------------------
commit a06cb0c68
Author: John Fernandez
Commit: John Fernandez

    More progress on updateContainerDataOptions
 qtfred/src/ui/dialogs/VariableDialog.cpp | 41 +++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

------------------------------------------------------------------------
commit e4254636d
Author: John Fernandez
Commit: John Fernandez

    Finish addMapItem and upgrade getcontainernames
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 171 +++++++++++++++++++--
 qtfred/src/mission/dialogs/VariableDialogModel.h   |   5 +-
 qtfred/src/ui/dialogs/VariableDialog.cpp           |   4 +-
 3 files changed, 165 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit f61649e91
Author: John Fernandez
Commit: John Fernandez

    Add type text to container Table
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 28 ++++++++++++++++++++--
 qtfred/src/mission/dialogs/VariableDialogModel.h   |  1 +
 2 files changed, 27 insertions(+), 2 deletions(-)

------------------------------------------------------------------------
commit 83fde5acf
Author: John Fernandez
Commit: John Fernandez

    Actually, upgrade the lambda
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 37 +++++++++++++---------
 1 file changed, 22 insertions(+), 15 deletions(-)

------------------------------------------------------------------------
commit 7d7b6eeeb
Author: John Fernandez
Commit: John Fernandez

    Prevent crash from empty source string
 qtfred/src/mission/dialogs/VariableDialogModel.cpp | 4 ++++
 1 file changed, 4 insertions(+)

------------------------------------------------------------------------
commit 94057c5ef
Author: John Fernandez
Commit: John Fernandez

    Clean up container data updates
 qtfred/src/mission/dialogs/VariableDialogModel.cpp |  37 +++++++
 qtfred/src/mission/dialogs/VariableDialogModel.h   |   4 +
 qtfred/src/ui/dialogs/VariableDialog.cpp           | 122 ++++++++-------------
 qtfred/src/ui/dialogs/VariableDialog.h             |   1 -
 4 files changed, 86 insertions(+), 78 deletions(-)

------------------------------------------------------------------------
commit 6fe5ab7dc
Author: John Fernandez
Commit: John Fernandez

    Fix No Persistence not updating
 qtfred/src/ui/dialogs/VariableDialog.cpp | 71 ++++++++++++++++++++++----------
 qtfred/src/ui/dialogs/VariableDialog.h   |  2 +
 qtfred/ui/VariableDialog.ui              |  2 +-
 3 files changed, 53 insertions(+), 22 deletions(-)

------------------------------------------------------------------------
commit a57949c74
Author: JohnAFernandez
Commit: JohnAFernandez

    getting closer to correct width
 qtfred/src/ui/dialogs/VariableDialog.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

------------------------------------------------------------------------
commit 24310690f
Author: JohnAFernandez
Commit: JohnAFernandez

    more progress
 qtfred/ui/VariableDialog.ui | 390 +++++++++++++++++++++-----------------------
 1 file change