[blowfish]

Anyone else wanna help get the ship template code committed?

[blowfish]

again

I finally figured out how to create a diff.  I went through it, and it looks like almost all of it actually pertains to ship templates (the rest is not my fault).  Anyway, here it is:

[attachment deleted by admin]

[karajorma]

Is this tested and working now?

[blowfish]

Yes.  It works fine for me.

I haven't *tried* to break it though.

[karajorma]

Try.

If you can't break it with anything current I'll add it to the 3.6.10 branch.

[blowfish]

All right.  I've gone through this a little, and I haven't been able to break it really.

There is one small thing though.  This really applies to all ships, though it could mean something different in the context of ship templates.  If a template that a ship is supposed to use is not found (or hasn't been loaded yet), you will get nothing but a warning and everything will continue.  This might result in a ship missing vital data, such as POF file, which will crash the game later.  I'm not sure if this is really worth fixing though, as the same would apply to a ship that didn't have any values (like pof file) defined (one that didn't use ship templates).

Otherwise, this code seems pretty stable to me.

[blowfish]

Has this been forgotten?

Sorry if I'm being annoying, but I really want to see this committed (unless there's a reason why you think it shouldn't be committed ).

[karajorma]

Actually it's on my list to do today at some point. I just wanted to commit the stuff from my last recent build before doing so. (It's been sitting around as a NEW post for the last couple of days so I didn't forget it).

[blowfish]

Actually it's on my list to do today at some point. I just wanted to commit the stuff from my last recent build before doing so. (It's been sitting around as a NEW post for the last couple of days so I didn't forget it).

Sorry, I didn't know

[karajorma]

No need to apologise. Anyway it's committed now.

[blowfish]

THANK YOU KARA!!!

for committing this.  And thank you phreak for teaching me how to make diffs, and thank you taylor for giving me the idea to do this in the first place ... sometimes I just want to thank the whole SCP team!!!

EDIT:  And almost forgot turey, for writing this code in the first place